Title: [161225] branches/jsCStack/Source/_javascript_Core
- Revision
- 161225
- Author
- [email protected]
- Date
- 2014-01-02 14:16:59 -0800 (Thu, 02 Jan 2014)
Log Message
Address review feedback in https://bugs.webkit.org/show_bug.cgi?id=126387#c3
* llint/LowLevelInterpreter.asm:
Modified Paths
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161224 => 161225)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 22:15:58 UTC (rev 161224)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 22:16:59 UTC (rev 161225)
@@ -1,3 +1,9 @@
+2014-01-02 Filip Pizlo <[email protected]>
+
+ Address review feedback in https://bugs.webkit.org/show_bug.cgi?id=126387#c3
+
+ * llint/LowLevelInterpreter.asm:
+
2014-01-02 Mark Lam <[email protected]>
CStack: Get the C Loop LLINT to build again.
@@ -83,7 +89,7 @@
Some crashes in C stack on Mountain Lion, for example on crypto-aes, due to misaligned stack
https://bugs.webkit.org/show_bug.cgi?id=126394
- Not yet reviewed.
+ Reviewed by Michael Saboff.
The specialized math thunks currently ensure that inside the thunk, the stack is aligned. But when they
call the wrapper, the wrapper previously didn't align the stack. This patch fixes that.
Modified: branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter.asm (161224 => 161225)
--- branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2014-01-02 22:15:58 UTC (rev 161224)
+++ branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2014-01-02 22:16:59 UTC (rev 161225)
@@ -274,23 +274,32 @@
if X86 or X86_64
push cfr
move sp, cfr
- elsif ARM64 or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS
+ elsif ARM64
pushLRAndFP
+ elsif ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS
+ push cfr
+ push lr
end
end
macro functionEpilogue()
if X86 or X86_64
pop cfr
- elsif ARM64 or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS
+ elsif ARM64
popLRAndFP
+ elsif ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS
+ pop lr
+ pop cfr
end
end
macro callToJavaScriptPrologue()
if X86 or X86_64
- elsif ARM64 or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS
+ elsif ARM64
pushLRAndFP
+ elsif ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS
+ push cfr
+ push lr
end
pushCalleeSaves
end
@@ -301,8 +310,11 @@
popCalleeSaves
if X86 or X86_64
- elsif ARM64 or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS
+ elsif ARM64
popLRAndFP
+ elsif ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS
+ pop lr
+ pop cfr
end
end
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
