Title: [161232] branches/jsCStack/Source/_javascript_Core/ChangeLog
- Revision
- 161232
- Author
- mark....@apple.com
- Date
- 2014-01-02 15:20:26 -0800 (Thu, 02 Jan 2014)
Log Message
Added a missing word in a change comment, and updated review status for:
https://bugs.webkit.org/show_bug.cgi?id=126321
https://bugs.webkit.org/show_bug.cgi?id=126328
https://bugs.webkit.org/show_bug.cgi?id=126334
https://bugs.webkit.org/show_bug.cgi?id=126405
Modified Paths
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161231 => 161232)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 23:14:07 UTC (rev 161231)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 23:20:26 UTC (rev 161232)
@@ -3,14 +3,14 @@
CStack: Interpreter::executeCall() should check for exceptions after calling callToNativeFunction().
https://bugs.webkit.org/show_bug.cgi?id=126405.
- Not yet reviewed.
+ Reviewed by Michael Saboff.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
- executeCall() was expecting to return a non-null JSValue but neglected
to check if an exception was thrown during a call to callToNativeFunction.
We now check if an exception was thrown, and if so, we set the result to
- jsNull() the same that JITCode::execute() does.
+ jsNull() the same way that JITCode::execute() does.
2014-01-02 Filip Pizlo <fpi...@apple.com>
@@ -230,7 +230,7 @@
CStack: Introduce tracking of the top VMEntryScope.
https://bugs.webkit.org/show_bug.cgi?id=126334.
- Not yet reviewed.
+ Reviewed by Geoffrey Garen.
When we start measuring the stack usage of each VMEntryScope, we'll need
to know which VMEntryScope is the top (most recent) one, not just the
@@ -281,7 +281,7 @@
CStack: Fix JSStack::ensureCapacity() to match LLINT and JIT stack checks.
https://bugs.webkit.org/show_bug.cgi?id=126328.
- Not yet reviewed.
+ Reviewed by Geoffrey Garen.
Also removed the now unused JSSTack::topOfStackForCapacityCheck().
@@ -294,7 +294,7 @@
CStack: Introducing Options::maxStackSize().
https://bugs.webkit.org/show_bug.cgi?id=126321.
- Not yet reviewed.
+ Reviewed by Geoffrey Garen.
We need an option to limit the JS stack size. Currently, we just change
the JSStack class to use this limit.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
