Title: [161237] branches/jsCStack/Source/_javascript_Core
- Revision
- 161237
- Author
- [email protected]
- Date
- 2014-01-02 15:50:20 -0800 (Thu, 02 Jan 2014)
Log Message
Address review comments in https://bugs.webkit.org/show_bug.cgi?id=126409#c3
* llint/LowLevelInterpreter32_64.asm:
Modified Paths
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161236 => 161237)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 23:35:04 UTC (rev 161236)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 23:50:20 UTC (rev 161237)
@@ -1,11 +1,24 @@
2014-01-02 Filip Pizlo <[email protected]>
+ Address review comments in https://bugs.webkit.org/show_bug.cgi?id=126409#c3
+
+ * llint/LowLevelInterpreter32_64.asm:
+
+2014-01-02 Filip Pizlo <[email protected]>
+
CStack LLInt 32-bit should build
https://bugs.webkit.org/show_bug.cgi?id=126409
- Not yet reviewed.
+ Reviewed by Michael Saboff.
- And the stuff we do to make it build should at least try to be correct.
+ This attempst to get the 32-bit LLInt to do the same things that the 64-bit LLInt
+ does for the C stack. This was mostly just mechanical.
+
+ Only one part of the code didn't port cleanly, and that was the use of t6 in
+ handleUncaughtException. I changed it to t5 because as far as I can tell, t5 is
+ not live at that point in either version of the LLInt.
+
+ Note that we still can't build 32-bit yet so these changes are being done blind.
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
Modified: branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (161236 => 161237)
--- branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2014-01-02 23:35:04 UTC (rev 161236)
+++ branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2014-01-02 23:50:20 UTC (rev 161237)
@@ -162,7 +162,6 @@
const vm = a1
const protoCallFrame = a2
- const extraStackSpace = 16
const previousCFR = t3
const previousPC = lr
const temp1 = t3 # Same as previousCFR
@@ -174,7 +173,6 @@
const vm = a1
const protoCallFrame = a2
- const extraStackSpace = 28
const previousCFR = t3
const previousPC = lr
const temp1 = t3 # Same as previousCFR
@@ -187,7 +185,6 @@
const protoCallFrame = a2
const topOfStack = a3
- const extraStackSpace = 36
const previousCFR = t2
const previousPC = lr
const temp1 = t3
@@ -200,7 +197,6 @@
const protoCallFrame = a2
const topOfStack = a3
- const extraStackSpace = 20
const previousCFR = t3
const previousPC = lr
const temp1 = t3 # Same as previousCFR
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
