Title: [161255] trunk
Revision
161255
Author
[email protected]
Date
2014-01-02 23:56:55 -0800 (Thu, 02 Jan 2014)

Log Message

REGRESSION(r160304): [GTK] Disable libtool fast install
https://bugs.webkit.org/show_bug.cgi?id=126381

Reviewed by Martin Robinson.

.:

After r160304 we are building some of our binaries that are
installed with the -no-fast-install ld flag. This makes that the
binaries are installed with the source code path hardcoded in
binary RPATH. Disabling fast install globally, the libtool script
always relinks the binaries right before being installed.

* Source/autotools/SetupLibtool.m4: Add AC_DISABLE_FAST_INSTALL.

Source/_javascript_Core:

Remove -no-fast-install ld flag since fast install is now disabled
globally.

* GNUmakefile.am:

Source/WebKit/gtk:

* tests/GNUmakefile.am:

Source/WebKit2:

Remove -no-fast-install ld flag since fast install is now disabled
globally.

* GNUmakefile.am:
* UIProcess/API/gtk/tests/GNUmakefile.am:

Tools:

Remove -no-fast-install ld flag since fast install is now disabled
globally.

* GNUmakefile.am:
* GtkLauncher/GNUmakefile.am:
* MiniBrowser/gtk/GNUmakefile.am:
* TestWebKitAPI/GNUmakefile.am:
* WebKitTestRunner/GNUmakefile.am:

Modified Paths

Diff

Modified: trunk/ChangeLog (161254 => 161255)


--- trunk/ChangeLog	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/ChangeLog	2014-01-03 07:56:55 UTC (rev 161255)
@@ -1,3 +1,18 @@
+2014-01-02  Carlos Garcia Campos  <[email protected]>
+
+        REGRESSION(r160304): [GTK] Disable libtool fast install
+        https://bugs.webkit.org/show_bug.cgi?id=126381
+
+        Reviewed by Martin Robinson.
+
+        After r160304 we are building some of our binaries that are
+        installed with the -no-fast-install ld flag. This makes that the
+        binaries are installed with the source code path hardcoded in
+        binary RPATH. Disabling fast install globally, the libtool script
+        always relinks the binaries right before being installed.
+
+        * Source/autotools/SetupLibtool.m4: Add AC_DISABLE_FAST_INSTALL.
+
 2014-01-02  Jaehun Lim  <[email protected]>
 
         [CMake][EFL] Fix some typos in OptionsEfl.cmake

Modified: trunk/Source/_javascript_Core/ChangeLog (161254 => 161255)


--- trunk/Source/_javascript_Core/ChangeLog	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-01-03 07:56:55 UTC (rev 161255)
@@ -1,3 +1,15 @@
+2014-01-02  Carlos Garcia Campos  <[email protected]>
+
+        REGRESSION(r160304): [GTK] Disable libtool fast install
+        https://bugs.webkit.org/show_bug.cgi?id=126381
+
+        Reviewed by Martin Robinson.
+
+        Remove -no-fast-install ld flag since fast install is now disabled
+        globally.
+
+        * GNUmakefile.am:
+
 2014-01-02  Sam Weinig  <[email protected]>
 
         Update Promises to the https://github.com/domenic/promises-unwrapping spec

Modified: trunk/Source/_javascript_Core/GNUmakefile.am (161254 => 161255)


--- trunk/Source/_javascript_Core/GNUmakefile.am	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Source/_javascript_Core/GNUmakefile.am	2014-01-03 07:56:55 UTC (rev 161255)
@@ -131,8 +131,7 @@
 	-lstdc++
 
 Programs_minidom_LDFLAGS = \
-	-no-install \
-	-no-fast-install
+	-no-install
 
 Programs_LLIntOffsetsExtractor_CPPFLAGS = \
 	$(global_cppflags) \
@@ -155,8 +154,7 @@
 	-lstdc++
 
 Programs_LLIntOffsetsExtractor_LDFLAGS = \
-	-no-install \
-	-no-fast-install
+	-no-install
 
 # jsc
 Programs/jsc$(EXEEXT): Programs/jsc-@WEBKITGTK_API_MAJOR_VERSION@$(EXEEXT)

Modified: trunk/Source/WebKit/gtk/ChangeLog (161254 => 161255)


--- trunk/Source/WebKit/gtk/ChangeLog	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Source/WebKit/gtk/ChangeLog	2014-01-03 07:56:55 UTC (rev 161255)
@@ -1,3 +1,12 @@
+2014-01-02  Carlos Garcia Campos  <[email protected]>
+
+        REGRESSION(r160304): [GTK] Disable libtool fast install
+        https://bugs.webkit.org/show_bug.cgi?id=126381
+
+        Reviewed by Martin Robinson.
+
+        * tests/GNUmakefile.am:
+
 2014-01-02  Gavin Barraclough  <[email protected]>
 
         Merge didMoveOnscreen / page visibility to isVisible

Modified: trunk/Source/WebKit/gtk/tests/GNUmakefile.am (161254 => 161255)


--- trunk/Source/WebKit/gtk/tests/GNUmakefile.am	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Source/WebKit/gtk/tests/GNUmakefile.am	2014-01-03 07:56:55 UTC (rev 161255)
@@ -27,8 +27,7 @@
 	$(XRENDER_LIBS)
 
 webkit_tests_ldflags = \
-	-no-install \
-	-no-fast-install
+	-no-install
 
 if ENABLE_WEBKIT1
 noinst_PROGRAMS += \

Modified: trunk/Source/WebKit2/ChangeLog (161254 => 161255)


--- trunk/Source/WebKit2/ChangeLog	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Source/WebKit2/ChangeLog	2014-01-03 07:56:55 UTC (rev 161255)
@@ -1,3 +1,16 @@
+2014-01-02  Carlos Garcia Campos  <[email protected]>
+
+        REGRESSION(r160304): [GTK] Disable libtool fast install
+        https://bugs.webkit.org/show_bug.cgi?id=126381
+
+        Reviewed by Martin Robinson.
+
+        Remove -no-fast-install ld flag since fast install is now disabled
+        globally.
+
+        * GNUmakefile.am:
+        * UIProcess/API/gtk/tests/GNUmakefile.am:
+
 2014-01-02  Ryuan Choi  <[email protected]>
 
         [EFL][WK2] Remove defaultPageGroupIdentifier not to make the confusion

Modified: trunk/Source/WebKit2/GNUmakefile.am (161254 => 161255)


--- trunk/Source/WebKit2/GNUmakefile.am	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Source/WebKit2/GNUmakefile.am	2014-01-03 07:56:55 UTC (rev 161255)
@@ -578,9 +578,6 @@
 	$(GTK_UNIX_PRINTING_LIBS) \
 	$(LIBSOUP_LIBS)
 
-Programs_WebKitWebProcess_LDFLAGS = \
-	-no-fast-install
-
 libWebCoreGtk2_la_SOURCES = \
 	$(webcoregtk_sources)
 
@@ -799,9 +796,6 @@
 	$(WINMM_LIBS) \
 	$(ZLIB_LIBS)
 
-Programs_WebKitPluginProcess_LDFLAGS = \
-	-no-fast-install
-
 Programs_WebKitPluginProcess_CXXFLAGS = \
 	-fvisibility-inlines-hidden \
 	$(global_cxxflags)

Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am (161254 => 161255)


--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am	2014-01-03 07:56:55 UTC (rev 161255)
@@ -67,8 +67,7 @@
 	$(LIBSOUP_LIBS)
 
 webkit2_tests_ldflags = \
-	-no-install \
-	-no-fast-install
+	-no-install
 
 Programs/resources/webkit2gtk-tests-resources.gresource: Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml $(shell $(GLIB_COMPILE_RESOURCES) --sourcedir=$(srcdir) --generate-dependencies $(srcdir)/Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml)
 	$(AM_V_at)mkdir -p ${GENPROGRAMS}/resources

Modified: trunk/Source/autotools/SetupLibtool.m4 (161254 => 161255)


--- trunk/Source/autotools/SetupLibtool.m4	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Source/autotools/SetupLibtool.m4	2014-01-03 07:56:55 UTC (rev 161255)
@@ -12,6 +12,7 @@
 
 DOLT
 AC_DISABLE_STATIC
+AC_DISABLE_FAST_INSTALL
 AC_LIBTOOL_WIN32_DLL
 AC_PROG_LIBTOOL
 

Modified: trunk/Tools/ChangeLog (161254 => 161255)


--- trunk/Tools/ChangeLog	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Tools/ChangeLog	2014-01-03 07:56:55 UTC (rev 161255)
@@ -1,3 +1,19 @@
+2014-01-02  Carlos Garcia Campos  <[email protected]>
+
+        REGRESSION(r160304): [GTK] Disable libtool fast install
+        https://bugs.webkit.org/show_bug.cgi?id=126381
+
+        Reviewed by Martin Robinson.
+
+        Remove -no-fast-install ld flag since fast install is now disabled
+        globally.
+
+        * GNUmakefile.am:
+        * GtkLauncher/GNUmakefile.am:
+        * MiniBrowser/gtk/GNUmakefile.am:
+        * TestWebKitAPI/GNUmakefile.am:
+        * WebKitTestRunner/GNUmakefile.am:
+
 2014-01-02  Ryuan Choi  <[email protected]>
 
         Unreviewed. Add myself to EFL and related watch lists.

Modified: trunk/Tools/GNUmakefile.am (161254 => 161255)


--- trunk/Tools/GNUmakefile.am	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Tools/GNUmakefile.am	2014-01-03 07:56:55 UTC (rev 161255)
@@ -166,7 +166,6 @@
 	$(XT_LIBS)
 
 Programs_DumpRenderTree_LDFLAGS = \
-	-no-fast-install \
 	-no-install
 
 # ImageDiff
@@ -189,7 +188,6 @@
    $(GTK_LIBS)
 
 Programs_ImageDiff_LDFLAGS = \
-   -no-fast-install \
    -no-install
 
 # clean target

Modified: trunk/Tools/GtkLauncher/GNUmakefile.am (161254 => 161255)


--- trunk/Tools/GtkLauncher/GNUmakefile.am	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Tools/GtkLauncher/GNUmakefile.am	2014-01-03 07:56:55 UTC (rev 161255)
@@ -38,6 +38,5 @@
 	$(GSTREAMER_LIBS)
 
 Programs_GtkLauncher_LDFLAGS = \
-	-no-fast-install \
 	-no-install
 

Modified: trunk/Tools/MiniBrowser/gtk/GNUmakefile.am (161254 => 161255)


--- trunk/Tools/MiniBrowser/gtk/GNUmakefile.am	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Tools/MiniBrowser/gtk/GNUmakefile.am	2014-01-03 07:56:55 UTC (rev 161255)
@@ -45,7 +45,6 @@
 	$(LIBSOUP_LIBS)
 
 Programs_MiniBrowser_LDFLAGS = \
-	-no-fast-install \
 	-no-install
 
 CLEANFILES += \

Modified: trunk/Tools/TestWebKitAPI/GNUmakefile.am (161254 => 161255)


--- trunk/Tools/TestWebKitAPI/GNUmakefile.am	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Tools/TestWebKitAPI/GNUmakefile.am	2014-01-03 07:56:55 UTC (rev 161255)
@@ -48,8 +48,7 @@
 	$(GLIB_LIBS)
 
 Programs_TestWebKitAPI_TestWTF_LDFLAGS = \
-	-no-install \
-	-no-fast-install
+	-no-install
 
 Programs_TestWebKitAPI_TestWTF_SOURCES = \
 	Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp \
@@ -93,8 +92,7 @@
 	$(GTK_LIBS)
 
 Programs_TestWebKitAPI_TestJavaScriptCore_LDFLAGS = \
-	-no-install \
-	-no-fast-install
+	-no-install
 
 Programs_TestWebKitAPI_TestJavaScriptCore_SOURCES = \
 	Tools/TestWebKitAPI/Tests/_javascript_Core/VMInspector.cpp
@@ -167,8 +165,7 @@
 	$(ZLIB_LIBS)
 
 Programs_TestWebKitAPI_TestWebCore_LDFLAGS = \
-	-no-install \
-	-no-fast-install
+	-no-install
 
 Programs_TestWebKitAPI_TestWebCore_SOURCES = \
 	Tools/TestWebKitAPI/Tests/WebCore/URL.cpp \

Modified: trunk/Tools/WebKitTestRunner/GNUmakefile.am (161254 => 161255)


--- trunk/Tools/WebKitTestRunner/GNUmakefile.am	2014-01-03 07:48:05 UTC (rev 161254)
+++ trunk/Tools/WebKitTestRunner/GNUmakefile.am	2014-01-03 07:56:55 UTC (rev 161255)
@@ -64,7 +64,6 @@
 	$(XT_LIBS)
 
 Programs_WebKitTestRunner_LDFLAGS = \
-	-no-fast-install \
 	-no-install
 
 # The InjectedBundle library allows the render process to load harness code.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to