Title: [161261] trunk/Tools
- Revision
- 161261
- Author
- [email protected]
- Date
- 2014-01-03 09:00:50 -0800 (Fri, 03 Jan 2014)
Log Message
Provide a visual clue when element has a popover at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126281
Reviewed by Timothy Hatcher.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
(PopoverTracker): Add a class name to elements with popovers.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(*): We have -webkit-user-select:none, so let's also not show text selection cursor.
I might have broke that recently.
(*:link): Show hand cursor over links.
(.popover-tracking:hover): Put a shadow on hover over element with popovers.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line .message .revision-number): Show text selection cursor on our only
selectable text element.
(.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
a white shadow than with a dark one on hover.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js (161260 => 161261)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js 2014-01-03 16:57:18 UTC (rev 161260)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js 2014-01-03 17:00:50 UTC (rev 161261)
@@ -35,6 +35,7 @@
this._context = context;
this._active = false;
+ element.classList.add("popover-tracking");
element.addEventListener("mouseenter", this._mouseEnteredPopoverOrElement.bind(this), true);
element.addEventListener("mouseleave", this._mouseExitedPopoverOrElement.bind(this), true);
};
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css (161260 => 161261)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2014-01-03 16:57:18 UTC (rev 161260)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2014-01-03 17:00:50 UTC (rev 161261)
@@ -27,8 +27,13 @@
box-sizing: border-box;
-webkit-user-select: none;
-webkit-user-drag: none;
+ cursor: default;
}
+*:link {
+ cursor: pointer;
+}
+
a {
text-decoration: none;
}
@@ -191,3 +196,6 @@
content: -webkit-image-set(url(../Images/[email protected]) 2x, url(../Images/EFL.png) 1x);
}
+.popover-tracking:hover {
+ text-shadow: 0px 0px 3px rgba(0, 0, 0, 0.2)
+}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css (161260 => 161261)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css 2014-01-03 16:57:18 UTC (rev 161260)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css 2014-01-03 17:00:50 UTC (rev 161261)
@@ -103,6 +103,7 @@
.status-line .message .revision-number {
-webkit-user-select: auto;
+ cursor: text;
}
.status-line.no-label .message {
@@ -134,3 +135,7 @@
.status-line.bad .message {
color: rgb(191, 67, 41);
}
+
+.status-line .bubble.popover-tracking:hover {
+ text-shadow: 0px 0px 5px rgba(255, 255, 255, 0.7)
+}
Modified: trunk/Tools/ChangeLog (161260 => 161261)
--- trunk/Tools/ChangeLog 2014-01-03 16:57:18 UTC (rev 161260)
+++ trunk/Tools/ChangeLog 2014-01-03 17:00:50 UTC (rev 161261)
@@ -1,3 +1,25 @@
+2014-01-03 Alexey Proskuryakov <[email protected]>
+
+ Provide a visual clue when element has a popover at build.webkit.org/dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=126281
+
+ Reviewed by Timothy Hatcher.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
+ (PopoverTracker): Add a class name to elements with popovers.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
+ (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
+ I might have broke that recently.
+ (*:link): Show hand cursor over links.
+ (.popover-tracking:hover): Put a shadow on hover over element with popovers.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
+ (.status-line .message .revision-number): Show text selection cursor on our only
+ selectable text element.
+ (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
+ a white shadow than with a dark one on hover.
+
2014-01-02 Carlos Garcia Campos <[email protected]>
[GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
