Title: [161290] trunk/Tools
- Revision
- 161290
- Author
- [email protected]
- Date
- 2014-01-03 15:38:44 -0800 (Fri, 03 Jan 2014)
Log Message
build.webkit.org/dashboard says "failed build" even if it's another step that failed
https://bugs.webkit.org/show_bug.cgi?id=126461
Reviewed by Geoffrey Garen.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
build page if it's not the compilation that failed. Use text from buildbot for description.
Show a yellow icon if it's a different kind of failure.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js (161289 => 161290)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2014-01-03 23:25:46 UTC (rev 161289)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2014-01-03 23:38:44 UTC (rev 161290)
@@ -66,15 +66,25 @@
if (firstRecentFailedIteration && firstRecentFailedIteration.loaded) {
var failureCount = queue.recentFailedIterationCount;
var message = this.revisionContentForIteration(firstRecentFailedIteration);
- var url = ""
- var status = new StatusLineView(message, StatusLineView.Status.Bad, failureCount > 1 ? "failed builds since" : "failed build", failureCount > 1 ? failureCount : null, url);
+ if (firstRecentFailedIteration.webkitCompilationFailed) {
+ // Link directly to compiler output.
+ // FIXME: Results JSON may contain multiple log links, including one for nicely filtered result.
+ // Which one is best to use? Do we want the filtered one in a popover?
+ var url = ""
+ var status = StatusLineView.Status.Bad;
+ } else {
+ // Some other step failed, link to main buildbot page for the iteration.
+ var url = ""
+ var status = StatusLineView.Status.Danger;
+ }
+ var status = new StatusLineView(message, status, failureCount > 1 ? "failures since" : firstRecentFailedIteration.text, failureCount > 1 ? failureCount : null, url);
this.element.appendChild(status.element);
}
var mostRecentSuccessfulIteration = queue.mostRecentSuccessfulIteration;
if (mostRecentSuccessfulIteration && mostRecentSuccessfulIteration.loaded) {
var message = this.revisionContentForIteration(mostRecentSuccessfulIteration);
- var url = ""
+ var url = ""
var status = new StatusLineView(message, StatusLineView.Status.Good, firstRecentFailedIteration ? "last successful build" : "latest build", null, url);
this.element.appendChild(status.element);
} else {
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (161289 => 161290)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2014-01-03 23:25:46 UTC (rev 161289)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2014-01-03 23:38:44 UTC (rev 161290)
@@ -48,6 +48,14 @@
BaseObject.addConstructorFunctions(BuildbotIteration);
+// JSON result values for both individual steps and the whole iteration.
+BuildbotIteration.SUCCESS = 0;
+BuildbotIteration.WARNINGS = 1;
+BuildbotIteration.FAILURE = 2;
+BuildbotIteration.SKIPPED = 3;
+BuildbotIteration.EXCEPTION = 4;
+BuildbotIteration.RETRY = 5;
+
BuildbotIteration.Event = {
Updated: "updated"
};
@@ -154,6 +162,10 @@
var internalRevisionProperty = data.properties.findFirst(function(property) { return property[0] === "internal_got_revision"; });
this.internalRevision = internalRevisionProperty ? parseInt(internalRevisionProperty[1], 10) : null;
+ var compileWebKitStep = data.steps.findFirst(function(step) { return step.name === "compile-webkit"; });
+ if (compileWebKitStep)
+ this.webkitCompilationFailed = compileWebKitStep.results[0] !== BuildbotIteration.SUCCESS;
+
var layoutTestResults = collectTestResults.call(this, data, "layout-test");
this.layoutTestResults = layoutTestResults ? new BuildbotTestResults(this, layoutTestResults) : null;
@@ -174,10 +186,8 @@
this.loaded = true;
- // Results values (same for the iteration and for each of its steps):
- // SUCCESS: 0, WARNINGS: 1, FAILURE: 2, SKIPPED: 3, EXCEPTION: 4, RETRY: 5.
this.failed = !!data.results;
- this.willRetry = data.results === 5;
+ this.willRetry = data.results === BuildbotIteration.RETRY;
this.text = data.text.join(" ");
Modified: trunk/Tools/ChangeLog (161289 => 161290)
--- trunk/Tools/ChangeLog 2014-01-03 23:25:46 UTC (rev 161289)
+++ trunk/Tools/ChangeLog 2014-01-03 23:38:44 UTC (rev 161290)
@@ -1,3 +1,18 @@
+2014-01-03 Alexey Proskuryakov <[email protected]>
+
+ build.webkit.org/dashboard says "failed build" even if it's another step that failed
+ https://bugs.webkit.org/show_bug.cgi?id=126461
+
+ Reviewed by Geoffrey Garen.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
+ (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
+ build page if it's not the compilation that failed. Use text from buildbot for description.
+ Show a yellow icon if it's a different kind of failure.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
+
2014-01-03 Bem Jones-Bey <[email protected]>
setup-git-clone fails to get email address from git
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
