Title: [161295] trunk/Tools
- Revision
- 161295
- Author
- [email protected]
- Date
- 2014-01-03 16:24:08 -0800 (Fri, 03 Jan 2014)
Log Message
It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126467
Reviewed by Geoffrey Garen.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
(StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
pointer, or to tap.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js (161294 => 161295)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js 2014-01-04 00:20:27 UTC (rev 161294)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js 2014-01-04 00:24:08 UTC (rev 161295)
@@ -43,12 +43,7 @@
if (status != StatusLineView.Status.NoBubble)
this.element.appendChild(this._statusBubbleElement);
- if (url) {
- this._labelElement = document.createElement("a");
- this._labelElement.href = ""
- this._labelElement.target = "_blank";
- } else
- this._labelElement = document.createElement("div");
+ this._labelElement = document.createElement("div");
this._labelElement.classList.add("label");
this._messageElement = document.createElement("div");
Modified: trunk/Tools/ChangeLog (161294 => 161295)
--- trunk/Tools/ChangeLog 2014-01-04 00:20:27 UTC (rev 161294)
+++ trunk/Tools/ChangeLog 2014-01-04 00:24:08 UTC (rev 161295)
@@ -1,5 +1,16 @@
2014-01-03 Alexey Proskuryakov <[email protected]>
+ It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=126467
+
+ Reviewed by Geoffrey Garen.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
+ (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
+ pointer, or to tap.
+
+2014-01-03 Alexey Proskuryakov <[email protected]>
+
build.webkit.org/dashboard says "failed build" even if it's another step that failed
https://bugs.webkit.org/show_bug.cgi?id=126461
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
