Diff
Modified: trunk/Source/WebCore/ChangeLog (161381 => 161382)
--- trunk/Source/WebCore/ChangeLog 2014-01-06 23:50:43 UTC (rev 161381)
+++ trunk/Source/WebCore/ChangeLog 2014-01-07 00:05:48 UTC (rev 161382)
@@ -1,3 +1,23 @@
+2014-01-06 Seokju Kwon <[email protected]>
+
+ Web Inspector: Get rid of Inspector/BindingVisitors.h
+ https://bugs.webkit.org/show_bug.cgi?id=126374
+
+ Reviewed by Joseph Pecoraro.
+
+ No new tests, No change in behavior.
+
+ In r161204, methods related to BindingVisitors was removed.
+
+ * GNUmakefile.list.am:
+ * WebCore.vcxproj/WebCore.vcxproj:
+ * WebCore.vcxproj/WebCore.vcxproj.filters:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/ScriptProfiler.h:
+ * inspector/BindingVisitors.h: Removed.
+ * inspector/InspectorCanvasAgent.cpp:
+ * inspector/InspectorMemoryAgent.cpp:
+
2014-01-06 Tim Horton <[email protected]>
Add {IntRect, FloatRect}::infiniteRect() and ::isInfinite()
Modified: trunk/Source/WebCore/GNUmakefile.list.am (161381 => 161382)
--- trunk/Source/WebCore/GNUmakefile.list.am 2014-01-06 23:50:43 UTC (rev 161381)
+++ trunk/Source/WebCore/GNUmakefile.list.am 2014-01-07 00:05:48 UTC (rev 161382)
@@ -3775,7 +3775,6 @@
Source/WebCore/icu/unicode/utf_old.h \
Source/WebCore/icu/unicode/utypes.h \
Source/WebCore/icu/unicode/uversion.h \
- Source/WebCore/inspector/BindingVisitors.h \
Source/WebCore/inspector/CommandLineAPIHost.cpp \
Source/WebCore/inspector/CommandLineAPIHost.h \
Source/WebCore/inspector/CommandLineAPIModule.cpp \
Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (161381 => 161382)
--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-01-06 23:50:43 UTC (rev 161381)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-01-07 00:05:48 UTC (rev 161382)
@@ -21001,7 +21001,6 @@
<ClInclude Include="..\bridge\runtime_method.h" />
<ClInclude Include="..\bridge\runtime_object.h" />
<ClInclude Include="..\bridge\runtime_root.h" />
- <ClInclude Include="..\inspector\BindingVisitors.h" />
<ClInclude Include="..\inspector\ConsoleAPITypes.h" />
<ClInclude Include="..\inspector\CommandLineAPIHost.h" />
<ClInclude Include="..\inspector\CommandLineAPIModule.h" />
Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters (161381 => 161382)
--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2014-01-06 23:50:43 UTC (rev 161381)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2014-01-07 00:05:48 UTC (rev 161382)
@@ -12401,9 +12401,6 @@
<ClInclude Include="..\bridge\runtime_root.h">
<Filter>bridge</Filter>
</ClInclude>
- <ClInclude Include="..\inspector\BindingVisitors.h">
- <Filter>inspector</Filter>
- </ClInclude>
<ClInclude Include="..\inspector\CommandLineAPIHost.h">
<Filter>inspector</Filter>
</ClInclude>
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (161381 => 161382)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-01-06 23:50:43 UTC (rev 161381)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-01-07 00:05:48 UTC (rev 161382)
@@ -5933,7 +5933,6 @@
F34742E81343635000531BC2 /* WorkerScriptDebugServer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F34742E61343635000531BC2 /* WorkerScriptDebugServer.cpp */; };
F34742E91343635000531BC2 /* WorkerScriptDebugServer.h in Headers */ = {isa = PBXBuildFile; fileRef = F34742E71343635000531BC2 /* WorkerScriptDebugServer.h */; };
F350B73513F1377D00880C43 /* InstrumentingAgents.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F350B73413F1377D00880C43 /* InstrumentingAgents.cpp */; };
- F35AE5AC14925F5B004D5776 /* BindingVisitors.h in Headers */ = {isa = PBXBuildFile; fileRef = F35AE5AB14925F5B004D5776 /* BindingVisitors.h */; };
F3644AFF1119805900E0D537 /* InjectedScript.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F3644AFD1119805900E0D537 /* InjectedScript.cpp */; };
F3644B001119805900E0D537 /* InjectedScript.h in Headers */ = {isa = PBXBuildFile; fileRef = F3644AFE1119805900E0D537 /* InjectedScript.h */; };
F36E07A41358A8BE00AACBC9 /* WorkerInspectorController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F36E07A21358A8BE00AACBC9 /* WorkerInspectorController.cpp */; };
@@ -13140,7 +13139,6 @@
F34742E61343635000531BC2 /* WorkerScriptDebugServer.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WorkerScriptDebugServer.cpp; sourceTree = "<group>"; };
F34742E71343635000531BC2 /* WorkerScriptDebugServer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WorkerScriptDebugServer.h; sourceTree = "<group>"; };
F350B73413F1377D00880C43 /* InstrumentingAgents.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InstrumentingAgents.cpp; sourceTree = "<group>"; };
- F35AE5AB14925F5B004D5776 /* BindingVisitors.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = BindingVisitors.h; sourceTree = "<group>"; };
F3644AFD1119805900E0D537 /* InjectedScript.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InjectedScript.cpp; sourceTree = "<group>"; };
F3644AFE1119805900E0D537 /* InjectedScript.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InjectedScript.h; sourceTree = "<group>"; };
F36E07A21358A8BE00AACBC9 /* WorkerInspectorController.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WorkerInspectorController.cpp; sourceTree = "<group>"; };
@@ -14565,7 +14563,6 @@
A593CF7218402CE900BFCE27 /* protocol */,
A518225317E28CF100A9BA1D /* Scripts */,
A593CF7518402D4B00BFCE27 /* combine-_javascript_-resources.pl */,
- F35AE5AB14925F5B004D5776 /* BindingVisitors.h */,
A584FE311864D5AF00843B10 /* CommandLineAPIHost.cpp */,
A584FE321864D5AF00843B10 /* CommandLineAPIHost.h */,
A584FE331864D5AF00843B10 /* CommandLineAPIHost.idl */,
@@ -22382,7 +22379,6 @@
B2C3DA250D006C1D00EF6F26 /* BidiResolver.h in Headers */,
BCE789861120E7A60060ECE5 /* BidiRun.h in Headers */,
A8C402931348B2220063F1E5 /* BidiRunList.h in Headers */,
- F35AE5AC14925F5B004D5776 /* BindingVisitors.h in Headers */,
FD31608D12B026F700C1A359 /* Biquad.h in Headers */,
FD31602512B0267600C1A359 /* BiquadDSPKernel.h in Headers */,
FDC54F051399B0DA008D9117 /* BiquadFilterNode.h in Headers */,
Modified: trunk/Source/WebCore/bindings/js/ScriptProfiler.h (161381 => 161382)
--- trunk/Source/WebCore/bindings/js/ScriptProfiler.h 2014-01-06 23:50:43 UTC (rev 161381)
+++ trunk/Source/WebCore/bindings/js/ScriptProfiler.h 2014-01-07 00:05:48 UTC (rev 161382)
@@ -42,9 +42,6 @@
namespace WebCore {
-class ExternalArrayVisitor;
-class ExternalStringVisitor;
-class WrappedNodeVisitor;
class Page;
class WorkerGlobalScope;
Deleted: trunk/Source/WebCore/inspector/BindingVisitors.h (161381 => 161382)
--- trunk/Source/WebCore/inspector/BindingVisitors.h 2014-01-06 23:50:43 UTC (rev 161381)
+++ trunk/Source/WebCore/inspector/BindingVisitors.h 2014-01-07 00:05:48 UTC (rev 161382)
@@ -1,65 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of
- * its contributors may be used to endorse or promote products derived
- * from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
- * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef BindingVisitors_h
-#define BindingVisitors_h
-
-namespace WTF {
-class ArrayBufferView;
-class StringImpl;
-}
-
-namespace WebCore {
-
-class Node;
-
-class WrappedNodeVisitor {
-public:
- virtual void visitNode(Node*) = 0;
-protected:
- virtual ~WrappedNodeVisitor() { }
-};
-
-class ExternalStringVisitor {
-public:
- virtual void visitJSExternalString(WTF::StringImpl*) = 0;
-protected:
- virtual ~ExternalStringVisitor() { }
-};
-
-
-class ExternalArrayVisitor {
-public:
- virtual void visitJSExternalArray(WTF::ArrayBufferView*) = 0;
-protected:
- virtual ~ExternalArrayVisitor() { }
-};
-
-} // namespace WebCore
-
-#endif // BindingVisitors_h
Modified: trunk/Source/WebCore/inspector/InspectorCanvasAgent.cpp (161381 => 161382)
--- trunk/Source/WebCore/inspector/InspectorCanvasAgent.cpp 2014-01-06 23:50:43 UTC (rev 161381)
+++ trunk/Source/WebCore/inspector/InspectorCanvasAgent.cpp 2014-01-07 00:05:48 UTC (rev 161382)
@@ -34,7 +34,6 @@
#include "InspectorCanvasAgent.h"
-#include "BindingVisitors.h"
#include "DOMWindow.h"
#include "HTMLCanvasElement.h"
#include "HTMLNames.h"
Modified: trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp (161381 => 161382)
--- trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp 2014-01-06 23:50:43 UTC (rev 161381)
+++ trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp 2014-01-07 00:05:48 UTC (rev 161382)
@@ -34,7 +34,6 @@
#include "InspectorMemoryAgent.h"
-#include "BindingVisitors.h"
#include "CharacterData.h"
#include "Document.h"
#include "EventListenerMap.h"
