Title: [161451] trunk/Source/WTF
Revision
161451
Author
dfar...@apple.com
Date
2014-01-07 13:07:03 -0800 (Tue, 07 Jan 2014)

Log Message

[ASAN] Building with trunk clang corrupts sandbox profile with comment from Compiler.h
https://bugs.webkit.org/show_bug.cgi?id=124532

Reviewed by David Kilzer.

* wtf/Compiler.h:
Remove this quirk - it does nothing.

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (161450 => 161451)


--- trunk/Source/WTF/ChangeLog	2014-01-07 21:05:30 UTC (rev 161450)
+++ trunk/Source/WTF/ChangeLog	2014-01-07 21:07:03 UTC (rev 161451)
@@ -1,3 +1,13 @@
+2014-01-07  David Farler  <dfar...@apple.com>
+
+        [ASAN] Building with trunk clang corrupts sandbox profile with comment from Compiler.h
+        https://bugs.webkit.org/show_bug.cgi?id=124532
+
+        Reviewed by David Kilzer.
+
+        * wtf/Compiler.h:
+        Remove this quirk - it does nothing.
+
 2014-01-06  Filip Pizlo  <fpi...@apple.com>
 
         Get rid of ENABLE(VALUE_PROFILER). It's on all the time now.

Modified: trunk/Source/WTF/wtf/Compiler.h (161450 => 161451)


--- trunk/Source/WTF/wtf/Compiler.h	2014-01-07 21:05:30 UTC (rev 161450)
+++ trunk/Source/WTF/wtf/Compiler.h	2014-01-07 21:07:03 UTC (rev 161451)
@@ -56,14 +56,8 @@
 #define WTF_COMPILER_SUPPORTS_CXX_AUTO_TYPE __has_feature(cxx_auto_type)
 #define WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS __has_feature(cxx_generalized_initializers)
 
-/* Disable final on versions of Apple clang earlier than 4.2 to avoid bugs like http://webkit.org/b/119165 */
-#if defined(__APPLE__) && (__clang_major__ < 4 || (__clang_major__ == 4 && __clang_minor__ < 2))
-#define WTF_COMPILER_QUIRK_FINAL_IS_BUGGY 1
-// #error "Please use a newer version of Xcode, this version has code generation bugs when using 'final' in C++ code"
 #endif
 
-#endif
-
 /* COMPILER(MSVC) - Microsoft Visual C++ */
 #if defined(_MSC_VER)
 #if _MSC_VER < 1800
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to