Title: [161508] tags/Safari-538.10.1/Source/WTF/ChangeLog
Revision
161508
Author
[email protected]
Date
2014-01-08 08:42:57 -0800 (Wed, 08 Jan 2014)

Log Message

Merged r160453.  <rdar://problem/15544065>

Modified Paths

Diff

Modified: tags/Safari-538.10.1/Source/WTF/ChangeLog (161507 => 161508)


--- tags/Safari-538.10.1/Source/WTF/ChangeLog	2014-01-08 16:38:33 UTC (rev 161507)
+++ tags/Safari-538.10.1/Source/WTF/ChangeLog	2014-01-08 16:42:57 UTC (rev 161508)
@@ -1,3 +1,27 @@
+2014-01-08  Lucas Forschler  <[email protected]>
+
+        Merge r160453
+
+    2013-12-11  Oliver Hunt  <[email protected]>
+
+            Give Unique StringImpls a meaningful data pointer
+            https://bugs.webkit.org/show_bug.cgi?id=125598
+
+            Reviewed by Michael Saboff.
+
+            Found by code inspection.  If there is a collision in an Identifier
+            table when comparing to a string literal we attempt to use the data
+            pointer (essentially this ends up being a null termination check).
+
+            Previously unique pointers just used the literal 1 as the data address
+            but this obviously fails when dereferenced.  Instead we now make the
+            data pointer point to the location of the buffer pointer itself.  As
+            the buffer pointer is initialised to 0, this satisfies the requirement
+            that the 0-length unique string is null terminated.
+
+            * wtf/text/StringImpl.h:
+            (WTF::StringImpl::StringImpl):
+
 2013-12-19  Alex Christensen  <[email protected]>
 
         Final preparations for GStreamer on Windows.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to