Title: [161665] trunk/Source/WebCore
- Revision
- 161665
- Author
- [email protected]
- Date
- 2014-01-10 13:08:51 -0800 (Fri, 10 Jan 2014)
Log Message
Possible crash in ApplicationCache::removeResource.
https://bugs.webkit.org/show_bug.cgi?id=126695
Patch by Piotr Grad <[email protected]> on 2014-01-10
Reviewed by Alexey Proskuryakov.
No new tests.
Iterator variable was used after it was removed.
* loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::removeResource):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (161664 => 161665)
--- trunk/Source/WebCore/ChangeLog 2014-01-10 20:51:55 UTC (rev 161664)
+++ trunk/Source/WebCore/ChangeLog 2014-01-10 21:08:51 UTC (rev 161665)
@@ -1,3 +1,17 @@
+2014-01-10 Piotr Grad <[email protected]>
+
+ Possible crash in ApplicationCache::removeResource.
+ https://bugs.webkit.org/show_bug.cgi?id=126695
+
+ Reviewed by Alexey Proskuryakov.
+
+ No new tests.
+
+ Iterator variable was used after it was removed.
+
+ * loader/appcache/ApplicationCache.cpp:
+ (WebCore::ApplicationCache::removeResource):
+
2014-01-10 Daniel Bates <[email protected]>
Another build fix for the Production Mac build following <http://trac.webkit.org/changeset/161638>
Modified: trunk/Source/WebCore/loader/appcache/ApplicationCache.cpp (161664 => 161665)
--- trunk/Source/WebCore/loader/appcache/ApplicationCache.cpp 2014-01-10 20:51:55 UTC (rev 161664)
+++ trunk/Source/WebCore/loader/appcache/ApplicationCache.cpp 2014-01-10 21:08:51 UTC (rev 161665)
@@ -108,10 +108,10 @@
// The resource exists, get its type so we can return it.
unsigned type = it->value->type();
+ m_estimatedSizeInStorage -= it->value->estimatedSizeInStorage();
+
m_resources.remove(it);
- m_estimatedSizeInStorage -= it->value->estimatedSizeInStorage();
-
return type;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
