Title: [161670] trunk/Source/WebCore
- Revision
- 161670
- Author
- [email protected]
- Date
- 2014-01-10 13:31:42 -0800 (Fri, 10 Jan 2014)
Log Message
Prevent some resources from showing up in Web Inspector as years in duration.
No WebKit port passed a monotonic time to InspectorInstrumentation::didFinishLoading -- except Chromium.
https://bugs.webkit.org/show_bug.cgi?id=126760
Reviewed by Joseph Pecoraro.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
Revert part of r102961 to use finishTime as-is and not expect a monotonic time.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (161669 => 161670)
--- trunk/Source/WebCore/ChangeLog 2014-01-10 21:29:59 UTC (rev 161669)
+++ trunk/Source/WebCore/ChangeLog 2014-01-10 21:31:42 UTC (rev 161670)
@@ -1,3 +1,17 @@
+2014-01-10 Timothy Hatcher <[email protected]>
+
+ Prevent some resources from showing up in Web Inspector as years in duration.
+
+ No WebKit port passed a monotonic time to InspectorInstrumentation::didFinishLoading -- except Chromium.
+
+ https://bugs.webkit.org/show_bug.cgi?id=126760
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/InspectorInstrumentation.cpp:
+ (WebCore::InspectorInstrumentation::didFinishLoadingImpl):
+ Revert part of r102961 to use finishTime as-is and not expect a monotonic time.
+
2014-01-10 Dirk Schulze <[email protected]>
Make clipping path from basic-shapes relative to <box> value
Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (161669 => 161670)
--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2014-01-10 21:29:59 UTC (rev 161669)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2014-01-10 21:31:42 UTC (rev 161670)
@@ -687,21 +687,11 @@
resourceAgent->didReceiveData(identifier, data, dataLength, encodedDataLength);
}
-void InspectorInstrumentation::didFinishLoadingImpl(InstrumentingAgents* instrumentingAgents, unsigned long identifier, DocumentLoader* loader, double monotonicFinishTime)
+void InspectorInstrumentation::didFinishLoadingImpl(InstrumentingAgents* instrumentingAgents, unsigned long identifier, DocumentLoader* loader, double finishTime)
{
- InspectorTimelineAgent* timelineAgent = instrumentingAgents->inspectorTimelineAgent();
- InspectorResourceAgent* resourceAgent = instrumentingAgents->inspectorResourceAgent();
- if (!timelineAgent && !resourceAgent)
- return;
-
- double finishTime = 0.0;
- // FIXME: Expose all of the timing details to inspector and have it calculate finishTime.
- if (monotonicFinishTime)
- finishTime = loader->timing()->monotonicTimeToPseudoWallTime(monotonicFinishTime);
-
- if (timelineAgent)
+ if (InspectorTimelineAgent* timelineAgent = instrumentingAgents->inspectorTimelineAgent())
timelineAgent->didFinishLoadingResource(identifier, false, finishTime, loader->frame());
- if (resourceAgent)
+ if (InspectorResourceAgent* resourceAgent = instrumentingAgents->inspectorResourceAgent())
resourceAgent->didFinishLoading(identifier, loader, finishTime);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
