[webkit-changes] [161673] trunk/Source

Fri, 10 Jan 2014 13:39:10 -0800

Title: [161673] trunk/Source
Revision
161673
Author
[email protected]
Date
2014-01-10 13:42:07 -0800 (Fri, 10 Jan 2014)

Log Message

[CSS Blending] Log blending as a layer creation reason in the WI
https://bugs.webkit.org/show_bug.cgi?id=126159

Patch by Joseph Pecoraro <[email protected]> on 2014-01-10
Reviewed by Timothy Hatcher.

Source/WebCore:

* inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
* inspector/protocol/LayerTree.json:

Source/WebInspectorUI:

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._populateListOfCompositingReasons):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (161672 => 161673)


--- trunk/Source/WebCore/ChangeLog	2014-01-10 21:37:34 UTC (rev 161672)
+++ trunk/Source/WebCore/ChangeLog	2014-01-10 21:42:07 UTC (rev 161673)
@@ -1,3 +1,14 @@
+2014-01-10  Joseph Pecoraro  <[email protected]>
+
+        [CSS Blending] Log blending as a layer creation reason in the WI
+        https://bugs.webkit.org/show_bug.cgi?id=126159
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/InspectorLayerTreeAgent.cpp:
+        (WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
+        * inspector/protocol/LayerTree.json:
+
 2014-01-10  Andy Estes  <[email protected]>
 
         Fix some iOS build errors during bindings generation.

Modified: trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp (161672 => 161673)


--- trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp	2014-01-10 21:37:34 UTC (rev 161672)
+++ trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp	2014-01-10 21:42:07 UTC (rev 161673)
@@ -307,6 +307,9 @@
 
     if (reasonsBitmask & CompositingReasonRoot)
         compositingReasons->setRoot(true);
+
+    if (reasonsBitmask & CompositingReasonBlending)
+        compositingReasons->setBlending(true);
 }
 
 String InspectorLayerTreeAgent::bind(const RenderLayer* layer)

Modified: trunk/Source/WebCore/inspector/protocol/LayerTree.json (161672 => 161673)


--- trunk/Source/WebCore/inspector/protocol/LayerTree.json	2014-01-10 21:37:34 UTC (rev 161672)
+++ trunk/Source/WebCore/inspector/protocol/LayerTree.json	2014-01-10 21:42:07 UTC (rev 161673)
@@ -69,7 +69,8 @@
                 { "name": "blendingWithCompositedDescendants", "type": "boolean", "optional": true, "description": "Composition due to association with an element with CSS blending applied and composited descendants." },
                 { "name": "perspective", "type": "boolean", "optional": true, "description": "Composition due to association with an element with perspective applied." },
                 { "name": "preserve3D", "type": "boolean", "optional": true, "description": "Composition due to association with an element with a \"transform-style: preserve-3d\" style." },
-                { "name": "root", "type": "boolean", "optional": true, "description": "Composition due to association with the root element." }
+                { "name": "root", "type": "boolean", "optional": true, "description": "Composition due to association with the root element." },
+                { "name": "blending", "type": "boolean", "optional": true, "description": "Composition due to association with an element with a \"blend-mode\" style." }
             ]
         }
     ],

Modified: trunk/Source/WebInspectorUI/ChangeLog (161672 => 161673)


--- trunk/Source/WebInspectorUI/ChangeLog	2014-01-10 21:37:34 UTC (rev 161672)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-01-10 21:42:07 UTC (rev 161673)
@@ -1,3 +1,14 @@
+2014-01-10  Joseph Pecoraro  <[email protected]>
+
+        [CSS Blending] Log blending as a layer creation reason in the WI
+        https://bugs.webkit.org/show_bug.cgi?id=126159
+
+        Reviewed by Timothy Hatcher.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/LayerTreeSidebarPanel.js:
+        (WebInspector.LayerTreeSidebarPanel.prototype._populateListOfCompositingReasons):
+
 2014-01-10  Peter Molnar  <[email protected]>
 
         Add missing function stub in InspectorFrontendHostStub.js

Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (161672 => 161673)


--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2014-01-10 21:37:34 UTC (rev 161672)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2014-01-10 21:42:07 UTC (rev 161673)
@@ -149,6 +149,7 @@
 localizedStrings["Element has perspective applied"] = "Element has perspective applied";
 localizedStrings["Element has  -webkit-overflow-scrolling: touch  style"] = "Element has  -webkit-overflow-scrolling: touch  style";
 localizedStrings["Element has  backface-visibility: hidden  style"] = "Element has  backface-visibility: hidden  style";
+localizedStrings["Element has  blend-mode  style"] = "Element has  blend-mode  style";
 localizedStrings["Element has  position: fixed  style"] = "Element has  position: fixed  style";
 localizedStrings["Element has  position: sticky  style"] = "Element has  position: sticky  style";
 localizedStrings["Element has  transform-style: preserve-3d  style"] = "Element has  transform-style: preserve-3d  style";

Modified: trunk/Source/WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js (161672 => 161673)


--- trunk/Source/WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js	2014-01-10 21:37:34 UTC (rev 161672)
+++ trunk/Source/WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js	2014-01-10 21:42:07 UTC (rev 161673)
@@ -428,6 +428,8 @@
             addReason(WebInspector.UIString("Element has “transform-style: preserve-3d” style"));
         if (compositingReasons.root)
             addReason(WebInspector.UIString("Element is the root element"));
+        if (compositingReasons.blending)
+            addReason(WebInspector.UIString("Element has “blend-mode” style"));
     }
 };
 

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to