Title: [161722] trunk
- Revision
- 161722
- Author
- [email protected]
- Date
- 2014-01-10 20:06:17 -0800 (Fri, 10 Jan 2014)
Log Message
Unreviewed, rolling out r161702.
http://trac.webkit.org/changeset/161702
https://bugs.webkit.org/show_bug.cgi?id=126803
Broke multiple tests (Requested by ap on #webkit).
Source/_javascript_Core:
* runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):
LayoutTests:
* js/script-tests/typedarray-constructors.js: Removed.
* js/typedarray-constructors-expected.txt: Removed.
* js/typedarray-constructors.html: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (161721 => 161722)
--- trunk/LayoutTests/ChangeLog 2014-01-11 04:05:19 UTC (rev 161721)
+++ trunk/LayoutTests/ChangeLog 2014-01-11 04:06:17 UTC (rev 161722)
@@ -1,3 +1,15 @@
+2014-01-10 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r161702.
+ http://trac.webkit.org/changeset/161702
+ https://bugs.webkit.org/show_bug.cgi?id=126803
+
+ Broke multiple tests (Requested by ap on #webkit).
+
+ * js/script-tests/typedarray-constructors.js: Removed.
+ * js/typedarray-constructors-expected.txt: Removed.
+ * js/typedarray-constructors.html: Removed.
+
2014-01-10 Dean Jackson <[email protected]>
[JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
Deleted: trunk/LayoutTests/js/script-tests/typedarray-constructors.js (161721 => 161722)
--- trunk/LayoutTests/js/script-tests/typedarray-constructors.js 2014-01-11 04:05:19 UTC (rev 161721)
+++ trunk/LayoutTests/js/script-tests/typedarray-constructors.js 2014-01-11 04:06:17 UTC (rev 161722)
@@ -1,35 +0,0 @@
-description(
-'This test case tests the various typed array and related constructors. ' +
-'In particular, makes sure that you use the "new" keyword when using the constructors.'
-);
-
-shouldThrow("Int8Array()");
-shouldNotThrow("new Int8Array()");
-
-shouldThrow("Int16Array()");
-shouldNotThrow("new Int16Array()");
-
-shouldThrow("Int32Array()");
-shouldNotThrow("new Int32Array()");
-
-shouldThrow("Uint8Array()");
-shouldNotThrow("new Uint8Array()");
-
-shouldThrow("Uint16Array()");
-shouldNotThrow("new Uint16Array()");
-
-shouldThrow("Uint32Array()");
-shouldNotThrow("new Uint32Array()");
-
-shouldThrow("Uint8ClampedArray()");
-shouldNotThrow("new Uint8ClampedArray()");
-
-shouldThrow("Float32Array()");
-shouldNotThrow("new Float32Array()");
-
-shouldThrow("Float64Array()");
-shouldNotThrow("new Float64Array()");
-
-shouldThrow("DataView(new ArrayBuffer())");
-shouldNotThrow("new DataView(new ArrayBuffer())");
-
Deleted: trunk/LayoutTests/js/typedarray-constructors-expected.txt (161721 => 161722)
--- trunk/LayoutTests/js/typedarray-constructors-expected.txt 2014-01-11 04:05:19 UTC (rev 161721)
+++ trunk/LayoutTests/js/typedarray-constructors-expected.txt 2014-01-11 04:06:17 UTC (rev 161722)
@@ -1,29 +0,0 @@
-This test case tests the various typed array and related constructors. In particular, makes sure that you use the "new" keyword when using the constructors.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS Int8Array() threw exception TypeError: Function is not a function (evaluating 'Int8Array()').
-PASS new Int8Array() did not throw exception.
-PASS Int16Array() threw exception TypeError: Function is not a function (evaluating 'Int16Array()').
-PASS new Int16Array() did not throw exception.
-PASS Int32Array() threw exception TypeError: Function is not a function (evaluating 'Int32Array()').
-PASS new Int32Array() did not throw exception.
-PASS Uint8Array() threw exception TypeError: Function is not a function (evaluating 'Uint8Array()').
-PASS new Uint8Array() did not throw exception.
-PASS Uint16Array() threw exception TypeError: Function is not a function (evaluating 'Uint16Array()').
-PASS new Uint16Array() did not throw exception.
-PASS Uint32Array() threw exception TypeError: Function is not a function (evaluating 'Uint32Array()').
-PASS new Uint32Array() did not throw exception.
-PASS Uint8ClampedArray() threw exception TypeError: Function is not a function (evaluating 'Uint8ClampedArray()').
-PASS new Uint8ClampedArray() did not throw exception.
-PASS Float32Array() threw exception TypeError: Function is not a function (evaluating 'Float32Array()').
-PASS new Float32Array() did not throw exception.
-PASS Float64Array() threw exception TypeError: Function is not a function (evaluating 'Float64Array()').
-PASS new Float64Array() did not throw exception.
-PASS DataView(new ArrayBuffer()) threw exception TypeError: Function is not a function (evaluating 'DataView(new ArrayBuffer())').
-PASS new DataView(new ArrayBuffer()) did not throw exception.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/js/typedarray-constructors.html (161721 => 161722)
--- trunk/LayoutTests/js/typedarray-constructors.html 2014-01-11 04:05:19 UTC (rev 161721)
+++ trunk/LayoutTests/js/typedarray-constructors.html 2014-01-11 04:06:17 UTC (rev 161722)
@@ -1,10 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src=""
-</head>
-<body>
-<script src=""
-<script src=""
-</body>
-</html>
Modified: trunk/Source/_javascript_Core/ChangeLog (161721 => 161722)
--- trunk/Source/_javascript_Core/ChangeLog 2014-01-11 04:05:19 UTC (rev 161721)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-01-11 04:06:17 UTC (rev 161722)
@@ -1,3 +1,14 @@
+2014-01-10 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r161702.
+ http://trac.webkit.org/changeset/161702
+ https://bugs.webkit.org/show_bug.cgi?id=126803
+
+ Broke multiple tests (Requested by ap on #webkit).
+
+ * runtime/JSGenericTypedArrayViewConstructorInlines.h:
+ (JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):
+
2014-01-10 David Kilzer <[email protected]>
Clean up architectures in xcconfig files
Modified: trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewConstructorInlines.h (161721 => 161722)
--- trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewConstructorInlines.h 2014-01-11 04:05:19 UTC (rev 161721)
+++ trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewConstructorInlines.h 2014-01-11 04:06:17 UTC (rev 161722)
@@ -157,7 +157,7 @@
CallType JSGenericTypedArrayViewConstructor<ViewClass>::getCallData(JSCell*, CallData& callData)
{
callData.native.function = constructGenericTypedArrayView<ViewClass>;
- return CallTypeNone;
+ return CallTypeHost;
}
} // namespace JSC
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
