Title: [161866] trunk/Source/_javascript_Core
- Revision
- 161866
- Author
- [email protected]
- Date
- 2014-01-13 01:23:12 -0800 (Mon, 13 Jan 2014)
Log Message
Unreviewed. Changes in r161686 are exposing a bug in GCC where the global .cfi_startproc directive
is not inserted early enough into the generated assembler code when building in debug mode, causing
compilation failures on ports using the GCC compilers. To work around the problem, only utilize the
OFFLINE_ASM_* macros that use .cfi_ directives when compiling with Clang.
* llint/LowLevelInterpreter.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (161865 => 161866)
--- trunk/Source/_javascript_Core/ChangeLog 2014-01-13 09:02:55 UTC (rev 161865)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-01-13 09:23:12 UTC (rev 161866)
@@ -1,3 +1,12 @@
+2014-01-13 Zan Dobersek <[email protected]>
+
+ Unreviewed. Changes in r161686 are exposing a bug in GCC where the global .cfi_startproc directive
+ is not inserted early enough into the generated assembler code when building in debug mode, causing
+ compilation failures on ports using the GCC compilers. To work around the problem, only utilize the
+ OFFLINE_ASM_* macros that use .cfi_ directives when compiling with Clang.
+
+ * llint/LowLevelInterpreter.cpp:
+
2014-01-12 Commit Queue <[email protected]>
Unreviewed, rolling out r161840.
Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp (161865 => 161866)
--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2014-01-13 09:02:55 UTC (rev 161865)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2014-01-13 09:23:12 UTC (rev 161866)
@@ -522,7 +522,7 @@
//
// These are for building an interpreter from generated assembly code:
-#if CPU(X86_64)
+#if CPU(X86_64) && COMPILER(CLANG)
#define OFFLINE_ASM_BEGIN asm ( \
".cfi_startproc\n"
@@ -545,7 +545,7 @@
".thumb\n" \
".thumb_func " THUMB_FUNC_PARAM(label) "\n" \
SYMBOL_STRING(label) ":\n"
-#elif CPU(X86_64)
+#elif CPU(X86_64) && COMPILER(CLANG)
#define OFFLINE_ASM_GLOBAL_LABEL(label) \
".text\n" \
".globl " SYMBOL_STRING(label) "\n" \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
