Title: [161878] trunk/Source/WebCore
- Revision
- 161878
- Author
- [email protected]
- Date
- 2014-01-13 08:15:46 -0800 (Mon, 13 Jan 2014)
Log Message
REGRESSION(r161715): Use of uninitialized value $ENV{"PLATFORM_NAME"}
https://bugs.webkit.org/show_bug.cgi?id=126873
Patch by Tibor Meszaros <[email protected]> on 2014-01-13
Reviewed by Csaba Osztrogonác.
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (161877 => 161878)
--- trunk/Source/WebCore/ChangeLog 2014-01-13 14:33:53 UTC (rev 161877)
+++ trunk/Source/WebCore/ChangeLog 2014-01-13 16:15:46 UTC (rev 161878)
@@ -1,3 +1,14 @@
+2014-01-13 Tibor Meszaros <[email protected]>
+
+ REGRESSION(r161715): Use of uninitialized value $ENV{"PLATFORM_NAME"}
+ https://bugs.webkit.org/show_bug.cgi?id=126873
+
+ Reviewed by Csaba Osztrogonác.
+
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ * bindings/scripts/preprocessor.pm:
+ (applyPreprocessor):
+
2014-01-13 Andreas Kling <[email protected]>
CTTE: Autoscroll renderer is always a RenderBox.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm (161877 => 161878)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2014-01-13 14:33:53 UTC (rev 161877)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2014-01-13 16:15:46 UTC (rev 161878)
@@ -111,7 +111,7 @@
"SVGStringList" => 1, "SVGTransform" => 1, "SVGTransformList" => 1, "SVGUnitTypes" => 1);
# Constants
-my $buildingForIPhone = ($ENV{PLATFORM_NAME} eq "iphoneos" or $ENV{PLATFORM_NAME} eq "iphonesimulator");
+my $buildingForIPhone = defined $ENV{PLATFORM_NAME} && ($ENV{PLATFORM_NAME} eq "iphoneos" or $ENV{PLATFORM_NAME} eq "iphonesimulator");
my $nullableInit = "bool isNull = false;";
my $exceptionInit = "WebCore::ExceptionCode ec = 0;";
my $jsContextSetter = "WebCore::JSMainThreadNullState state;";
Modified: trunk/Source/WebCore/bindings/scripts/preprocessor.pm (161877 => 161878)
--- trunk/Source/WebCore/bindings/scripts/preprocessor.pm 2014-01-13 14:33:53 UTC (rev 161877)
+++ trunk/Source/WebCore/bindings/scripts/preprocessor.pm 2014-01-13 16:15:46 UTC (rev 161878)
@@ -60,7 +60,7 @@
if ($Config::Config{"osname"} eq "darwin") {
push(@args, "-I" . $ENV{BUILT_PRODUCTS_DIR} . "/usr/local/include") if $ENV{BUILT_PRODUCTS_DIR};
push(@args, "-isysroot", $ENV{SDKROOT}) if $ENV{SDKROOT};
- $defines .= " WTF_PLATFORM_IOS" if $ENV{PLATFORM_NAME} =~ /iphone(os|simulator)/;
+ $defines .= " WTF_PLATFORM_IOS" if defined $ENV{PLATFORM_NAME} && $ENV{PLATFORM_NAME} =~ /iphone(os|simulator)/;
}
# Remove double quotations from $defines and extract macros.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
