Diff
Modified: trunk/Source/WebCore/ChangeLog (162006 => 162007)
--- trunk/Source/WebCore/ChangeLog 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebCore/ChangeLog 2014-01-14 22:13:33 UTC (rev 162007)
@@ -1,3 +1,18 @@
+2014-01-14 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r162000.
+ http://trac.webkit.org/changeset/162000
+ https://bugs.webkit.org/show_bug.cgi?id=127009
+
+ API versioning is wrong (Requested by rfong on #webkit).
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::getContext):
+ * loader/FrameLoaderClient.h:
+ * loader/FrameLoaderTypes.h:
+ * page/ChromeClient.h:
+
2014-01-14 Bear Travis <[email protected]>
[CSS Shapes] Move CSSPrimitiveValue <-> LayoutBox Conversion to CSSPrimitiveValueMappings
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (162006 => 162007)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-01-14 22:13:33 UTC (rev 162007)
@@ -3241,7 +3241,7 @@
93F199BB08245E59001E9ABC /* WebCoreKeyboardUIMode.h in Headers */ = {isa = PBXBuildFile; fileRef = BE983D95052A2E0A00892D85 /* WebCoreKeyboardUIMode.h */; settings = {ATTRIBUTES = (Private, ); }; };
93F199BE08245E59001E9ABC /* BlockExceptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 65A640F00533BB1F0085E777 /* BlockExceptions.h */; settings = {ATTRIBUTES = (Private, ); }; };
93F199DE08245E59001E9ABC /* Position.h in Headers */ = {isa = PBXBuildFile; fileRef = BE91FC8B06133666005E3790 /* Position.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 93F199E508245E59001E9ABC /* HTMLCanvasElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 51F6A3D60663BF04004D2919 /* HTMLCanvasElement.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ 93F199E508245E59001E9ABC /* HTMLCanvasElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 51F6A3D60663BF04004D2919 /* HTMLCanvasElement.h */; };
93F199EC08245E59001E9ABC /* XSLStyleSheet.h in Headers */ = {isa = PBXBuildFile; fileRef = BC06F24A06D18A7E004A6FA3 /* XSLStyleSheet.h */; };
93F199ED08245E59001E9ABC /* XSLTProcessor.h in Headers */ = {isa = PBXBuildFile; fileRef = BC06F24C06D18A7E004A6FA3 /* XSLTProcessor.h */; };
93F199F008245E59001E9ABC /* WebCoreView.h in Headers */ = {isa = PBXBuildFile; fileRef = BE855F7F0701E83500239769 /* WebCoreView.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -23190,7 +23190,6 @@
E4B65A58132FA8E70070E7BE /* TileGrid.h in Headers */,
93F1992F08245E59001E9ABC /* Cursor.h in Headers */,
BC2272A20E82E87C00E7F975 /* CursorData.h in Headers */,
- 93F199E508245E59001E9ABC /* HTMLCanvasElement.h in Headers */,
868160D618766A130021E79D /* UserActivity.h in Headers */,
BC2272AD0E82E8F300E7F975 /* CursorList.h in Headers */,
62CD325A1157E57C0063B0A7 /* CustomEvent.h in Headers */,
@@ -23954,6 +23953,7 @@
A871DE2C0A152AC800B12A68 /* HTMLBodyElement.h in Headers */,
A8CFF7AA0A156978000A4234 /* HTMLBRElement.h in Headers */,
A81369D2097374F600D74463 /* HTMLButtonElement.h in Headers */,
+ 93F199E508245E59001E9ABC /* HTMLCanvasElement.h in Headers */,
07969DC017D14151007FF842 /* JSRTCStatsCallback.h in Headers */,
A8DF3FD0097FA0FC0052981B /* HTMLCollection.h in Headers */,
977B3865122883E900B81FF8 /* HTMLConstructionSite.h in Headers */,
Modified: trunk/Source/WebCore/html/HTMLCanvasElement.cpp (162006 => 162007)
--- trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2014-01-14 22:13:33 UTC (rev 162007)
@@ -33,16 +33,13 @@
#include "CanvasPattern.h"
#include "CanvasRenderingContext2D.h"
#include "Chrome.h"
-#include "ChromeClient.h"
#include "Document.h"
#include "ExceptionCode.h"
#include "Frame.h"
-#include "FrameLoaderClient.h"
#include "GraphicsContext.h"
#include "HTMLNames.h"
#include "ImageData.h"
#include "MIMETypeRegistry.h"
-#include "MainFrame.h"
#include "Page.h"
#include "RenderHTMLCanvas.h"
#include "ScriptController.h"
@@ -204,7 +201,7 @@
// once it is created. https://bugs.webkit.org/show_bug.cgi?id=117095
if (is2dType(type)) {
if (m_context && !m_context->is2d())
- return nullptr;
+ return 0;
if (!m_context) {
bool usesDashbardCompatibilityMode = false;
#if ENABLE(DASHBOARD_SUPPORT)
@@ -226,17 +223,6 @@
if (m_context && !m_context->is3d())
return 0;
if (!m_context) {
- Page* page = document().page();
- if (page && !document().url().isLocalFile()) {
- WebGLLoadPolicy policy = page->mainFrame().loader().client().webGLPolicyForHost(document().url().host());
-
- if (policy == WebGLAsk) {
- page->chrome().client().webGLContextCreated(this);
- return nullptr;
- }
- if (policy == WebGLBlock)
- return nullptr;
- }
m_context = WebGLRenderingContext::create(this, static_cast<WebGLContextAttributes*>(attrs));
if (m_context) {
// Need to make sure a RenderLayer and compositing layer get created for the Canvas
@@ -249,7 +235,7 @@
#else
UNUSED_PARAM(attrs);
#endif
- return nullptr;
+ return 0;
}
bool HTMLCanvasElement::probablySupportsContext(const String& type, CanvasContextAttributes*)
Modified: trunk/Source/WebCore/loader/FrameLoaderClient.h (162006 => 162007)
--- trunk/Source/WebCore/loader/FrameLoaderClient.h 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebCore/loader/FrameLoaderClient.h 2014-01-14 22:13:33 UTC (rev 162007)
@@ -331,7 +331,6 @@
// Informs the embedder that a WebGL canvas inside this frame received a lost context
// notification with the given GL_ARB_robustness guilt/innocence code (see Extensions3D.h).
virtual void didLoseWebGLContext(int) { }
- virtual WebGLLoadPolicy webGLPolicyForHost(const String&) const { return WebGLAsk; }
#endif
virtual void forcePageTransitionIfNeeded() { }
Modified: trunk/Source/WebCore/loader/FrameLoaderTypes.h (162006 => 162007)
--- trunk/Source/WebCore/loader/FrameLoaderTypes.h 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebCore/loader/FrameLoaderTypes.h 2014-01-14 22:13:33 UTC (rev 162007)
@@ -105,12 +105,6 @@
AboutToInstantiatePlugin,
NotAboutToInstantiatePlugin
};
-
- enum WebGLLoadPolicy {
- WebGLAsk = 0,
- WebGLAllow,
- WebGLBlock
- };
}
Modified: trunk/Source/WebCore/page/ChromeClient.h (162006 => 162007)
--- trunk/Source/WebCore/page/ChromeClient.h 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebCore/page/ChromeClient.h 2014-01-14 22:13:33 UTC (rev 162007)
@@ -428,10 +428,6 @@
// would likely want the page to remain running uninterrupted.
virtual void incrementActivePageCount() { }
virtual void decrementActivePageCount() { }
-
-#if ENABLE(WEBGL)
- virtual void webGLContextCreated(Element*) const { }
-#endif
protected:
virtual ~ChromeClient() { }
Modified: trunk/Source/WebKit2/ChangeLog (162006 => 162007)
--- trunk/Source/WebKit2/ChangeLog 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-14 22:13:33 UTC (rev 162007)
@@ -1,3 +1,30 @@
+2014-01-14 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r162000.
+ http://trac.webkit.org/changeset/162000
+ https://bugs.webkit.org/show_bug.cgi?id=127009
+
+ API versioning is wrong (Requested by rfong on #webkit).
+
+ * UIProcess/API/C/WKAPICast.h:
+ * UIProcess/API/C/WKPageLoaderClient.h:
+ * UIProcess/API/C/WKPageUIClient.h:
+ * UIProcess/WebLoaderClient.cpp:
+ * UIProcess/WebLoaderClient.h:
+ * UIProcess/WebPageProxy.cpp:
+ * UIProcess/WebPageProxy.h:
+ * UIProcess/WebPageProxy.messages.in:
+ * UIProcess/WebUIClient.cpp:
+ * UIProcess/WebUIClient.h:
+ * UIProcess/mac/WebInspectorProxyMac.mm:
+ (WebKit::WebInspectorProxy::platformCreateInspectorPage):
+ * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+ * WebProcess/WebCoreSupport/WebChromeClient.h:
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
+ * WebProcess/WebPage/WebPage.cpp:
+ * WebProcess/WebPage/WebPage.h:
+
2014-01-14 Csaba Osztrogonác <[email protected]>
Speculative buildfix after r161999.
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKAPICast.h (162006 => 162007)
--- trunk/Source/WebKit2/UIProcess/API/C/WKAPICast.h 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKAPICast.h 2014-01-14 22:13:33 UTC (rev 162007)
@@ -473,21 +473,6 @@
return PluginModuleBlocked;
}
-inline WebCore::WebGLLoadPolicy toWebGLLoadPolicy(WKWebGLLoadPolicy webGLLoadPolicy)
-{
- switch (webGLLoadPolicy) {
- case kWKWebGLLoadPolicyInactive:
- return WebCore::WebGLAsk;
- case kWKWebGLLoadPolicyLoadNormally:
- return WebCore::WebGLAllow;
- case kWKWebGLLoadPolicyBlocked:
- return WebCore::WebGLBlock;
- }
-
- ASSERT_NOT_REACHED();
- return WebCore::WebGLAsk;
-}
-
inline ProxyingRefPtr<WebGrammarDetail> toAPI(const WebCore::GrammarDetail& grammarDetail)
{
return ProxyingRefPtr<WebGrammarDetail>(WebGrammarDetail::create(grammarDetail));
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPageLoaderClient.h (162006 => 162007)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPageLoaderClient.h 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPageLoaderClient.h 2014-01-14 22:13:33 UTC (rev 162007)
@@ -42,13 +42,6 @@
};
typedef uint32_t WKPluginLoadPolicy;
-enum {
- kWKWebGLLoadPolicyInactive = 0,
- kWKWebGLLoadPolicyLoadNormally,
- kWKWebGLLoadPolicyBlocked
-};
-typedef uint32_t WKWebGLLoadPolicy;
-
typedef void (*WKPageLoaderClientCallback)(WKPageRef page, const void* clientInfo);
typedef void (*WKPageDidStartProvisionalLoadForFrameCallback)(WKPageRef page, WKFrameRef frame, WKTypeRef userData, const void *clientInfo);
typedef void (*WKPageDidReceiveServerRedirectForProvisionalLoadForFrameCallback)(WKPageRef page, WKFrameRef frame, WKTypeRef userData, const void *clientInfo);
@@ -73,7 +66,6 @@
typedef void (*WKPageDidLayoutCallback)(WKPageRef page, WKLayoutMilestones milestones, WKTypeRef userData, const void *clientInfo);
typedef WKPluginLoadPolicy (*WKPagePluginLoadPolicyCallback)(WKPageRef page, WKPluginLoadPolicy currentPluginLoadPolicy, WKDictionaryRef pluginInfoDictionary, WKStringRef* unavailabilityDescription, const void* clientInfo);
typedef void (*WKPagePluginDidFailCallback)(WKPageRef page, WKErrorCode errorCode, WKDictionaryRef pluginInfoDictionary, const void* clientInfo);
-typedef WKWebGLLoadPolicy (*WKPageWebGLLoadPolicyCallback)(WKPageRef page, WKStringRef host, const void* clientInfo);
// Deprecated
typedef void (*WKPageDidFailToInitializePluginCallback_deprecatedForUseWithV0)(WKPageRef page, WKStringRef mimeType, const void* clientInfo);
@@ -272,7 +264,6 @@
// Version 3.
WKPagePluginLoadPolicyCallback pluginLoadPolicy;
- WKPageWebGLLoadPolicyCallback webGLLoadPolicy;
} WKPageLoaderClientV3;
// FIXME: These should be deprecated.
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPageUIClient.h (162006 => 162007)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPageUIClient.h 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPageUIClient.h 2014-01-14 22:13:33 UTC (rev 162007)
@@ -85,7 +85,6 @@
typedef void (*WKPageShowColorPickerCallback)(WKPageRef page, WKStringRef initialColor, WKColorPickerResultListenerRef listener, const void* clientInfo);
typedef void (*WKPageHideColorPickerCallback)(WKPageRef page, const void* clientInfo);
typedef void (*WKPageUnavailablePluginButtonClickedCallback)(WKPageRef page, WKPluginUnavailabilityReason pluginUnavailabilityReason, WKDictionaryRef pluginInfoDictionary, const void* clientInfo);
-typedef void (*WKPageWebGLContextCreatedCallback)(WKPageRef page, WKStringRef, const void* clientInfo);
// Deprecated
typedef WKPageRef (*WKPageCreateNewPageCallback_deprecatedForUseWithV0)(WKPageRef page, WKDictionaryRef features, WKEventModifiers modifiers, WKEventMouseButton mouseButton, const void *clientInfo);
@@ -248,7 +247,6 @@
WKPageShowColorPickerCallback showColorPicker;
WKPageHideColorPickerCallback hideColorPicker;
WKPageUnavailablePluginButtonClickedCallback unavailablePluginButtonClicked;
- WKPageWebGLContextCreatedCallback webGLContextCreated;
} WKPageUIClientV2;
enum { kWKPageUIClientCurrentVersion WK_ENUM_DEPRECATED("Use an explicit version number instead") = 2 };
Modified: trunk/Source/WebKit2/UIProcess/WebLoaderClient.cpp (162006 => 162007)
--- trunk/Source/WebKit2/UIProcess/WebLoaderClient.cpp 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/UIProcess/WebLoaderClient.cpp 2014-01-14 22:13:33 UTC (rev 162007)
@@ -333,12 +333,4 @@
#endif // ENABLE(NETSCAPE_PLUGIN_API)
-#if ENABLE(WEBGL)
-void WebLoaderClient::webGLLoadPolicy(WebPageProxy* page, WebCore::WebGLLoadPolicy& loadPolicy, const String& host)
-{
- if (m_client.webGLLoadPolicy)
- loadPolicy = toWebGLLoadPolicy(m_client.webGLLoadPolicy(toAPI(page), toAPI(host.impl()), m_client.base.clientInfo));
-}
-#endif // ENABLE(WEBGL)
-
} // namespace WebKit
Modified: trunk/Source/WebKit2/UIProcess/WebLoaderClient.h (162006 => 162007)
--- trunk/Source/WebKit2/UIProcess/WebLoaderClient.h 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/UIProcess/WebLoaderClient.h 2014-01-14 22:13:33 UTC (rev 162007)
@@ -30,7 +30,6 @@
#include "PluginModuleInfo.h"
#include "SameDocumentNavigationType.h"
#include "WKPage.h"
-#include <WebCore/FrameLoaderTypes.h>
#include <WebCore/LayoutMilestones.h>
#include <wtf/Forward.h>
#include <wtf/RefPtr.h>
@@ -103,10 +102,6 @@
void didFailToInitializePlugin(WebPageProxy*, ImmutableDictionary*);
void didBlockInsecurePluginVersion(WebPageProxy*, ImmutableDictionary*);
#endif // ENABLE(NETSCAPE_PLUGIN_API)
-
-#if ENABLE(WEBGL)
- void webGLLoadPolicy(WebPageProxy*, WebCore::WebGLLoadPolicy&, const String&);
-#endif // ENABLE(WEBGL)
};
} // namespace WebKit
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (162006 => 162007)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-01-14 22:13:33 UTC (rev 162007)
@@ -2680,20 +2680,6 @@
}
#endif // ENABLE(NETSCAPE_PLUGIN_API)
-#if ENABLE(WEBGL)
-void WebPageProxy::webGLContextCreated(const String& pageURLString)
-{
- m_uiClient.webGLContextCreated(this, pageURLString);
-}
-
-void WebPageProxy::webGLPolicyForHost(const String& host, uint32_t& loadPolicy)
-{
- WebCore::WebGLLoadPolicy policy;
- m_loaderClient.webGLLoadPolicy(this, policy, host);
- loadPolicy = static_cast<uint32_t>(policy);
-}
-#endif // ENABLE(WEBGL)
-
void WebPageProxy::setToolbarsAreVisible(bool toolbarsAreVisible)
{
m_uiClient.setToolbarsAreVisible(this, toolbarsAreVisible);
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (162006 => 162007)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2014-01-14 22:13:33 UTC (rev 162007)
@@ -929,10 +929,6 @@
#if ENABLE(NETSCAPE_PLUGIN_API)
void unavailablePluginButtonClicked(uint32_t opaquePluginUnavailabilityReason, const String& mimeType, const String& pluginURLString, const String& pluginsPageURLString, const String& frameURLString, const String& pageURLString);
#endif // ENABLE(NETSCAPE_PLUGIN_API)
-#if ENABLE(WEBGL)
- void webGLContextCreated(const String& pageURLString);
- void webGLPolicyForHost(const String& host, uint32_t& loadPolicy);
-#endif // ENABLE(WEBGL)
void setToolbarsAreVisible(bool toolbarsAreVisible);
void getToolbarsAreVisible(bool& toolbarsAreVisible);
void setMenuBarIsVisible(bool menuBarIsVisible);
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in (162006 => 162007)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in 2014-01-14 22:13:33 UTC (rev 162007)
@@ -33,10 +33,6 @@
#if ENABLE(NETSCAPE_PLUGIN_API)
UnavailablePluginButtonClicked(uint32_t pluginUnavailabilityReason, String mimeType, String pluginURLString, String pluginspageAttributeURLString, String frameURLString, String pageURLString)
#endif // ENABLE(NETSCAPE_PLUGIN_API)
-#if ENABLE(WEBGL)
- WebGLContextCreated(String pageURLString)
- WebGLPolicyForHost(String host) -> (uint32_t loadPolicy)
-#endif // ENABLE(WEBGL)
DidChangeViewportProperties(WebCore::ViewportAttributes attributes)
DidReceiveEvent(uint32_t type, bool handled)
StopResponsivenessTimer()
Modified: trunk/Source/WebKit2/UIProcess/WebUIClient.cpp (162006 => 162007)
--- trunk/Source/WebKit2/UIProcess/WebUIClient.cpp 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/UIProcess/WebUIClient.cpp 2014-01-14 22:13:33 UTC (rev 162007)
@@ -207,14 +207,6 @@
}
#endif // ENABLE(NETSCAPE_PLUGIN_API)
-#if ENABLE(WEBGL)
-void WebUIClient::webGLContextCreated(WebPageProxy* page, const String& originatingURL)
-{
- if (m_client.webGLContextCreated)
- m_client.webGLContextCreated(toAPI(page), toAPI(originatingURL.impl()), m_client.base.clientInfo);
-}
-#endif // ENABLE(WEBGL)
-
bool WebUIClient::implementsDidNotHandleKeyEvent() const
{
return m_client.didNotHandleKeyEvent;
Modified: trunk/Source/WebKit2/UIProcess/WebUIClient.h (162006 => 162007)
--- trunk/Source/WebKit2/UIProcess/WebUIClient.h 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/UIProcess/WebUIClient.h 2014-01-14 22:13:33 UTC (rev 162007)
@@ -81,9 +81,7 @@
#if ENABLE(NETSCAPE_PLUGIN_API)
void unavailablePluginButtonClicked(WebPageProxy*, WKPluginUnavailabilityReason, ImmutableDictionary*);
#endif // ENABLE(NETSCAPE_PLUGIN_API)
-#if ENABLE(WEBGL)
- void webGLContextCreated(WebPageProxy*, const String&);
-#endif // ENABLE(WEBGL)
+
bool implementsDidNotHandleKeyEvent() const;
void didNotHandleKeyEvent(WebPageProxy*, const NativeWebKeyboardEvent&);
Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (162006 => 162007)
--- trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2014-01-14 22:13:33 UTC (rev 162007)
@@ -447,7 +447,6 @@
0, // showColorPicker
0, // hideColorPicker
0, // unavailablePluginButtonClicked
- 0, // webGLContextCreated
};
inspectorPage->initializeUIClient(reinterpret_cast<const WKPageUIClientBase*>(&uiClient));
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (162006 => 162007)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2014-01-14 22:13:33 UTC (rev 162007)
@@ -58,7 +58,6 @@
#include <WebCore/FrameLoadRequest.h>
#include <WebCore/FrameLoader.h>
#include <WebCore/FrameView.h>
-#include <WebCore/HTMLCanvasElement.h>
#include <WebCore/HTMLInputElement.h>
#include <WebCore/HTMLNames.h>
#include <WebCore/HTMLParserIdioms.h>
@@ -563,14 +562,6 @@
#endif // ENABLE(NETSCAPE_PLUGIN_API)
}
-#if ENABLE(WEBGL)
-void WebChromeClient::webGLContextCreated(Element* element) const
-{
- String pageURLString = m_page->mainFrame()->loader().documentLoader()->responseURL().string();
- m_page->send(Messages::WebPageProxy::WebGLContextCreated(pageURLString));
-}
-#endif // ENABLE(WEBGL)
-
void WebChromeClient::scrollbarsModeDidChange() const
{
notImplemented();
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h (162006 => 162007)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2014-01-14 22:13:33 UTC (rev 162007)
@@ -123,9 +123,6 @@
virtual bool shouldUnavailablePluginMessageBeButton(WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const OVERRIDE;
virtual void unavailablePluginButtonClicked(WebCore::Element*, WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const OVERRIDE;
-#if ENABLE(WEBGL)
- virtual void webGLContextCreated(WebCore::Element*) const OVERRIDE;
-#endif // ENABLE(WEBGL)
virtual void scrollbarsModeDidChange() const OVERRIDE;
virtual void mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned modifierFlags) OVERRIDE;
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (162006 => 162007)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2014-01-14 22:13:33 UTC (rev 162007)
@@ -1378,15 +1378,6 @@
m_pluginView = static_cast<PluginView*>(pluginWidget);
}
-#if ENABLE(WEBGL)
-WebCore::WebGLLoadPolicy WebFrameLoaderClient::webGLPolicyForHost(const String& host) const
-{
- if (WebPage* webPage = m_frame->page())
- return webPage->getWebGLPolicyForHost(m_frame, host);
- return WebGLAsk;
-}
-#endif // ENABLE(WEBGL)
-
PassRefPtr<Widget> WebFrameLoaderClient::createJavaAppletWidget(const IntSize& pluginSize, HTMLAppletElement* appletElement, const URL&, const Vector<String>& paramNames, const Vector<String>& paramValues)
{
#if ENABLE(NETSCAPE_PLUGIN_API)
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h (162006 => 162007)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h 2014-01-14 22:13:33 UTC (rev 162007)
@@ -194,10 +194,6 @@
virtual void recreatePlugin(WebCore::Widget*) OVERRIDE;
virtual void redirectDataToPlugin(WebCore::Widget* pluginWidget) OVERRIDE;
-#if ENABLE(WEBGL)
- virtual WebCore::WebGLLoadPolicy webGLPolicyForHost(const String&) const OVERRIDE;
-#endif // ENABLE(WEBGL)
-
virtual PassRefPtr<WebCore::Widget> createJavaAppletWidget(const WebCore::IntSize&, WebCore::HTMLAppletElement*, const WebCore::URL& baseURL, const Vector<String>& paramNames, const Vector<String>& paramValues) OVERRIDE;
#if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (162006 => 162007)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-01-14 22:13:33 UTC (rev 162007)
@@ -590,19 +590,6 @@
#endif // ENABLE(NETSCAPE_PLUGIN_API)
-#if ENABLE(WEBGL)
-WebCore::WebGLLoadPolicy WebPage::getWebGLPolicyForHost(WebFrame* frame, const String& url)
-{
- WebGLLoadPolicy defaultPolicy = WebGLAsk;
- uint32_t policyResult = 0;
- // FIXME: Get rid of sendSync in favor of a non-blocking strategy.
- sendSync(Messages::WebPageProxy::WebGLPolicyForHost(url), Messages::WebPageProxy::WebGLPolicyForHost::Reply(policyResult));
- if (policyResult)
- return static_cast<WebGLLoadPolicy>(policyResult);
- return defaultPolicy;
-}
-#endif // ENABLE(WEBGL)
-
EditorState WebPage::editorState() const
{
Frame& frame = m_page->focusController().focusedOrMainFrame();
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h (162006 => 162007)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2014-01-14 22:13:33 UTC (rev 162007)
@@ -287,10 +287,6 @@
PassRefPtr<Plugin> createPlugin(WebFrame*, WebCore::HTMLPlugInElement*, const Plugin::Parameters&, String& newMIMEType);
#endif
-#if ENABLE(WEBGL)
- WebCore::WebGLLoadPolicy getWebGLPolicyForHost(WebFrame*, const String&);
-#endif // ENABLE(WEBGL)
-
EditorState editorState() const;
String renderTreeExternalRepresentation() const;
Modified: trunk/Tools/ChangeLog (162006 => 162007)
--- trunk/Tools/ChangeLog 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Tools/ChangeLog 2014-01-14 22:13:33 UTC (rev 162007)
@@ -1,3 +1,17 @@
+2014-01-14 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r162000.
+ http://trac.webkit.org/changeset/162000
+ https://bugs.webkit.org/show_bug.cgi?id=127009
+
+ API versioning is wrong (Requested by rfong on #webkit).
+
+ * MiniBrowser/mac/WK2BrowserWindowController.m:
+ (-[WK2BrowserWindowController awakeFromNib]):
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::createOtherPage):
+ (WTR::TestController::createWebViewWithOptions):
+
2014-01-13 Roger Fong <[email protected]>
Add support for handling WebGL load policies.
Modified: trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m (162006 => 162007)
--- trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2014-01-14 22:13:33 UTC (rev 162007)
@@ -581,7 +581,6 @@
0, // showColorPicker
0, // hideColorPicker
0, // unavailablePluginButtonClicked
- 0, // webGLContextCreated
};
WKPageSetPageUIClient(_webView.pageRef, &uiClient.base);
}
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (162006 => 162007)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2014-01-14 22:11:43 UTC (rev 162006)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2014-01-14 22:13:33 UTC (rev 162007)
@@ -242,7 +242,6 @@
0, // showColorPicker
0, // hideColorPicker
0, // unavailablePluginButtonClicked
- 0, // webGLContextCreated
};
WKPageSetPageUIClient(newPage, &otherPageUIClient.base);
@@ -420,7 +419,6 @@
0, // showColorPicker
0, // hideColorPicker
unavailablePluginButtonClicked,
- 0, // webGLContextCreated
};
WKPageSetPageUIClient(m_mainWebView->page(), &pageUIClient.base);
@@ -462,7 +460,6 @@
0, // pluginLoadPolicy_deprecatedForUseWithV2
0, // pluginDidFail
pluginLoadPolicy, // pluginLoadPolicy
- 0, // webGLLoadPolicy
};
WKPageSetPageLoaderClient(m_mainWebView->page(), &pageLoaderClient.base);
