Title: [162149] trunk/Source/WebInspectorUI
- Revision
- 162149
- Author
- bb...@apple.com
- Date
- 2014-01-16 13:52:44 -0800 (Thu, 16 Jan 2014)
Log Message
Web Inspector: add more context to Object.addEventListener assertions
https://bugs.webkit.org/show_bug.cgi?id=127125
Reviewed by Joseph Pecoraro.
Log invalid event type and listener parameters, and log the other
parameters so the callsite is easier to figure out.
* UserInterface/Object.js:
(WebInspector.Object.addEventListener):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (162148 => 162149)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-01-16 21:45:34 UTC (rev 162148)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-01-16 21:52:44 UTC (rev 162149)
@@ -1,5 +1,18 @@
2014-01-16 Brian Burg <bb...@apple.com>
+ Web Inspector: add more context to Object.addEventListener assertions
+ https://bugs.webkit.org/show_bug.cgi?id=127125
+
+ Reviewed by Joseph Pecoraro.
+
+ Log invalid event type and listener parameters, and log the other
+ parameters so the callsite is easier to figure out.
+
+ * UserInterface/Object.js:
+ (WebInspector.Object.addEventListener):
+
+2014-01-16 Brian Burg <bb...@apple.com>
+
Web Inspector: CallFrame is missing saveIdentityToCookie, or should be excluded
https://bugs.webkit.org/show_bug.cgi?id=126791
Modified: trunk/Source/WebInspectorUI/UserInterface/Object.js (162148 => 162149)
--- trunk/Source/WebInspectorUI/UserInterface/Object.js 2014-01-16 21:45:34 UTC (rev 162148)
+++ trunk/Source/WebInspectorUI/UserInterface/Object.js 2014-01-16 21:52:44 UTC (rev 162149)
@@ -55,11 +55,11 @@
{
thisObject = thisObject || null;
- console.assert(eventType);
+ console.assert(eventType, "Object.addEventListener: invalid event type ", eventType, "(listener: ", listener, "thisObject: ", thisObject, ")");
if (!eventType)
return;
- console.assert(listener);
+ console.assert(listener, "Object.addEventListener: invalid listener ", listener, "(event type: ", eventType, "thisObject: ", thisObject, ")");
if (!listener)
return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
