Title: [162474] trunk/LayoutTests
- Revision
- 162474
- Author
- [email protected]
- Date
- 2014-01-21 14:14:37 -0800 (Tue, 21 Jan 2014)
Log Message
platform/mac/accessibility/iframe-aria-hidden.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=127323
Reviewed by Chris Fleizach.
This test got de-flaked on bots by rolling out r162354. But there was still
a potential race in it, which this change fixes.
* platform/mac-wk2/TestExpectations: Removed expectation.
* platform/mac/accessibility/iframe-aria-hidden.html: Run the test in onload, as
frames load asynchronously.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (162473 => 162474)
--- trunk/LayoutTests/ChangeLog 2014-01-21 21:45:19 UTC (rev 162473)
+++ trunk/LayoutTests/ChangeLog 2014-01-21 22:14:37 UTC (rev 162474)
@@ -1,3 +1,18 @@
+2014-01-21 Alexey Proskuryakov <[email protected]>
+
+ platform/mac/accessibility/iframe-aria-hidden.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=127323
+
+ Reviewed by Chris Fleizach.
+
+ This test got de-flaked on bots by rolling out r162354. But there was still
+ a potential race in it, which this change fixes.
+
+ * platform/mac-wk2/TestExpectations: Removed expectation.
+
+ * platform/mac/accessibility/iframe-aria-hidden.html: Run the test in onload, as
+ frames load asynchronously.
+
2014-01-21 Chris Fleizach <[email protected]>
AX: Mac: Expose the visible text of a password field to AX
Modified: trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html (162473 => 162474)
--- trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html 2014-01-21 21:45:19 UTC (rev 162473)
+++ trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html 2014-01-21 22:14:37 UTC (rev 162474)
@@ -14,24 +14,29 @@
<div id="console"></div>
<script>
+description("This tests that aria-hidden will affect the visibility of the web area and scroll view.");
- description("This tests that aria-hidden will affect the visibility of the web area and scroll view.");
+if (window.accessibilityController) {
+ jsTestIsAsync = true;
- if (window.accessibilityController) {
+ // Get the iframe reference.
+ document.getElementById("body").focus();
+ var body = accessibilityController.focusedElement;
- document.getElementById("body").focus();
-
- // Get the iframe reference.
- var body = accessibilityController.focusedElement;
+ window._onload_ = function() {
shouldBe("body.childrenCount", "3");
shouldBe("body.childAtIndex(0).childrenCount", "0");
document.getElementById("iframe").setAttribute("aria-hidden", "false");
shouldBe("body.childrenCount", "4");
shouldBe("body.childAtIndex(0).childAtIndex(0).childAtIndex(0).role", "'AXRole: AXWebArea'");
+
+ finishJSTest();
}
+} else
+ testFailed("This test relies on accessibilityController, please use run-webkit-tests to run it.")
- successfullyParsed = true;
+successfullyParsed = true;
</script>
<script src=""
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (162473 => 162474)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-01-21 21:45:19 UTC (rev 162473)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-01-21 22:14:37 UTC (rev 162474)
@@ -451,8 +451,6 @@
webkit.org/b/127316 svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html [ Pass Timeout ]
-webkit.org/b/127323 platform/mac/accessibility/iframe-aria-hidden.html [ Pass Failure ]
-
### END OF (3) Unclassified failures
########################################
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
