Title: [162957] trunk/Source/WebCore
- Revision
- 162957
- Author
- mmaxfi...@apple.com
- Date
- 2014-01-28 14:03:57 -0800 (Tue, 28 Jan 2014)
Log Message
Fixing several incorrect assumptions with handling isolated inlines.
https://bugs.webkit.org/show_bug.cgi?id=127608
Reviewed by Simon Fraser.
Fixing capitalization.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::setUpResolverToResumeInIsolate):
(WebCore::constructBidiRunsForSegment):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (162956 => 162957)
--- trunk/Source/WebCore/ChangeLog 2014-01-28 21:53:22 UTC (rev 162956)
+++ trunk/Source/WebCore/ChangeLog 2014-01-28 22:03:57 UTC (rev 162957)
@@ -3,6 +3,19 @@
Fixing several incorrect assumptions with handling isolated inlines.
https://bugs.webkit.org/show_bug.cgi?id=127608
+ Reviewed by Simon Fraser.
+
+ Fixing capitalization.
+
+ * rendering/RenderBlockLineLayout.cpp:
+ (WebCore::setUpResolverToResumeInIsolate):
+ (WebCore::constructBidiRunsForSegment):
+
+2014-01-28 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ Fixing several incorrect assumptions with handling isolated inlines.
+ https://bugs.webkit.org/show_bug.cgi?id=127608
+
Reviewed by Dave Hyatt.
First, when an isolated inline spans multiple lines, we aren't guaranteed
Modified: trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp (162956 => 162957)
--- trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2014-01-28 21:53:22 UTC (rev 162956)
+++ trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2014-01-28 22:03:57 UTC (rev 162957)
@@ -872,11 +872,11 @@
lastRootBox()->appendFloat(floatingObject->renderer());
}
-static inline void setupResolverToResumeInIsolate(InlineBidiResolver& resolver, RenderObject* root, RenderObject* startObject)
+static inline void setUpResolverToResumeInIsolate(InlineBidiResolver& resolver, RenderObject* root, RenderObject* startObject)
{
if (root != startObject) {
RenderObject* parent = startObject->parent();
- setupResolverToResumeInIsolate(resolver, root, parent);
+ setUpResolverToResumeInIsolate(resolver, root, parent);
notifyObserverEnteredObject(&resolver, startObject);
}
}
@@ -915,7 +915,7 @@
}
isolatedResolver.setStatus(BidiStatus(direction, isOverride(unicodeBidi)));
- setupResolverToResumeInIsolate(isolatedResolver, isolatedInline, &startObj);
+ setUpResolverToResumeInIsolate(isolatedResolver, isolatedInline, &startObj);
// The starting position is the beginning of the first run within the isolate that was identified
// during the earlier call to createBidiRunsForLine. This can be but is not necessarily the
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
