Title: [163177] trunk/Source/WebCore
Revision
163177
Author
[email protected]
Date
2014-01-31 10:49:13 -0800 (Fri, 31 Jan 2014)

Log Message

Don't do logging from Range::collectSelectionRects() on iOS
https://bugs.webkit.org/show_bug.cgi?id=127999

Reviewed by Enrica Casucci.

Remove some logging code that printed Range stuff in debug builds.

* dom/Range.cpp:
(WebCore::Range::collectSelectionRects):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (163176 => 163177)


--- trunk/Source/WebCore/ChangeLog	2014-01-31 18:25:34 UTC (rev 163176)
+++ trunk/Source/WebCore/ChangeLog	2014-01-31 18:49:13 UTC (rev 163177)
@@ -1,3 +1,15 @@
+2014-01-31  Simon Fraser  <[email protected]>
+
+        Don't do logging from Range::collectSelectionRects() on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=127999
+
+        Reviewed by Enrica Casucci.
+
+        Remove some logging code that printed Range stuff in debug builds.
+
+        * dom/Range.cpp:
+        (WebCore::Range::collectSelectionRects):
+
 2014-01-30  Simon Fraser  <[email protected]>
 
         Make iOS fixed layer registration more like OS X

Modified: trunk/Source/WebCore/dom/Range.cpp (163176 => 163177)


--- trunk/Source/WebCore/dom/Range.cpp	2014-01-31 18:25:34 UTC (rev 163176)
+++ trunk/Source/WebCore/dom/Range.cpp	2014-01-31 18:49:13 UTC (rev 163177)
@@ -1698,28 +1698,6 @@
     return minEnd - maxStart >= sufficientOverlap * std::min(lengthA, lengthB);
 }
 
-#ifndef NDEBUG
-static void printRects(Vector<SelectionRect>& rects)
-{
-    size_t numberOfRects = rects.size();
-    for (size_t i = 0; i < numberOfRects; ++i) {
-        fprintf(stderr, "%zu\t[%d, %d] - [%d, %d]\t%c %s\tis first: %s\tis last:%s\tcontains start: %s\tcontains end: %s\tline: %d\truby: %s\tcolumn: %d\n",
-            i,
-            rects[i].rect().x(), rects[i].rect().y(), rects[i].rect().width(), rects[i].rect().height(),
-            rects[i].isHorizontal() ? 'H' : 'V',
-            rects[i].direction() == LTR ? "LTR" : "RTL",
-            rects[i].isFirstOnLine() ? "yes" : "no",
-            rects[i].isLastOnLine() ? "yes" : "no",
-            rects[i].containsStart() ? "yes" : "no",
-            rects[i].containsEnd() ? "yes" : "no",
-            rects[i].lineNumber(),
-            rects[i].isRubyText() ? "yes": "no",
-            rects[i].columnNumber());
-    }
-    fprintf(stderr, "--------------------------------------\n");
-}
-#endif
-
 static inline void adjustLineHeightOfSelectionRects(Vector<SelectionRect>& rects, size_t numberOfRects, int lineNumber, int lineTop, int lineHeight)
 {
     ASSERT(rects.size() >= numberOfRects);
@@ -1791,10 +1769,6 @@
         }
     }
 
-#ifndef NDEBUG
-    printRects(rects);
-#endif
-
     // The range could span over nodes with different writing modes.
     // If this is the case, we use the writing mode of the common ancestor.
     if (containsDifferentWritingModes) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to