Title: [163192] trunk/Source/WebKit2
- Revision
- 163192
- Author
- [email protected]
- Date
- 2014-01-31 13:17:47 -0800 (Fri, 31 Jan 2014)
Log Message
WebKit2 View Gestures (Swipe): Crashes swiping around a Google Docs spreadsheet
https://bugs.webkit.org/show_bug.cgi?id=128013
<rdar://problem/15959481>
Reviewed by Anders Carlsson.
* UIProcess/mac/ViewGestureController.mm:
(WebKit::ViewGestureController::wheelEventWasNotHandledByWebCore):
We should never (currently) start a swipe from a non-begin-phase wheel event.
We already check this in handleScrollWheelEvent, but can still get
non-begin-phase events in wheelEventWasNotHandled.
We only start "pending" swipes with Begin events, so we should never make them
non-pending with anything but a Begin event (we'll get it when it bubbles back up,
unhandled, from WebCore). In addition, AppKit throws an exception when we try
to start a swipe from end-phase events.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163191 => 163192)
--- trunk/Source/WebKit2/ChangeLog 2014-01-31 21:11:35 UTC (rev 163191)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-31 21:17:47 UTC (rev 163192)
@@ -1,3 +1,22 @@
+2014-01-31 Tim Horton <[email protected]>
+
+ WebKit2 View Gestures (Swipe): Crashes swiping around a Google Docs spreadsheet
+ https://bugs.webkit.org/show_bug.cgi?id=128013
+ <rdar://problem/15959481>
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/mac/ViewGestureController.mm:
+ (WebKit::ViewGestureController::wheelEventWasNotHandledByWebCore):
+ We should never (currently) start a swipe from a non-begin-phase wheel event.
+ We already check this in handleScrollWheelEvent, but can still get
+ non-begin-phase events in wheelEventWasNotHandled.
+
+ We only start "pending" swipes with Begin events, so we should never make them
+ non-pending with anything but a Begin event (we'll get it when it bubbles back up,
+ unhandled, from WebCore). In addition, AppKit throws an exception when we try
+ to start a swipe from end-phase events.
+
2014-01-31 Brady Eidson <[email protected]>
IDB: openCursor() needs to prime the cursor with first position values
@@ -36,9 +55,9 @@
2014-01-31 Beth Dakin <[email protected]>
- Sideways 'wobble' when scrolling with trackpad on Mavericks
- https://bugs.webkit.org/show_bug.cgi?id=127521
- -and corresponding-
+ Sideways 'wobble' when scrolling with trackpad on Mavericks
+ https://bugs.webkit.org/show_bug.cgi?id=127521
+ -and corresponding-
<rdar://problem/14137306>
Reviewed by Simon Fraser.
Modified: trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm (163191 => 163192)
--- trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm 2014-01-31 21:11:35 UTC (rev 163191)
+++ trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm 2014-01-31 21:17:47 UTC (rev 163192)
@@ -286,6 +286,10 @@
return;
m_hasPendingSwipe = false;
+
+ if (event.phase != NSEventPhaseBegan)
+ return;
+
trackSwipeGesture(event, m_pendingSwipeDirection);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
