Diff
Modified: trunk/ChangeLog (163237 => 163238)
--- trunk/ChangeLog 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/ChangeLog 2014-02-01 08:05:21 UTC (rev 163238)
@@ -1,3 +1,13 @@
+2014-01-31 Benjamin Poulain <[email protected]>
+
+ Remove LEGACY_VIEWPORT_ADAPTION
+ https://bugs.webkit.org/show_bug.cgi?id=128028
+
+ Reviewed by Anders Carlsson.
+
+ * Source/cmake/WebKitFeatures.cmake:
+ * Source/cmakeconfig.h.cmake:
+
2014-01-31 Oliver Hunt <[email protected]>
Rollout r163195 and related patches
Modified: trunk/Source/WTF/ChangeLog (163237 => 163238)
--- trunk/Source/WTF/ChangeLog 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/WTF/ChangeLog 2014-02-01 08:05:21 UTC (rev 163238)
@@ -1,3 +1,12 @@
+2014-01-31 Benjamin Poulain <[email protected]>
+
+ Remove LEGACY_VIEWPORT_ADAPTION
+ https://bugs.webkit.org/show_bug.cgi?id=128028
+
+ Reviewed by Anders Carlsson.
+
+ * wtf/FeatureDefines.h:
+
2014-01-31 Tim Horton <[email protected]>
[wk2] PlatformCALayerRemoteCustom doesn't work on iOS
Modified: trunk/Source/WTF/wtf/FeatureDefines.h (163237 => 163238)
--- trunk/Source/WTF/wtf/FeatureDefines.h 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/WTF/wtf/FeatureDefines.h 2014-02-01 08:05:21 UTC (rev 163238)
@@ -590,10 +590,6 @@
#define ENABLE_LEGACY_VENDOR_PREFIXES 0
#endif
-#if !defined(ENABLE_LEGACY_VIEWPORT_ADAPTION)
-#define ENABLE_LEGACY_VIEWPORT_ADAPTION 0
-#endif
-
#if !defined(ENABLE_LETTERPRESS)
#define ENABLE_LETTERPRESS 0
#endif
Modified: trunk/Source/WebCore/ChangeLog (163237 => 163238)
--- trunk/Source/WebCore/ChangeLog 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/WebCore/ChangeLog 2014-02-01 08:05:21 UTC (rev 163238)
@@ -1,3 +1,18 @@
+2014-01-31 Benjamin Poulain <[email protected]>
+
+ Remove LEGACY_VIEWPORT_ADAPTION
+ https://bugs.webkit.org/show_bug.cgi?id=128028
+
+ Reviewed by Anders Carlsson.
+
+ The code is incorrect and was only supported by Nix.
+
+ * dom/Document.cpp:
+ (WebCore::Document::childrenChanged):
+ * dom/ViewportArguments.h:
+ * html/HTMLMetaElement.cpp:
+ (WebCore::HTMLMetaElement::process):
+
2014-01-31 Ryosuke Niwa <[email protected]>
Release build fix after r163234. Don't always export the symbol that doesn't exist under NDEBUG.
Modified: trunk/Source/WebCore/dom/Document.cpp (163237 => 163238)
--- trunk/Source/WebCore/dom/Document.cpp 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-02-01 08:05:21 UTC (rev 163238)
@@ -794,21 +794,7 @@
{
ContainerNode::childrenChanged(change);
- // NOTE: Per DOM, dynamically inserting/removing doctype nodes doesn't affect compatibility mode.
-
-#if ENABLE(LEGACY_VIEWPORT_ADAPTION)
- // FIXME: It's a little strange to add these rules when a DocumentType with this prefix is added,
- // but not remove these rules when a DocumentType with this prefix is removed. It seems this should
- // be handled more the way the compatibility mode is, by fetching the doctype at the appropriate time,
- // rather than by responding when a document type node is inserted.
- if (DocumentType* documentType = doctype()) {
- if (documentType->publicId().startsWith("-//wapforum//dtd xhtml mobile 1.", /* caseSensitive */ false))
- processViewport("width=device-width, height=device-height", ViewportArguments::XHTMLMobileProfile);
- }
-#endif
-
Element* newDocumentElement = childrenOfType<Element>(*this).first();
-
if (newDocumentElement == m_documentElement)
return;
m_documentElement = newDocumentElement;
Modified: trunk/Source/WebCore/dom/ViewportArguments.h (163237 => 163238)
--- trunk/Source/WebCore/dom/ViewportArguments.h 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/WebCore/dom/ViewportArguments.h 2014-02-01 08:05:21 UTC (rev 163238)
@@ -58,11 +58,6 @@
enum Type {
// These are ordered in increasing importance.
Implicit,
-#if ENABLE(LEGACY_VIEWPORT_ADAPTION)
- XHTMLMobileProfile,
- HandheldFriendlyMeta,
- MobileOptimizedMeta,
-#endif
#if PLATFORM(IOS)
PluginDocument,
ImageDocument,
Modified: trunk/Source/WebCore/html/HTMLMetaElement.cpp (163237 => 163238)
--- trunk/Source/WebCore/html/HTMLMetaElement.cpp 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/WebCore/html/HTMLMetaElement.cpp 2014-02-01 08:05:21 UTC (rev 163238)
@@ -81,12 +81,6 @@
#endif
else if (equalIgnoringCase(name(), "referrer"))
document().processReferrerPolicy(contentValue);
-#if ENABLE(LEGACY_VIEWPORT_ADAPTION)
- else if (equalIgnoringCase(name(), "handheldfriendly") && equalIgnoringCase(contentValue, "true"))
- document().processViewport("width=device-width", ViewportArguments::HandheldFriendlyMeta);
- else if (equalIgnoringCase(name(), "mobileoptimized"))
- document().processViewport("width=device-width, initial-scale=1", ViewportArguments::MobileOptimizedMeta);
-#endif
// Get the document to process the tag, but only if we're actually part of DOM tree (changing a meta tag while
// it's not in the tree shouldn't have any effect on the document)
Modified: trunk/Source/cmake/WebKitFeatures.cmake (163237 => 163238)
--- trunk/Source/cmake/WebKitFeatures.cmake 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/cmake/WebKitFeatures.cmake 2014-02-01 08:05:21 UTC (rev 163238)
@@ -71,7 +71,6 @@
WEBKIT_OPTION_DEFINE(ENABLE_INSPECTOR "Toggle Web Inspector support" ON)
WEBKIT_OPTION_DEFINE(ENABLE_JIT "Enable JustInTime _javascript_ support" ON)
WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_NOTIFICATIONS "Toggle Legacy Desktop Notifications Support" OFF)
- WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION "Toggle legacy viewport adaption" OFF)
WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VENDOR_PREFIXES "Toggle Legacy Vendor Prefix Support" ON)
WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_WEB_AUDIO "Toggle Legacy Web Audio support" ON)
WEBKIT_OPTION_DEFINE(ENABLE_LINK_PREFETCH "Toggle pre fetching support" OFF)
Modified: trunk/Source/cmakeconfig.h.cmake (163237 => 163238)
--- trunk/Source/cmakeconfig.h.cmake 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/cmakeconfig.h.cmake 2014-02-01 08:05:21 UTC (rev 163238)
@@ -62,7 +62,6 @@
#cmakedefine01 ENABLE_INSPECTOR
#cmakedefine01 ENABLE_JIT
#cmakedefine01 ENABLE_LEGACY_NOTIFICATIONS
-#cmakedefine01 ENABLE_LEGACY_VIEWPORT_ADAPTION
#cmakedefine01 ENABLE_LEGACY_VENDOR_PREFIXES
#cmakedefine01 ENABLE_LEGACY_WEB_AUDIO
#cmakedefine01 ENABLE_LINK_PREFETCH
