Title: [163247] trunk/Source/_javascript_Core
- Revision
- 163247
- Author
- [email protected]
- Date
- 2014-02-01 12:29:23 -0800 (Sat, 01 Feb 2014)
Log Message
Saying "jitType() == JITCode::DFGJIT" is almost never correct.
<http://webkit.org/b/128045>
Reviewed by Filip Pizlo.
JITCode::isOptimizingJIT(jitType()) is the right way to say it.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::addBreakpoint):
(JSC::CodeBlock::setSteppingMode):
* runtime/VM.cpp:
(JSC::SetEnabledProfilerFunctor::operator()):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (163246 => 163247)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-01 19:11:38 UTC (rev 163246)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-01 20:29:23 UTC (rev 163247)
@@ -1,3 +1,18 @@
+2014-02-01 Mark Lam <[email protected]>
+
+ Saying "jitType() == JITCode::DFGJIT" is almost never correct.
+ <http://webkit.org/b/128045>
+
+ Reviewed by Filip Pizlo.
+
+ JITCode::isOptimizingJIT(jitType()) is the right way to say it.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::addBreakpoint):
+ (JSC::CodeBlock::setSteppingMode):
+ * runtime/VM.cpp:
+ (JSC::SetEnabledProfilerFunctor::operator()):
+
2014-02-01 Michael Saboff <[email protected]>
REGRESSION (r163027?): CrashTracer: [USER] com.apple.WebKit.WebContent.Development at com.apple._javascript_Core: JSC::ArrayProfile::computeUpdatedPrediction + 4
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (163246 => 163247)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2014-02-01 19:11:38 UTC (rev 163246)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2014-02-01 20:29:23 UTC (rev 163247)
@@ -3558,14 +3558,14 @@
{
m_numBreakpoints += numBreakpoints;
ASSERT(m_numBreakpoints);
- if (jitType() == JITCode::DFGJIT)
+ if (JITCode::isOptimizingJIT(jitType()))
jettison();
}
void CodeBlock::setSteppingMode(CodeBlock::SteppingMode mode)
{
m_steppingMode = mode;
- if (mode == SteppingModeEnabled && jitType() == JITCode::DFGJIT)
+ if (mode == SteppingModeEnabled && JITCode::isOptimizingJIT(jitType()))
jettison();
}
Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (163246 => 163247)
--- trunk/Source/_javascript_Core/runtime/VM.cpp 2014-02-01 19:11:38 UTC (rev 163246)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp 2014-02-01 20:29:23 UTC (rev 163247)
@@ -835,7 +835,7 @@
public:
bool operator()(CodeBlock* codeBlock)
{
- if (codeBlock->jitType() == JITCode::DFGJIT)
+ if (JITCode::isOptimizingJIT(codeBlock->jitType()))
codeBlock->jettison();
return false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
