Title: [163250] trunk/Source/WebKit2
- Revision
- 163250
- Author
- [email protected]
- Date
- 2014-02-01 16:10:03 -0800 (Sat, 01 Feb 2014)
Log Message
Text interaction assistant is not deleted when dismissing the keyboard on iPad.
https://bugs.webkit.org/show_bug.cgi?id=128034
<rdar://problem/15915695>
Reviewed by Dan Bernstein.
In iPhone mode, tapping on 'Done' in the accessory view
calls the delegate accessoryDone where we correctly blur
the assisted node and tear down the text interaction assistant.
The code path for the keyboard in iPad mode is different,
all we get is resignFirstResponder.
The fix is just to move the blurring in resignFirstResponder
and it works for both iPhone and iPad.
* UIProcess/API/ios/WKInteractionView.mm:
(-[WKInteractionView resignFirstResponder]):
(-[WKInteractionView accessoryDone]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163249 => 163250)
--- trunk/Source/WebKit2/ChangeLog 2014-02-01 21:00:30 UTC (rev 163249)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-02 00:10:03 UTC (rev 163250)
@@ -1,3 +1,23 @@
+2014-01-31 Enrica Casucci <[email protected]>
+
+ Text interaction assistant is not deleted when dismissing the keyboard on iPad.
+ https://bugs.webkit.org/show_bug.cgi?id=128034
+ <rdar://problem/15915695>
+
+ Reviewed by Dan Bernstein.
+
+ In iPhone mode, tapping on 'Done' in the accessory view
+ calls the delegate accessoryDone where we correctly blur
+ the assisted node and tear down the text interaction assistant.
+ The code path for the keyboard in iPad mode is different,
+ all we get is resignFirstResponder.
+ The fix is just to move the blurring in resignFirstResponder
+ and it works for both iPhone and iPad.
+
+ * UIProcess/API/ios/WKInteractionView.mm:
+ (-[WKInteractionView resignFirstResponder]):
+ (-[WKInteractionView accessoryDone]):
+
2014-02-01 Brady Eidson <[email protected]>
IDB: Implement IDBObjectStore.delete()
Modified: trunk/Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm (163249 => 163250)
--- trunk/Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm 2014-02-01 21:00:30 UTC (rev 163249)
+++ trunk/Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm 2014-02-02 00:10:03 UTC (rev 163250)
@@ -255,6 +255,7 @@
- (BOOL)resignFirstResponder
{
+ _page->blurAssistedNode();
[self _cancelInteraction];
return [super resignFirstResponder];
}
@@ -1174,7 +1175,6 @@
- (void)accessoryDone
{
[self resignFirstResponder];
- _page->blurAssistedNode();
}
- (void)accessoryTab:(BOOL)isNext
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
