[webkit-changes] [163271] trunk/Source/WebCore

Sun, 02 Feb 2014 13:51:43 -0800

Title: [163271] trunk/Source/WebCore
Revision
163271
Author
[email protected]
Date
2014-02-02 13:56:15 -0800 (Sun, 02 Feb 2014)

Log Message

Add some missing override keywords
https://bugs.webkit.org/show_bug.cgi?id=128082

Reviewed by Antti Koivisto.

* loader/DocumentThreadableLoader.h:
* loader/LinkLoader.h:
* loader/TextTrackLoader.h:
* xml/parser/XMLDocumentParser.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (163270 => 163271)


--- trunk/Source/WebCore/ChangeLog	2014-02-02 21:07:40 UTC (rev 163270)
+++ trunk/Source/WebCore/ChangeLog	2014-02-02 21:56:15 UTC (rev 163271)
@@ -1,3 +1,15 @@
+2014-02-02  Sam Weinig  <[email protected]>
+
+        Add some missing override keywords
+        https://bugs.webkit.org/show_bug.cgi?id=128082
+
+        Reviewed by Antti Koivisto.
+
+        * loader/DocumentThreadableLoader.h:
+        * loader/LinkLoader.h:
+        * loader/TextTrackLoader.h:
+        * xml/parser/XMLDocumentParser.h:
+
 2014-02-02  Brady Eidson  <[email protected]>
 
         IDB: Support IDBFactory.deleteDatabase()

Modified: trunk/Source/WebCore/loader/DocumentThreadableLoader.h (163270 => 163271)


--- trunk/Source/WebCore/loader/DocumentThreadableLoader.h	2014-02-02 21:07:40 UTC (rev 163270)
+++ trunk/Source/WebCore/loader/DocumentThreadableLoader.h	2014-02-02 21:56:15 UTC (rev 163271)
@@ -78,11 +78,11 @@
         void clearResource();
 
         // CachedRawResourceClient
-        virtual void dataSent(CachedResource*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent);
-        virtual void responseReceived(CachedResource*, const ResourceResponse&);
-        virtual void dataReceived(CachedResource*, const char* data, int dataLength);
-        virtual void redirectReceived(CachedResource*, ResourceRequest&, const ResourceResponse&);
-        virtual void notifyFinished(CachedResource*);
+        virtual void dataSent(CachedResource*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;
+        virtual void responseReceived(CachedResource*, const ResourceResponse&) override;
+        virtual void dataReceived(CachedResource*, const char* data, int dataLength) override;
+        virtual void redirectReceived(CachedResource*, ResourceRequest&, const ResourceResponse&) override;
+        virtual void notifyFinished(CachedResource*) override;
 
         void didReceiveResponse(unsigned long identifier, const ResourceResponse&);
         void didReceiveData(unsigned long identifier, const char* data, int dataLength);

Modified: trunk/Source/WebCore/loader/LinkLoader.h (163270 => 163271)


--- trunk/Source/WebCore/loader/LinkLoader.h	2014-02-02 21:07:40 UTC (rev 163270)
+++ trunk/Source/WebCore/loader/LinkLoader.h	2014-02-02 21:56:15 UTC (rev 163271)
@@ -53,7 +53,7 @@
     virtual ~LinkLoader();
 
     // from CachedResourceClient
-    virtual void notifyFinished(CachedResource*);
+    virtual void notifyFinished(CachedResource*) override;
 
     void released();
     bool loadLink(const LinkRelAttribute&, const String& type, const String& sizes, const URL&, Document*);

Modified: trunk/Source/WebCore/loader/TextTrackLoader.h (163270 => 163271)


--- trunk/Source/WebCore/loader/TextTrackLoader.h	2014-02-02 21:07:40 UTC (rev 163270)
+++ trunk/Source/WebCore/loader/TextTrackLoader.h	2014-02-02 21:56:15 UTC (rev 163271)
@@ -71,15 +71,15 @@
 private:
 
     // CachedResourceClient
-    virtual void notifyFinished(CachedResource*);
-    virtual void deprecatedDidReceiveCachedResource(CachedResource*);
+    virtual void notifyFinished(CachedResource*) override;
+    virtual void deprecatedDidReceiveCachedResource(CachedResource*) override;
     
     // WebVTTParserClient
-    virtual void newCuesParsed();
+    virtual void newCuesParsed() override;
 #if ENABLE(WEBVTT_REGIONS)
-    virtual void newRegionsParsed();
+    virtual void newRegionsParsed() override;
 #endif
-    virtual void fileFailedToParse();
+    virtual void fileFailedToParse() override;
     
     TextTrackLoader(TextTrackLoaderClient&, ScriptExecutionContext*);

Modified: trunk/Source/WebCore/xml/parser/XMLDocumentParser.h (163270 => 163271)


--- trunk/Source/WebCore/xml/parser/XMLDocumentParser.h	2014-02-02 21:07:40 UTC (rev 163270)
+++ trunk/Source/WebCore/xml/parser/XMLDocumentParser.h	2014-02-02 21:56:15 UTC (rev 163271)
@@ -99,15 +99,15 @@
         XMLDocumentParser(DocumentFragment&, Element*, ParserContentPolicy);
 
         // From DocumentParser
-        virtual void insert(const SegmentedString&);
-        virtual void append(PassRefPtr<StringImpl>);
-        virtual void finish();
-        virtual bool isWaitingForScripts() const;
-        virtual void stopParsing();
-        virtual void detach();
+        virtual void insert(const SegmentedString&) override;
+        virtual void append(PassRefPtr<StringImpl>) override;
+        virtual void finish() override;
+        virtual bool isWaitingForScripts() const override;
+        virtual void stopParsing() override;
+        virtual void detach() override;
 
         // from CachedResourceClient
-        virtual void notifyFinished(CachedResource*);
+        virtual void notifyFinished(CachedResource*) override;
 
         void end();
 
@@ -116,7 +116,7 @@
 
         bool appendFragmentSource(const String&);
 
-public:
+    public:
         // callbacks from parser SAX
         void error(XMLErrors::ErrorType, const char* message, va_list args) WTF_ATTRIBUTE_PRINTF(3, 0);
         void startElementNs(const xmlChar* xmlLocalName, const xmlChar* xmlPrefix, const xmlChar* xmlURI, int nb_namespaces,

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to