Title: [163409] trunk/Source/WebKit2
- Revision
- 163409
- Author
- [email protected]
- Date
- 2014-02-04 15:33:55 -0800 (Tue, 04 Feb 2014)
Log Message
webKitCookieStorageCopyRequestHeaderFieldsForURL builds an empty Cookie header when there are no cookies
https://bugs.webkit.org/show_bug.cgi?id=128201
Reviewed by Sam Weinig.
* Shared/mac/CookieStorageShim.mm: (WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):
Return null when NetworkProcess provided a null string, don't build a header dictionary
with an empty Cookie value.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163408 => 163409)
--- trunk/Source/WebKit2/ChangeLog 2014-02-04 23:33:40 UTC (rev 163408)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-04 23:33:55 UTC (rev 163409)
@@ -1,3 +1,14 @@
+2014-02-04 Alexey Proskuryakov <[email protected]>
+
+ webKitCookieStorageCopyRequestHeaderFieldsForURL builds an empty Cookie header when there are no cookies
+ https://bugs.webkit.org/show_bug.cgi?id=128201
+
+ Reviewed by Sam Weinig.
+
+ * Shared/mac/CookieStorageShim.mm: (WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):
+ Return null when NetworkProcess provided a null string, don't build a header dictionary
+ with an empty Cookie value.
+
2014-02-04 Anders Carlsson <[email protected]>
Add a WKNavigationAction object
Modified: trunk/Source/WebKit2/Shared/mac/CookieStorageShim.mm (163408 => 163409)
--- trunk/Source/WebKit2/Shared/mac/CookieStorageShim.mm 2014-02-04 23:33:40 UTC (rev 163408)
+++ trunk/Source/WebKit2/Shared/mac/CookieStorageShim.mm 2014-02-04 23:33:55 UTC (rev 163409)
@@ -61,6 +61,9 @@
if (!WebProcess::shared().networkConnection()->connection()->sendSync(Messages::NetworkConnectionToWebProcess::CookieRequestHeaderFieldValue(SessionTracker::defaultSessionID, firstPartyForCookiesURL, inRequestURL), Messages::NetworkConnectionToWebProcess::CookiesForDOM::Reply(cookies), 0))
return 0;
+ if (cookies.isNull())
+ return 0;
+
RetainPtr<CFStringRef> cfCookies = cookies.createCFString();
static const void* cookieKeys[] = { CFSTR("Cookie") };
const void* cookieValues[] = { cfCookies.get() };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
