Title: [163510] trunk/Source/WebCore
Revision
163510
Author
[email protected]
Date
2014-02-05 21:10:24 -0800 (Wed, 05 Feb 2014)

Log Message

Add HTMLNames::classAttr has a regular name in SVGElement::isAnimatableAttribute
https://bugs.webkit.org/show_bug.cgi?id=128166

Reviewed by Sam Weinig.

For historical reasons, classAttr was treated separately. There is no reasons for that anymore.

* svg/SVGElement.cpp:
(WebCore::SVGElement::isAnimatableAttribute):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (163509 => 163510)


--- trunk/Source/WebCore/ChangeLog	2014-02-06 04:31:46 UTC (rev 163509)
+++ trunk/Source/WebCore/ChangeLog	2014-02-06 05:10:24 UTC (rev 163510)
@@ -1,3 +1,15 @@
+2014-02-05  Benjamin Poulain  <[email protected]>
+
+        Add HTMLNames::classAttr has a regular name in SVGElement::isAnimatableAttribute
+        https://bugs.webkit.org/show_bug.cgi?id=128166
+
+        Reviewed by Sam Weinig.
+
+        For historical reasons, classAttr was treated separately. There is no reasons for that anymore.
+
+        * svg/SVGElement.cpp:
+        (WebCore::SVGElement::isAnimatableAttribute):
+
 2014-02-05  Simon Fraser  <[email protected]>
 
         Support encoding and decoding of Regions

Modified: trunk/Source/WebCore/svg/SVGElement.cpp (163509 => 163510)


--- trunk/Source/WebCore/svg/SVGElement.cpp	2014-02-06 04:31:46 UTC (rev 163509)
+++ trunk/Source/WebCore/svg/SVGElement.cpp	2014-02-06 05:10:24 UTC (rev 163510)
@@ -809,10 +809,11 @@
 #ifndef NDEBUG
 bool SVGElement::isAnimatableAttribute(const QualifiedName& name) const
 {
-    DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, animatableAttributes, ());
+    static NeverDestroyed<HashSet<QualifiedName>> neverDestroyedAnimatableAttributes;
+    HashSet<QualifiedName>& animatableAttributes = neverDestroyedAnimatableAttributes;
 
     if (animatableAttributes.isEmpty()) {
-        animatableAttributes.add(XLinkNames::hrefAttr);
+        animatableAttributes.add(HTMLNames::classAttr);
         animatableAttributes.add(SVGNames::amplitudeAttr);
         animatableAttributes.add(SVGNames::azimuthAttr);
         animatableAttributes.add(SVGNames::baseFrequencyAttr);
@@ -905,11 +906,9 @@
         animatableAttributes.add(SVGNames::yAttr);
         animatableAttributes.add(SVGNames::yChannelSelectorAttr);
         animatableAttributes.add(SVGNames::zAttr);
+        animatableAttributes.add(XLinkNames::hrefAttr);
     }
 
-    if (name == classAttr)
-        return true;
-
     return animatableAttributes.contains(name);
 }
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to