Title: [163513] trunk/Source/_javascript_Core
Revision
163513
Author
[email protected]
Date
2014-02-05 21:26:57 -0800 (Wed, 05 Feb 2014)

Log Message

Don't speculate on ToThis if we already know that arg0 has a questionable record with structure checks
https://bugs.webkit.org/show_bug.cgi?id=128229

Reviewed by Geoffrey Garen.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (163512 => 163513)


--- trunk/Source/_javascript_Core/ChangeLog	2014-02-06 05:14:19 UTC (rev 163512)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-06 05:26:57 UTC (rev 163513)
@@ -1,3 +1,13 @@
+2014-02-04  Filip Pizlo  <[email protected]>
+
+        Don't speculate on ToThis if we already know that arg0 has a questionable record with structure checks
+        https://bugs.webkit.org/show_bug.cgi?id=128229
+
+        Reviewed by Geoffrey Garen.
+
+        * dfg/DFGByteCodeParser.cpp:
+        (JSC::DFG::ByteCodeParser::parseBlock):
+
 2014-02-05  Mark Hahnenberg  <[email protected]>
 
         Handling of opaque roots is wrong in EdenCollections

Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (163512 => 163513)


--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2014-02-06 05:14:19 UTC (rev 163512)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2014-02-06 05:26:57 UTC (rev 163513)
@@ -1970,7 +1970,8 @@
                     || cachedStructure->classInfo()->methodTable.toThis != JSObject::info()->methodTable.toThis
                     || m_inlineStackTop->m_profiledBlock->couldTakeSlowCase(m_currentIndex)
                     || m_inlineStackTop->m_exitProfile.hasExitSite(m_currentIndex, BadCache)
-                    || m_inlineStackTop->m_exitProfile.hasExitSite(m_currentIndex, BadCacheWatchpoint)) {
+                    || m_inlineStackTop->m_exitProfile.hasExitSite(m_currentIndex, BadCacheWatchpoint)
+                    || (op1->op() == GetLocal && op1->variableAccessData()->structureCheckHoistingFailed())) {
                     setThis(addToGraph(ToThis, op1));
                 } else {
                     addToGraph(
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to