Title: [163603] trunk/Source/WebKit2
- Revision
- 163603
- Author
- [email protected]
- Date
- 2014-02-06 18:41:10 -0800 (Thu, 06 Feb 2014)
Log Message
Crash in MiniBrowser when using Command-W to close a WK2 window
https://bugs.webkit.org/show_bug.cgi?id=128355
<rdar://problem/16008531>
Reviewed by Simon Fraser.
Don't set the API clients to nullptr when closing the page, just create new empty ones instead.
Too much code depends on the clients never being null.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163602 => 163603)
--- trunk/Source/WebKit2/ChangeLog 2014-02-07 02:30:11 UTC (rev 163602)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-07 02:41:10 UTC (rev 163603)
@@ -1,3 +1,17 @@
+2014-02-06 Anders Carlsson <[email protected]>
+
+ Crash in MiniBrowser when using Command-W to close a WK2 window
+ https://bugs.webkit.org/show_bug.cgi?id=128355
+ <rdar://problem/16008531>
+
+ Reviewed by Simon Fraser.
+
+ Don't set the API clients to nullptr when closing the page, just create new empty ones instead.
+ Too much code depends on the clients never being null.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::close):
+
2014-02-03 Tim Horton <[email protected]>
[wk2] iOS should use accelerated drawing by default, except in the simulator
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (163602 => 163603)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-02-07 02:30:11 UTC (rev 163602)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-02-07 02:41:10 UTC (rev 163603)
@@ -578,10 +578,10 @@
resetState();
- m_loaderClient = nullptr;
- m_policyClient = nullptr;
+ m_loaderClient = std::make_unique<API::LoaderClient>();
+ m_policyClient = std::make_unique<API::PolicyClient>();
m_formClient.initialize(0);
- m_uiClient = nullptr;
+ m_uiClient = std::make_unique<API::UIClient>();
#if PLATFORM(EFL)
m_uiPopupMenuClient.initialize(0);
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
