Title: [163684] trunk/Source/WebKit2
- Revision
- 163684
- Author
- [email protected]
- Date
- 2014-02-07 18:51:15 -0800 (Fri, 07 Feb 2014)
Log Message
Add better comments to code that boosts the NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=128431
Rubber stamped by Tim Horton
* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
(WebKit::XPCServiceEventHandler):
* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163683 => 163684)
--- trunk/Source/WebKit2/ChangeLog 2014-02-08 02:42:43 UTC (rev 163683)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-08 02:51:15 UTC (rev 163684)
@@ -1,3 +1,17 @@
+2014-02-07 Gavin Barraclough <[email protected]>
+
+ Add better comments to code that boosts the NetworkProcess
+ https://bugs.webkit.org/show_bug.cgi?id=128431
+
+ Rubber stamped by Tim Horton
+
+ * Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
+ (WebKit::XPCServiceEventHandler):
+ * Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
+ (WebKit::XPCServiceEventHandler):
+ * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+ (WebKit::connectToService):
+
2014-02-07 Tim Horton <[email protected]>
Build fix.
Modified: trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm (163683 => 163684)
--- trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm 2014-02-08 02:42:43 UTC (rev 163683)
+++ trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm 2014-02-08 02:51:15 UTC (rev 163684)
@@ -147,10 +147,9 @@
initializerFunctionPtr(peer, event);
}
- if (!strcmp(xpc_dictionary_get_string(event, "message-name"), "pre-bootstrap")) {
- // Hold on to the pre-bootstrap message.
+ // Leak a boost onto the NetworkProcess.
+ if (!strcmp(xpc_dictionary_get_string(event, "message-name"), "pre-bootstrap"))
xpc_retain(event);
- }
}
});
Modified: trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm (163683 => 163684)
--- trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm 2014-02-08 02:42:43 UTC (rev 163683)
+++ trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm 2014-02-08 02:51:15 UTC (rev 163684)
@@ -60,10 +60,9 @@
initializerFunctionPtr(peer, event);
}
- if (!strcmp(xpc_dictionary_get_string(event, "message-name"), "pre-bootstrap")) {
- // Hold on to the pre-bootstrap message.
+ // Leak a boost onto the NetworkProcess.
+ if (!strcmp(xpc_dictionary_get_string(event, "message-name"), "pre-bootstrap"))
xpc_retain(event);
- }
}
});
Modified: trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm (163683 => 163684)
--- trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2014-02-08 02:42:43 UTC (rev 163683)
+++ trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2014-02-08 02:51:15 UTC (rev 163684)
@@ -181,6 +181,7 @@
xpc_connection_resume(connection);
#if ENABLE(NETWORK_PROCESS)
+ // Leak a boost onto the NetworkProcess.
if (launchOptions.processType == ProcessLauncher::NetworkProcess) {
xpc_object_t preBootstrapMessage = xpc_dictionary_create(0, 0, 0);
xpc_dictionary_set_string(preBootstrapMessage, "message-name", "pre-bootstrap");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
