Title: [163686] trunk
- Revision
- 163686
- Author
- k...@webkit.org
- Date
- 2014-02-07 19:01:19 -0800 (Fri, 07 Feb 2014)
Log Message
Per CSSOM, computed rect() function values must be comma separated
https://bugs.webkit.org/show_bug.cgi?id=128401
Reviewed by Simon Fraser.
Updated tests.
* css/Rect.h:
(WebCore::Rect::generateCSSString):
Modified Paths
Diff
Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-with-zoom-expected.txt (163685 => 163686)
--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-with-zoom-expected.txt 2014-02-08 02:52:05 UTC (rev 163685)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-with-zoom-expected.txt 2014-02-08 03:01:19 UTC (rev 163686)
@@ -25,7 +25,7 @@
PASS border-top-width, value: "20px"
PASS bottom, value: "20px"
PASS bottom, value: "-20px"
-PASS clip, value: "rect(20px 80px 80px 20px)"
+PASS clip, value: "rect(20px, 80px, 80px, 20px)"
PASS font-size, value: "20px"
PASS font-size, value: "18px"
PASS height, value: "20px"
Modified: trunk/LayoutTests/fast/css/getPropertyValue-clip.html (163685 => 163686)
--- trunk/LayoutTests/fast/css/getPropertyValue-clip.html 2014-02-08 02:52:05 UTC (rev 163685)
+++ trunk/LayoutTests/fast/css/getPropertyValue-clip.html 2014-02-08 03:01:19 UTC (rev 163686)
@@ -14,7 +14,7 @@
if (window.testRunner)
testRunner.dumpAsText();
var div = document.getElementById("clip");
- if (getComputedStyle(div,'').getPropertyValue("clip") != "rect(5px 24px 1px 12px)") {
+ if (getComputedStyle(div,'').getPropertyValue("clip") != "rect(5px, 24px, 1px, 12px)") {
log("FAILED");
return;
}
Modified: trunk/Source/WebCore/ChangeLog (163685 => 163686)
--- trunk/Source/WebCore/ChangeLog 2014-02-08 02:52:05 UTC (rev 163685)
+++ trunk/Source/WebCore/ChangeLog 2014-02-08 03:01:19 UTC (rev 163686)
@@ -1,3 +1,15 @@
+2014-02-07 Dirk Schulze <k...@webkit.org>
+
+ Per CSSOM, computed rect() function values must be comma separated
+ https://bugs.webkit.org/show_bug.cgi?id=128401
+
+ Reviewed by Simon Fraser.
+
+ Updated tests.
+
+ * css/Rect.h:
+ (WebCore::Rect::generateCSSString):
+
2014-02-07 Gavin Barraclough <barraclo...@apple.com>
Remove isInitialState flag from Page::setViewState
Modified: trunk/Source/WebCore/css/Rect.h (163685 => 163686)
--- trunk/Source/WebCore/css/Rect.h 2014-02-08 02:52:05 UTC (rev 163685)
+++ trunk/Source/WebCore/css/Rect.h 2014-02-08 03:01:19 UTC (rev 163686)
@@ -82,7 +82,7 @@
Rect(const Rect& cloneFrom) : RectBase(cloneFrom), RefCounted<Rect>() { }
static String generateCSSString(const String& top, const String& right, const String& bottom, const String& left)
{
- return "rect(" + top + ' ' + right + ' ' + bottom + ' ' + left + ')';
+ return "rect(" + top + ", " + right + ", " + bottom + ", " + left + ')';
}
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
