Title: [163957] trunk/Source/WebCore
Revision
163957
Author
[email protected]
Date
2014-02-12 05:31:22 -0800 (Wed, 12 Feb 2014)

Log Message

[CSS Regions] Remove unused method in RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=128373

Reviewed by Mihnea Ovidenie.

After the landing of https://bugs.webkit.org/show_bug.cgi?id=118665, the
RenderFlowThread::computeRegionClippingRect method is obsolete.

No new tests needed, this patch only removes an unused method.

* rendering/RenderFlowThread.cpp:
* rendering/RenderFlowThread.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (163956 => 163957)


--- trunk/Source/WebCore/ChangeLog	2014-02-12 13:21:10 UTC (rev 163956)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 13:31:22 UTC (rev 163957)
@@ -1,3 +1,18 @@
+2014-02-12  Radu Stavila  <[email protected]>
+
+        [CSS Regions] Remove unused method in RenderFlowThread
+        https://bugs.webkit.org/show_bug.cgi?id=128373
+
+        Reviewed by Mihnea Ovidenie.
+
+        After the landing of https://bugs.webkit.org/show_bug.cgi?id=118665, the 
+        RenderFlowThread::computeRegionClippingRect method is obsolete.
+
+        No new tests needed, this patch only removes an unused method.
+
+        * rendering/RenderFlowThread.cpp:
+        * rendering/RenderFlowThread.h:
+
 2014-02-12  Mihai Tica  <[email protected]>
 
         [CSS Element Blending] Implement the software path of -webkit-blend-mode with Core Graphics.

Modified: trunk/Source/WebCore/rendering/RenderFlowThread.cpp (163956 => 163957)


--- trunk/Source/WebCore/rendering/RenderFlowThread.cpp	2014-02-12 13:21:10 UTC (rev 163956)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.cpp	2014-02-12 13:31:22 UTC (rev 163957)
@@ -390,14 +390,6 @@
     }
 }
 
-LayoutRect RenderFlowThread::computeRegionClippingRect(const LayoutPoint& offset, const LayoutRect& flowThreadPortionRect, const LayoutRect& flowThreadPortionOverflowRect) const
-{
-    LayoutRect regionClippingRect(offset + (flowThreadPortionOverflowRect.location() - flowThreadPortionRect.location()), flowThreadPortionOverflowRect.size());
-    if (style().isFlippedBlocksWritingMode())
-        regionClippingRect.move(flowThreadPortionRect.size() - flowThreadPortionOverflowRect.size());
-    return regionClippingRect;
-}
-
 bool RenderFlowThread::nodeAtPoint(const HitTestRequest& request, HitTestResult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction hitTestAction)
 {
     if (hitTestAction == HitTestBlockBackground)

Modified: trunk/Source/WebCore/rendering/RenderFlowThread.h (163956 => 163957)


--- trunk/Source/WebCore/rendering/RenderFlowThread.h	2014-02-12 13:21:10 UTC (rev 163956)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.h	2014-02-12 13:31:22 UTC (rev 163957)
@@ -231,8 +231,6 @@
     void updateRegionsFlowThreadPortionRect(const RenderRegion* = 0);
     bool shouldRepaint(const LayoutRect&) const;
 
-    LayoutRect computeRegionClippingRect(const LayoutPoint&, const LayoutRect&, const LayoutRect&) const;
-
     bool updateAllLayerToRegionMappings();
 
     // Triggers a layers' update if a layer has moved from a region to another since the last update.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to