Title: [164048] trunk/Source/WebInspectorUI
Revision
164048
Author
[email protected]
Date
2014-02-13 12:46:48 -0800 (Thu, 13 Feb 2014)

Log Message

Web Inspector: long script names should be have text-overflow:ellipsis in probe details sidebar
https://bugs.webkit.org/show_bug.cgi?id=128550

Reviewed by Timothy Hatcher.

Make the link element 'display: block', place it after the floated icons,
and set the appropriate CSS overflow properties.

* UserInterface/ProbeDetailsSidebarPanel.css:
(.details-section.probe-set .options > a.go-to-link):
* UserInterface/ProbeSetDetailsSection.js:
(WebInspector.ProbeSetDetailsSection):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (164047 => 164048)


--- trunk/Source/WebInspectorUI/ChangeLog	2014-02-13 20:45:35 UTC (rev 164047)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-02-13 20:46:48 UTC (rev 164048)
@@ -1,3 +1,18 @@
+2014-02-13  Brian Burg  <[email protected]>
+
+        Web Inspector: long script names should be have text-overflow:ellipsis in probe details sidebar
+        https://bugs.webkit.org/show_bug.cgi?id=128550
+
+        Reviewed by Timothy Hatcher.
+
+        Make the link element 'display: block', place it after the floated icons,
+        and set the appropriate CSS overflow properties.
+
+        * UserInterface/ProbeDetailsSidebarPanel.css:
+        (.details-section.probe-set .options > a.go-to-link):
+        * UserInterface/ProbeSetDetailsSection.js:
+        (WebInspector.ProbeSetDetailsSection):
+
 2014-02-13  Javier Fernandez  <[email protected]>
 
         [CSS Grid Layout] Rename named areas property

Modified: trunk/Source/WebInspectorUI/UserInterface/ProbeDetailsSidebarPanel.css (164047 => 164048)


--- trunk/Source/WebInspectorUI/UserInterface/ProbeDetailsSidebarPanel.css	2014-02-13 20:45:35 UTC (rev 164047)
+++ trunk/Source/WebInspectorUI/UserInterface/ProbeDetailsSidebarPanel.css	2014-02-13 20:46:48 UTC (rev 164048)
@@ -64,6 +64,12 @@
     font-size: 10px;
 }
 
+.details-section.probe-set .options > a.go-to-link {
+    text-overflow: ellipsis;
+    overflow: hidden;
+    display: block;
+}
+
 .panel.probes ::-webkit-scrollbar {
     height: 5px;
     width: 5px;

Modified: trunk/Source/WebInspectorUI/UserInterface/ProbeSetDetailsSection.js (164047 => 164048)


--- trunk/Source/WebInspectorUI/UserInterface/ProbeSetDetailsSection.js	2014-02-13 20:45:35 UTC (rev 164047)
+++ trunk/Source/WebInspectorUI/UserInterface/ProbeSetDetailsSection.js	2014-02-13 20:46:48 UTC (rev 164048)
@@ -32,9 +32,6 @@
 
     var optionsElement = document.createElement("div");
     optionsElement.classList.add(WebInspector.ProbeSetDetailsSection.SectionOptionsStyleClassName);
-    var titleElement = this._probeSetPositionTextOrLink();
-    titleElement.classList.add(WebInspector.ProbeSetDetailsSection.DontFloatLinkStyleClassName);
-    optionsElement.appendChild(titleElement);
 
     var removeProbeButton = optionsElement.createChild("img");
     removeProbeButton.classList.add(WebInspector.ProbeSetDetailsSection.ProbeRemoveStyleClassName);
@@ -50,6 +47,10 @@
     addProbeButton.classList.add(WebInspector.ProbeSetDetailsSection.AddProbeValueStyleClassName);
     this._listeners.register(addProbeButton, "click", this._addProbeButtonClicked);
 
+    var titleElement = this._probeSetPositionTextOrLink();
+    titleElement.classList.add(WebInspector.ProbeSetDetailsSection.DontFloatLinkStyleClassName);
+    optionsElement.appendChild(titleElement);
+
     this._dataGrid = new WebInspector.ProbeSetDataGrid(probeSet);
     this._dataGrid.element.classList.add("inline");
     var singletonRow = new WebInspector.DetailsSectionRow;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to