Diff
Modified: trunk/Source/WebCore/ChangeLog (164083 => 164084)
--- trunk/Source/WebCore/ChangeLog 2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/ChangeLog 2014-02-14 01:59:29 UTC (rev 164084)
@@ -1,3 +1,25 @@
+2014-02-13 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ Remove position:sticky runtime flag
+ https://bugs.webkit.org/show_bug.cgi?id=128774
+
+ Reviewed by Simon Fraser.
+
+ Rollout of r128663
+
+ No new tests are necessary because there is no behavior change.
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParserContext::CSSParserContext):
+ (WebCore::operator==):
+ (WebCore::isValidKeywordPropertyAndValue):
+ * css/CSSParserMode.h:
+ * dom/Document.cpp:
+ * dom/Document.h:
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ * page/Settings.h:
+
2014-02-04 Gustavo Noronha Silva <g...@gnome.org>
[GTK][CMake] Generate GObject DOM bindings .symbols files
Modified: trunk/Source/WebCore/css/CSSParser.cpp (164083 => 164084)
--- trunk/Source/WebCore/css/CSSParser.cpp 2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2014-02-14 01:59:29 UTC (rev 164084)
@@ -245,7 +245,6 @@
: baseURL(baseURL)
, mode(mode)
, isHTMLDocument(false)
- , isCSSStickyPositionEnabled(false)
, isCSSRegionsEnabled(false)
, isCSSCompositingEnabled(false)
, isCSSGridLayoutEnabled(false)
@@ -266,7 +265,6 @@
, charset(charset)
, mode(document.inQuirksMode() ? CSSQuirksMode : CSSStrictMode)
, isHTMLDocument(document.isHTMLDocument())
- , isCSSStickyPositionEnabled(document.cssStickyPositionEnabled())
, isCSSRegionsEnabled(document.cssRegionsEnabled())
, isCSSCompositingEnabled(document.cssCompositingEnabled())
, isCSSGridLayoutEnabled(document.cssGridLayoutEnabled())
@@ -288,7 +286,6 @@
&& a.charset == b.charset
&& a.mode == b.mode
&& a.isHTMLDocument == b.isHTMLDocument
- && a.isCSSStickyPositionEnabled == b.isCSSStickyPositionEnabled
&& a.isCSSRegionsEnabled == b.isCSSRegionsEnabled
&& a.isCSSCompositingEnabled == b.isCSSCompositingEnabled
&& a.isCSSGridLayoutEnabled == b.isCSSGridLayoutEnabled
@@ -751,7 +748,7 @@
case CSSPropertyPosition: // static | relative | absolute | fixed | sticky | inherit
if (valueID == CSSValueStatic || valueID == CSSValueRelative || valueID == CSSValueAbsolute || valueID == CSSValueFixed
#if ENABLE(CSS_STICKY_POSITION)
- || (parserContext.isCSSStickyPositionEnabled && valueID == CSSValueWebkitSticky)
+ || valueID == CSSValueWebkitSticky
#endif
)
return true;
Modified: trunk/Source/WebCore/css/CSSParserMode.h (164083 => 164084)
--- trunk/Source/WebCore/css/CSSParserMode.h 2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/css/CSSParserMode.h 2014-02-14 01:59:29 UTC (rev 164084)
@@ -64,7 +64,6 @@
String charset;
CSSParserMode mode;
bool isHTMLDocument;
- bool isCSSStickyPositionEnabled;
bool isCSSRegionsEnabled;
bool isCSSCompositingEnabled;
bool isCSSGridLayoutEnabled;
Modified: trunk/Source/WebCore/dom/Document.cpp (164083 => 164084)
--- trunk/Source/WebCore/dom/Document.cpp 2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-02-14 01:59:29 UTC (rev 164084)
@@ -1082,11 +1082,6 @@
return settings() && settings()->regionBasedColumnsEnabled();
}
-bool Document::cssStickyPositionEnabled() const
-{
- return settings() && settings()->cssStickyPositionEnabled();
-}
-
bool Document::cssRegionsEnabled() const
{
return RuntimeEnabledFeatures::sharedFeatures().cssRegionsEnabled();
Modified: trunk/Source/WebCore/dom/Document.h (164083 => 164084)
--- trunk/Source/WebCore/dom/Document.h 2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/dom/Document.h 2014-02-14 01:59:29 UTC (rev 164084)
@@ -394,7 +394,6 @@
PassRefPtr<Element> createElementNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&);
PassRefPtr<Element> createElement(const QualifiedName&, bool createdByParser);
- bool cssStickyPositionEnabled() const;
bool cssRegionsEnabled() const;
bool cssCompositingEnabled() const;
#if ENABLE(CSS_REGIONS)
Modified: trunk/Source/WebCore/page/Settings.cpp (164083 => 164084)
--- trunk/Source/WebCore/page/Settings.cpp 2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/page/Settings.cpp 2014-02-14 01:59:29 UTC (rev 164084)
@@ -189,9 +189,6 @@
, m_alwaysUseBaselineOfPrimaryFont(false)
, m_alwaysUseAcceleratedOverflowScroll(false)
#endif
-#if ENABLE(CSS_STICKY_POSITION)
- , m_cssStickyPositionEnabled(true)
-#endif
, m_showTiledScrollingIndicator(false)
, m_tiledBackingStoreEnabled(false)
, m_backgroundShouldExtendBeyondPage(false)
Modified: trunk/Source/WebCore/page/Settings.h (164083 => 164084)
--- trunk/Source/WebCore/page/Settings.h 2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/page/Settings.h 2014-02-14 01:59:29 UTC (rev 164084)
@@ -212,14 +212,6 @@
void setFontRenderingMode(FontRenderingMode mode);
FontRenderingMode fontRenderingMode() const;
-#if ENABLE(CSS_STICKY_POSITION)
- void setCSSStickyPositionEnabled(bool enabled) { m_cssStickyPositionEnabled = enabled; }
- bool cssStickyPositionEnabled() const { return m_cssStickyPositionEnabled; }
-#else
- void setCSSStickyPositionEnabled(bool) { }
- bool cssStickyPositionEnabled() const { return false; }
-#endif
-
void setShowTiledScrollingIndicator(bool);
bool showTiledScrollingIndicator() const { return m_showTiledScrollingIndicator; }
@@ -353,9 +345,6 @@
bool m_allowMultiElementImplicitFormSubmission : 1;
bool m_alwaysUseAcceleratedOverflowScroll : 1;
#endif
-#if ENABLE(CSS_STICKY_POSITION)
- bool m_cssStickyPositionEnabled : 1;
-#endif
bool m_showTiledScrollingIndicator : 1;
bool m_tiledBackingStoreEnabled : 1;
bool m_backgroundShouldExtendBeyondPage : 1;
