Title: [164090] trunk
- Revision
- 164090
- Author
- [email protected]
- Date
- 2014-02-13 19:35:13 -0800 (Thu, 13 Feb 2014)
Log Message
[GTK] [CMake] _javascript_Core crashes in JSC::eval
https://bugs.webkit.org/show_bug.cgi?id=128434
Extend a fix for EFL to all ports that use GCC. Also include further fixes
that were applied only to the autotools build.
Reviewed by Gyuyoung Kim.
* Source/cmake/OptionsCommon.cmake: Add -fno-omit-frame-pointer to all ports as well
as -fno-tree-dce, which is necessary for GTK+.
* Source/cmake/OptionsEfl.cmake: The GCC flag additions are now in the common options file.
Modified Paths
Diff
Modified: trunk/ChangeLog (164089 => 164090)
--- trunk/ChangeLog 2014-02-14 02:42:10 UTC (rev 164089)
+++ trunk/ChangeLog 2014-02-14 03:35:13 UTC (rev 164090)
@@ -1,3 +1,17 @@
+2014-02-09 Martin Robinson <[email protected]>
+
+ [GTK] [CMake] _javascript_Core crashes in JSC::eval
+ https://bugs.webkit.org/show_bug.cgi?id=128434
+
+ Extend a fix for EFL to all ports that use GCC. Also include further fixes
+ that were applied only to the autotools build.
+
+ Reviewed by Gyuyoung Kim.
+
+ * Source/cmake/OptionsCommon.cmake: Add -fno-omit-frame-pointer to all ports as well
+ as -fno-tree-dce, which is necessary for GTK+.
+ * Source/cmake/OptionsEfl.cmake: The GCC flag additions are now in the common options file.
+
2014-02-04 Gustavo Noronha Silva <[email protected]>
[GTK][CMake] Generate GObject DOM bindings .symbols files
Modified: trunk/Source/cmake/OptionsCommon.cmake (164089 => 164090)
--- trunk/Source/cmake/OptionsCommon.cmake 2014-02-14 02:42:10 UTC (rev 164089)
+++ trunk/Source/cmake/OptionsCommon.cmake 2014-02-14 03:35:13 UTC (rev 164090)
@@ -19,6 +19,12 @@
set(CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS "${CMAKE_CXX_COMPILER} -E -x c++")
endif ()
+# Push of rbp is needed after JSC JIT uses CStack. See http://wkbug.com/127777.
+if (CMAKE_COMPILER_IS_GNUCC AND UNIX AND NOT APPLE)
+ set(CMAKE_C_FLAGS_RELEASE "-fno-omit-frame-pointer -fno-tree-dce ${CMAKE_C_FLAGS_RELEASE}")
+ set(CMAKE_CXX_FLAGS_RELEASE "-fno-omit-frame-pointer -fno-tree-dce ${CMAKE_CXX_FLAGS_RELEASE}")
+endif ()
+
set_property(GLOBAL PROPERTY USE_FOLDERS ON)
if (CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
Modified: trunk/Source/cmake/OptionsEfl.cmake (164089 => 164090)
--- trunk/Source/cmake/OptionsEfl.cmake 2014-02-14 02:42:10 UTC (rev 164089)
+++ trunk/Source/cmake/OptionsEfl.cmake 2014-02-14 03:35:13 UTC (rev 164090)
@@ -262,13 +262,6 @@
set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "-Wl,--gc-sections ${CMAKE_SHARED_LINKER_FLAGS_RELEASE}")
endif ()
-# push of rbp is needed after JSC JIT uses CStack
-if (CMAKE_COMPILER_IS_GNUCC AND UNIX AND NOT APPLE)
- set(CMAKE_C_FLAGS_RELEASE "-fno-omit-frame-pointer ${CMAKE_C_FLAGS_RELEASE}")
- set(CMAKE_CXX_FLAGS_RELEASE "-fno-omit-frame-pointer ${CMAKE_CXX_FLAGS_RELEASE}")
-endif ()
-
-
if (ENABLE_SPELLCHECK)
find_package(Enchant REQUIRED)
endif ()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
