Title: [164186] trunk/Source/WebCore
- Revision
- 164186
- Author
- [email protected]
- Date
- 2014-02-15 19:07:14 -0800 (Sat, 15 Feb 2014)
Log Message
Remove unused arguments from moveTo(Range*)
https://bugs.webkit.org/show_bug.cgi?id=128878
Reviewed by Antti Koivisto.
Cleanup.
* bindings/objc/DOMUIKitExtensions.mm:
(-[DOMRange move:inDirection:]):
(-[DOMRange extend:inDirection:]):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::moveTo):
* editing/FrameSelection.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (164185 => 164186)
--- trunk/Source/WebCore/ChangeLog 2014-02-16 02:54:26 UTC (rev 164185)
+++ trunk/Source/WebCore/ChangeLog 2014-02-16 03:07:14 UTC (rev 164186)
@@ -1,3 +1,19 @@
+2014-02-15 Ryosuke Niwa <[email protected]>
+
+ Remove unused arguments from moveTo(Range*)
+ https://bugs.webkit.org/show_bug.cgi?id=128878
+
+ Reviewed by Antti Koivisto.
+
+ Cleanup.
+
+ * bindings/objc/DOMUIKitExtensions.mm:
+ (-[DOMRange move:inDirection:]):
+ (-[DOMRange extend:inDirection:]):
+ * editing/FrameSelection.cpp:
+ (WebCore::FrameSelection::moveTo):
+ * editing/FrameSelection.h:
+
2014-02-15 Filip Pizlo <[email protected]>
Vector with inline capacity should work with non-PODs
Modified: trunk/Source/WebCore/bindings/objc/DOMUIKitExtensions.mm (164185 => 164186)
--- trunk/Source/WebCore/bindings/objc/DOMUIKitExtensions.mm 2014-02-16 02:54:26 UTC (rev 164185)
+++ trunk/Source/WebCore/bindings/objc/DOMUIKitExtensions.mm 2014-02-16 03:07:14 UTC (rev 164186)
@@ -94,7 +94,7 @@
{
Range *range = core(self);
FrameSelection frameSelection;
- frameSelection.moveTo(range, DOWNSTREAM);
+ frameSelection.moveTo(range);
TextGranularity granularity = CharacterGranularity;
// Until WebKit supports vertical layout, "down" is equivalent to "forward by a line" and
@@ -121,7 +121,7 @@
{
Range *range = core(self);
FrameSelection frameSelection;
- frameSelection.moveTo(range, DOWNSTREAM);
+ frameSelection.moveTo(range);
for (UInt32 i = 0; i < amount; i++)
frameSelection.modify(FrameSelection::AlterationExtend, (SelectionDirection)direction, CharacterGranularity);
Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (164185 => 164186)
--- trunk/Source/WebCore/editing/FrameSelection.cpp 2014-02-16 02:54:26 UTC (rev 164185)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2014-02-16 03:07:14 UTC (rev 164186)
@@ -152,10 +152,10 @@
setSelection(VisibleSelection(pos, affinity, m_selection.isDirectional()), defaultSetSelectionOptions(userTriggered));
}
-void FrameSelection::moveTo(const Range *r, EAffinity affinity, EUserTriggered userTriggered)
+void FrameSelection::moveTo(const Range* range)
{
- VisibleSelection selection = r ? VisibleSelection(r->startPosition(), r->endPosition(), affinity) : VisibleSelection(Position(), Position(), affinity);
- setSelection(selection, defaultSetSelectionOptions(userTriggered));
+ VisibleSelection selection = range ? VisibleSelection(range->startPosition(), range->endPosition()) : VisibleSelection();
+ setSelection(selection);
}
void FrameSelection::moveTo(const Position &base, const Position &extent, EAffinity affinity, EUserTriggered userTriggered)
Modified: trunk/Source/WebCore/editing/FrameSelection.h (164185 => 164186)
--- trunk/Source/WebCore/editing/FrameSelection.h 2014-02-16 02:54:26 UTC (rev 164185)
+++ trunk/Source/WebCore/editing/FrameSelection.h 2014-02-16 03:07:14 UTC (rev 164186)
@@ -135,7 +135,7 @@
Element* rootEditableElementOrDocumentElement() const;
- void moveTo(const Range*, EAffinity, EUserTriggered = NotUserTriggered);
+ void moveTo(const Range*);
void moveTo(const VisiblePosition&, EUserTriggered = NotUserTriggered, CursorAlignOnScroll = AlignCursorOnScrollIfNeeded);
void moveTo(const VisiblePosition&, const VisiblePosition&, EUserTriggered = NotUserTriggered);
void moveTo(const Position&, EAffinity, EUserTriggered = NotUserTriggered);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
