Title: [164210] releases/WebKitGTK/webkit-2.4/Source/WebKit2
Revision
164210
Author
[email protected]
Date
2014-02-17 00:27:08 -0800 (Mon, 17 Feb 2014)

Log Message

Merge r163875 - O_CLOEXEC in shm_open does not work on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=128572

Reviewed by Darin Adler.

The O_CLOEXEC is not supported by shm_open() and is also not
necessary since FD_CLOEXEC is already set by default when the new
file descriptor is created.

* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::create):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog (164209 => 164210)


--- releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog	2014-02-17 08:21:05 UTC (rev 164209)
+++ releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog	2014-02-17 08:27:08 UTC (rev 164210)
@@ -1,3 +1,17 @@
+2014-02-11  Alberto Garcia  <[email protected]>
+
+        O_CLOEXEC in shm_open does not work on FreeBSD
+        https://bugs.webkit.org/show_bug.cgi?id=128572
+
+        Reviewed by Darin Adler.
+
+        The O_CLOEXEC is not supported by shm_open() and is also not
+        necessary since FD_CLOEXEC is already set by default when the new
+        file descriptor is created.
+
+        * Platform/unix/SharedMemoryUnix.cpp:
+        (WebKit::SharedMemory::create):
+
 2014-02-14  Carlos Garcia Campos  <[email protected]>
 
         [GTK] Fix marshaller used in WebKitWebPage::document-loaded signal

Modified: releases/WebKitGTK/webkit-2.4/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp (164209 => 164210)


--- releases/WebKitGTK/webkit-2.4/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp	2014-02-17 08:21:05 UTC (rev 164209)
+++ releases/WebKitGTK/webkit-2.4/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp	2014-02-17 08:27:08 UTC (rev 164210)
@@ -107,7 +107,7 @@
         tempName = name.utf8();
 
         do {
-            fileDescriptor = shm_open(tempName.data(), O_CREAT | O_CLOEXEC | O_RDWR, S_IRUSR | S_IWUSR);
+            fileDescriptor = shm_open(tempName.data(), O_CREAT | O_RDWR, S_IRUSR | S_IWUSR);
         } while (fileDescriptor == -1 && errno == EINTR);
     }
     if (fileDescriptor == -1) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to