Title: [164218] releases/WebKitGTK/webkit-2.2/Source/WebKit2
- Revision
- 164218
- Author
- [email protected]
- Date
- 2014-02-17 06:12:47 -0800 (Mon, 17 Feb 2014)
Log Message
Merge r162724 - [GTK] youtube HTML5 videos in fullscreen, after <Esc>, can't go fullscreen again
https://bugs.webkit.org/show_bug.cgi?id=127064
When pressing <Esc> or <f> at full screen, the WebView shall emit the
event webkitfullscreenchange, but wk2gtk does not emit it. This is
because the WebView manages directly the exit of the full screen.
With this patch the WebView calls requestExitFullScreen to the full
screen manager, instead of managing directly the exit of the full
screen, and the event webkitfullscreenchange will be dispatched
correctly.
Reviewed by Martin Robinson.
No tests are included because there is a bug in WKTR that prevents the
execution of a test for this patch. See
https://bugs.webkit.org/show_bug.cgi?id=127348
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseKeyPressEvent): Call
webkitWebViewBaseRequestExitFullScreen.
(webkitWebViewBaseRequestExitFullScreen): Added.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Ditto.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.2/Source/WebKit2/ChangeLog (164217 => 164218)
--- releases/WebKitGTK/webkit-2.2/Source/WebKit2/ChangeLog 2014-02-17 13:23:33 UTC (rev 164217)
+++ releases/WebKitGTK/webkit-2.2/Source/WebKit2/ChangeLog 2014-02-17 14:12:47 UTC (rev 164218)
@@ -1,3 +1,29 @@
+2014-01-24 Víctor Manuel Jáquez Leal <[email protected]>
+
+ [GTK] youtube HTML5 videos in fullscreen, after <Esc>, can't go fullscreen again
+ https://bugs.webkit.org/show_bug.cgi?id=127064
+
+ When pressing <Esc> or <f> at full screen, the WebView shall emit the
+ event webkitfullscreenchange, but wk2gtk does not emit it. This is
+ because the WebView manages directly the exit of the full screen.
+
+ With this patch the WebView calls requestExitFullScreen to the full
+ screen manager, instead of managing directly the exit of the full
+ screen, and the event webkitfullscreenchange will be dispatched
+ correctly.
+
+ Reviewed by Martin Robinson.
+
+ No tests are included because there is a bug in WKTR that prevents the
+ execution of a test for this patch. See
+ https://bugs.webkit.org/show_bug.cgi?id=127348
+
+ * UIProcess/API/gtk/WebKitWebViewBase.cpp:
+ (webkitWebViewBaseKeyPressEvent): Call
+ webkitWebViewBaseRequestExitFullScreen.
+ (webkitWebViewBaseRequestExitFullScreen): Added.
+ * UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Ditto.
+
2014-01-15 Carlos Garcia Campos <[email protected]>
[GTK] Web process sometimes crashes when printing in synchronous mode
Modified: releases/WebKitGTK/webkit-2.2/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (164217 => 164218)
--- releases/WebKitGTK/webkit-2.2/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2014-02-17 13:23:33 UTC (rev 164217)
+++ releases/WebKitGTK/webkit-2.2/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2014-02-17 14:12:47 UTC (rev 164218)
@@ -573,7 +573,7 @@
case GDK_KEY_Escape:
case GDK_KEY_f:
case GDK_KEY_F:
- webkitWebViewBaseExitFullScreen(webViewBase);
+ priv->pageProxy->fullScreenManager()->requestExitFullScreen();
return TRUE;
default:
break;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
