Title: [164244] trunk/Tools
- Revision
- 164244
- Author
- [email protected]
- Date
- 2014-02-17 12:25:04 -0800 (Mon, 17 Feb 2014)
Log Message
[Win] Fall back to Windows symbol servers when necessary
https://bugs.webkit.org/show_bug.cgi?id=128926
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/port/win.py:
(WinPort):
(setup_crash_log_saving): Fall back to Microsoft Symbol Server when local symbols are
not specified.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (164243 => 164244)
--- trunk/Tools/ChangeLog 2014-02-17 20:23:34 UTC (rev 164243)
+++ trunk/Tools/ChangeLog 2014-02-17 20:25:04 UTC (rev 164244)
@@ -1,3 +1,15 @@
+2014-02-17 Brent Fulgham <[email protected]>
+
+ [Win] Fall back to Windows symbol servers when necessary
+ https://bugs.webkit.org/show_bug.cgi?id=128926
+
+ Reviewed by Ryosuke Niwa.
+
+ * Scripts/webkitpy/port/win.py:
+ (WinPort):
+ (setup_crash_log_saving): Fall back to Microsoft Symbol Server when local symbols are
+ not specified.
+
2014-02-17 László Langó <[email protected]>
Fix typos in Tools/efl/jhbuild.modules.
Modified: trunk/Tools/Scripts/webkitpy/port/win.py (164243 => 164244)
--- trunk/Tools/Scripts/webkitpy/port/win.py 2014-02-17 20:23:34 UTC (rev 164243)
+++ trunk/Tools/Scripts/webkitpy/port/win.py 2014-02-17 20:25:04 UTC (rev 164244)
@@ -199,8 +199,8 @@
def setup_crash_log_saving(self):
if '_NT_SYMBOL_PATH' not in os.environ:
- _log.warning("The _NT_SYMBOL_PATH environment variable is not set. Crash logs will not be saved.")
- return None
+ _log.warning("The _NT_SYMBOL_PATH environment variable is not set. Using Microsoft Symbol Server.")
+ os.environ['_NT_SYMBOL_PATH'] = 'SRV*http://msdl.microsoft.com/download/symbols'
ntsd_path = self._ntsd_location()
if not ntsd_path:
_log.warning("Can't find ntsd.exe. Crash logs will not be saved.")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
