Title: [164257] trunk
Revision
164257
Author
[email protected]
Date
2014-02-17 16:30:50 -0800 (Mon, 17 Feb 2014)

Log Message

[GTK] [CMake] _javascript_Core crashes in JSC::eval
https://bugs.webkit.org/show_bug.cgi?id=128434

Reviewed by Anders Carlsson.

* Source/cmake/OptionsGTK.cmake: Add -fno-omit-frame-pointer to the GTK+ CMake
port as well as -fno-tree-dce, like it is used in the autotools build.

Modified Paths

Diff

Modified: trunk/ChangeLog (164256 => 164257)


--- trunk/ChangeLog	2014-02-18 00:16:34 UTC (rev 164256)
+++ trunk/ChangeLog	2014-02-18 00:30:50 UTC (rev 164257)
@@ -1,3 +1,13 @@
+2014-02-16  Martin Robinson  <[email protected]>
+
+        [GTK] [CMake] _javascript_Core crashes in JSC::eval
+        https://bugs.webkit.org/show_bug.cgi?id=128434
+
+        Reviewed by Anders Carlsson.
+
+        * Source/cmake/OptionsGTK.cmake: Add -fno-omit-frame-pointer to the GTK+ CMake
+        port as well as -fno-tree-dce, like it is used in the autotools build.
+
 2014-02-17  ChangSeok Oh  <[email protected]>
 
         [GTK] MEDIA_CONTROLS_SCRIPT depends on VIDEO_TRACK

Modified: trunk/Source/cmake/OptionsGTK.cmake (164256 => 164257)


--- trunk/Source/cmake/OptionsGTK.cmake	2014-02-18 00:16:34 UTC (rev 164256)
+++ trunk/Source/cmake/OptionsGTK.cmake	2014-02-18 00:30:50 UTC (rev 164257)
@@ -266,6 +266,12 @@
 set(FORWARDING_HEADERS_WEBKIT2GTK_EXTENSION_DIR ${FORWARDING_HEADERS_DIR}/webkit2gtk-webextension)
 set(SHOULD_INSTALL_JS_SHELL ON)
 
+# Push of rbp is needed after JSC JIT uses CStack. See http://wkbug.com/127777.
+if (CMAKE_COMPILER_IS_GNUCC AND UNIX AND NOT APPLE)
+    set(CMAKE_C_FLAGS_RELEASE "-fno-omit-frame-pointer -fno-tree-dce ${CMAKE_C_FLAGS_RELEASE}")
+    set(CMAKE_CXX_FLAGS_RELEASE "-fno-omit-frame-pointer -fno-tree-dce ${CMAKE_CXX_FLAGS_RELEASE}")
+endif ()
+
 # Add a typelib file to the list of all typelib dependencies. This makes it easy to
 # expose a 'gir' target with all gobject-introspection files.
 macro(ADD_TYPELIB typelib)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to