Title: [164302] trunk/Source/WebCore
- Revision
- 164302
- Author
- commit-qu...@webkit.org
- Date
- 2014-02-18 12:05:42 -0800 (Tue, 18 Feb 2014)
Log Message
Unreviewed, rolling out r164296.
http://trac.webkit.org/changeset/164296
https://bugs.webkit.org/show_bug.cgi?id=128989
Broke many media tests (Requested by eric_carlson on #webkit).
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
* html/HTMLMediaElement.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (164301 => 164302)
--- trunk/Source/WebCore/ChangeLog 2014-02-18 19:51:02 UTC (rev 164301)
+++ trunk/Source/WebCore/ChangeLog 2014-02-18 20:05:42 UTC (rev 164302)
@@ -1,3 +1,15 @@
+2014-02-18 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r164296.
+ http://trac.webkit.org/changeset/164296
+ https://bugs.webkit.org/show_bug.cgi?id=128989
+
+ Broke many media tests (Requested by eric_carlson on #webkit).
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::parseAttribute):
+ * html/HTMLMediaElement.h:
+
2014-02-18 Myles C. Maxfield <mmaxfi...@apple.com>
Convert position:sticky to position:static upon copy and paste
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (164301 => 164302)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-02-18 19:51:02 UTC (rev 164301)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-02-18 20:05:42 UTC (rev 164302)
@@ -2439,18 +2439,10 @@
void HTMLMediaElement::refreshCachedTime() const
{
m_cachedTime = m_player->currentTime();
- if (!m_cachedTime) {
- // Do not use m_cachedTime until the media engine returns a non-zero value because we can't
- // estimate current time until playback actually begins.
- invalidateCachedTime();
- return;
- }
-
- LOG(Media, "HTMLMediaElement::refreshCachedTime - caching time %f", m_cachedTime);
m_clockTimeAtLastCachedTimeUpdate = monotonicallyIncreasingTime();
}
-void HTMLMediaElement::invalidateCachedTime() const
+void HTMLMediaElement::invalidateCachedTime()
{
LOG(Media, "HTMLMediaElement::invalidateCachedTime");
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (164301 => 164302)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2014-02-18 19:51:02 UTC (rev 164301)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2014-02-18 20:05:42 UTC (rev 164302)
@@ -653,7 +653,7 @@
virtual void mediaCanStart() override;
void setShouldDelayLoadEvent(bool);
- void invalidateCachedTime() const;
+ void invalidateCachedTime();
void refreshCachedTime() const;
bool hasMediaControls() const;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
