Title: [164431] trunk/Source/WebInspectorUI
- Revision
- 164431
- Author
- [email protected]
- Date
- 2014-02-20 09:19:18 -0800 (Thu, 20 Feb 2014)
Log Message
Web Inspector: content using a CSS transition within a popover causes the popover to disappear
https://bugs.webkit.org/show_bug.cgi?id=129089
Reviewed by Timothy Hatcher.
Simply check that the element being transitioned is indeed the popover's container before assuming
that the "transitonend" received was for a fade-out transition.
* UserInterface/Popover.js:
(WebInspector.Popover.prototype.handleEvent):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (164430 => 164431)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-02-20 17:01:52 UTC (rev 164430)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-02-20 17:19:18 UTC (rev 164431)
@@ -1,5 +1,18 @@
2014-02-20 Antoine Quint <[email protected]>
+ Web Inspector: content using a CSS transition within a popover causes the popover to disappear
+ https://bugs.webkit.org/show_bug.cgi?id=129089
+
+ Reviewed by Timothy Hatcher.
+
+ Simply check that the element being transitioned is indeed the popover's container before assuming
+ that the "transitonend" received was for a fade-out transition.
+
+ * UserInterface/Popover.js:
+ (WebInspector.Popover.prototype.handleEvent):
+
+2014-02-20 Antoine Quint <[email protected]>
+
Web Inspector: clicking on a color swatch in the Computed styles tab shouldn't show the color editing popover
https://bugs.webkit.org/show_bug.cgi?id=129093
Modified: trunk/Source/WebInspectorUI/UserInterface/Popover.js (164430 => 164431)
--- trunk/Source/WebInspectorUI/UserInterface/Popover.js 2014-02-20 17:01:52 UTC (rev 164430)
+++ trunk/Source/WebInspectorUI/UserInterface/Popover.js 2014-02-20 17:19:18 UTC (rev 164431)
@@ -154,12 +154,14 @@
this.dismiss();
break;
case "transitionend":
- document.body.removeChild(this._element);
- this._element.classList.remove(WebInspector.Popover.FadeOutClassName);
- this._container.textContent = "";
- if (this.delegate && typeof this.delegate.didDismissPopover === "function")
- this.delegate.didDismissPopover(this);
- break;
+ if (event.target === this._element) {
+ document.body.removeChild(this._element);
+ this._element.classList.remove(WebInspector.Popover.FadeOutClassName);
+ this._container.textContent = "";
+ if (this.delegate && typeof this.delegate.didDismissPopover === "function")
+ this.delegate.didDismissPopover(this);
+ break;
+ }
}
},
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
