Title: [164488] trunk/Source/WebKit2
- Revision
- 164488
- Author
- [email protected]
- Date
- 2014-02-21 11:28:15 -0800 (Fri, 21 Feb 2014)
Log Message
Make sure to invoke the completion handler for JS alerts
https://bugs.webkit.org/show_bug.cgi?id=129158
Reviewed by Alexey Proskuryakov.
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (164487 => 164488)
--- trunk/Source/WebKit2/ChangeLog 2014-02-21 19:17:28 UTC (rev 164487)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-21 19:28:15 UTC (rev 164488)
@@ -1,3 +1,13 @@
+2014-02-21 Anders Carlsson <[email protected]>
+
+ Make sure to invoke the completion handler for JS alerts
+ https://bugs.webkit.org/show_bug.cgi?id=129158
+
+ Reviewed by Alexey Proskuryakov.
+
+ * UIProcess/API/C/WKPage.cpp:
+ (WKPageSetPageUIClient):
+
2014-02-20 Zalan Bujtas <[email protected]>
Remove redundant deviceScaleFactor() functions and make callers use Document::deviceScaleFactor() when accessible.
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (164487 => 164488)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-02-21 19:17:28 UTC (rev 164487)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-02-21 19:28:15 UTC (rev 164488)
@@ -1167,6 +1167,7 @@
}
m_client.runJavaScriptAlert(toAPI(page), toAPI(message.impl()), toAPI(frame), m_client.base.clientInfo);
+ completionHandler();
}
virtual void runJavaScriptConfirm(WebPageProxy* page, const String& message, WebFrameProxy* frame, std::function<void (bool)> completionHandler) override
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
