Title: [164559] trunk/Tools
- Revision
- 164559
- Author
- [email protected]
- Date
- 2014-02-23 13:39:58 -0800 (Sun, 23 Feb 2014)
Log Message
[GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
https://bugs.webkit.org/show_bug.cgi?id=129191
Reviewed by Anders Carlsson.
* DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
for the GTK+ DumpRenderTree build. We could manually construct this path, but the
name of the directory is "lib" and not "libs". Instead we should use the CMake
variable specifically assigned to this task.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (164558 => 164559)
--- trunk/Tools/ChangeLog 2014-02-23 18:48:43 UTC (rev 164558)
+++ trunk/Tools/ChangeLog 2014-02-23 21:39:58 UTC (rev 164559)
@@ -1,3 +1,15 @@
+2014-02-23 Martin Robinson <[email protected]>
+
+ [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=129191
+
+ Reviewed by Anders Carlsson.
+
+ * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
+ for the GTK+ DumpRenderTree build. We could manually construct this path, but the
+ name of the directory is "lib" and not "libs". Instead we should use the CMake
+ variable specifically assigned to this task.
+
2014-02-23 David Kilzer <[email protected]>
[ASan] Add JSC::DFG::prepareOSREntry() to ignore list
Modified: trunk/Tools/DumpRenderTree/PlatformGTK.cmake (164558 => 164559)
--- trunk/Tools/DumpRenderTree/PlatformGTK.cmake 2014-02-23 18:48:43 UTC (rev 164558)
+++ trunk/Tools/DumpRenderTree/PlatformGTK.cmake 2014-02-23 21:39:58 UTC (rev 164559)
@@ -45,7 +45,7 @@
)
add_definitions(
- -DTEST_PLUGIN_DIR="${CMAKE_BINARY_DIR}/libs"
+ -DTEST_PLUGIN_DIR="${CMAKE_LIBRARY_OUTPUT_DIRECTORY}"
-DFONTS_CONF_DIR="${TOOLS_DIR}/DumpRenderTree/gtk/fonts"
-DTOP_LEVEL_DIR="${CMAKE_SOURCE_DIR}"
)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
