Title: [164574] trunk
- Revision
- 164574
- Author
- [email protected]
- Date
- 2014-02-23 18:11:36 -0800 (Sun, 23 Feb 2014)
Log Message
[WebGL] Allow ANGLE to initialize unused varyings
https://bugs.webkit.org/show_bug.cgi?id=129240
<rdar://problem/15203342>
Reviewed by Sam Weinig.
Source/WebCore:
Covered by: conformance/glsl/misc/shaders-with-varyings.html
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
Add SH_INIT_VARYINGS_WITHOUT_STATIC_USE to compiler flags.
LayoutTests:
Unskip conformance/glsl/misc/shaders-with-varyings.html.
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (164573 => 164574)
--- trunk/LayoutTests/ChangeLog 2014-02-24 02:01:19 UTC (rev 164573)
+++ trunk/LayoutTests/ChangeLog 2014-02-24 02:11:36 UTC (rev 164574)
@@ -1,3 +1,15 @@
+2014-02-23 Dean Jackson <[email protected]>
+
+ [WebGL] Allow ANGLE to initialize unused varyings
+ https://bugs.webkit.org/show_bug.cgi?id=129240
+ <rdar://problem/15203342>
+
+ Reviewed by Sam Weinig.
+
+ Unskip conformance/glsl/misc/shaders-with-varyings.html.
+
+ * platform/mac/TestExpectations:
+
2014-02-22 Alexey Proskuryakov <[email protected]>
Rename JWK key_ops values from wrap/unwrap to wrapKey/unwrapKey
Modified: trunk/LayoutTests/platform/mac/TestExpectations (164573 => 164574)
--- trunk/LayoutTests/platform/mac/TestExpectations 2014-02-24 02:01:19 UTC (rev 164573)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2014-02-24 02:11:36 UTC (rev 164574)
@@ -657,9 +657,6 @@
webgl/1.0.2/conformance/textures/texture-size.html [ Pass Failure ]
webgl/1.0.2/conformance/limits/gl-max-texture-dimensions.html [ Pass Failure ]
-# Currently working on 1.0.2 conformance, skip currently known failing tests, <rdar://problem/12099869>
-webgl/1.0.2/conformance/glsl/misc/shaders-with-varyings.html [ Failure ]
-
# Test is faulty, skipping for now
webgl/1.0.2/conformance/ogles/GL/build/build_009_to_016.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (164573 => 164574)
--- trunk/Source/WebCore/ChangeLog 2014-02-24 02:01:19 UTC (rev 164573)
+++ trunk/Source/WebCore/ChangeLog 2014-02-24 02:11:36 UTC (rev 164574)
@@ -1,3 +1,17 @@
+2014-02-23 Dean Jackson <[email protected]>
+
+ [WebGL] Allow ANGLE to initialize unused varyings
+ https://bugs.webkit.org/show_bug.cgi?id=129240
+ <rdar://problem/15203342>
+
+ Reviewed by Sam Weinig.
+
+ Covered by: conformance/glsl/misc/shaders-with-varyings.html
+
+ * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
+ (WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
+ Add SH_INIT_VARYINGS_WITHOUT_STATIC_USE to compiler flags.
+
2014-02-23 Sam Weinig <[email protected]>
Update FeatureDefines.xcconfig
Modified: trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp (164573 => 164574)
--- trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp 2014-02-24 02:01:19 UTC (rev 164573)
+++ trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp 2014-02-24 02:11:36 UTC (rev 164574)
@@ -170,7 +170,7 @@
String translatedShaderSource;
String shaderInfoLog;
- int extraCompileOptions = SH_MAP_LONG_VARIABLE_NAMES | SH_CLAMP_INDIRECT_ARRAY_BOUNDS | SH_UNFOLD_SHORT_CIRCUIT | SH_ENFORCE_PACKING_RESTRICTIONS;
+ int extraCompileOptions = SH_MAP_LONG_VARIABLE_NAMES | SH_CLAMP_INDIRECT_ARRAY_BOUNDS | SH_UNFOLD_SHORT_CIRCUIT | SH_ENFORCE_PACKING_RESTRICTIONS | SH_INIT_VARYINGS_WITHOUT_STATIC_USE;
if (m_requiresBuiltInFunctionEmulation)
extraCompileOptions |= SH_EMULATE_BUILT_IN_FUNCTIONS;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
