Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (164587 => 164588)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-02-24 15:52:42 UTC (rev 164587)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-02-24 17:05:33 UTC (rev 164588)
@@ -1,3 +1,24 @@
+2014-02-24 Diego Pino Garcia <[email protected]>
+
+ Web Inspector: Remove single quote characters from Web Inspector _javascript_ files
+ https://bugs.webkit.org/show_bug.cgi?id=129253
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector.openURL):
+ * UserInterface/Views/CookieStorageContentView.js:
+ (WebInspector.cookieDomainMatchesResourceDomain):
+ * UserInterface/Views/DOMTreeElement.js:
+ (WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
+ (WebInspector.DOMTreeElement.prototype._startEditingTagName.editingComitted):
+ (WebInspector.DOMTreeElement.prototype._startEditingTagName.editingCancelled):
+ (WebInspector.DOMTreeElement.prototype._startEditingTagName):
+ * UserInterface/Views/DOMTreeOutline.js:
+ (WebInspector.DOMTreeOutline.prototype._ondragover):
+ * UserInterface/Views/DataGrid.js:
+ (WebInspector.DataGrid.prototype.addPlaceholderNode):
+
2014-02-23 Dan Bernstein <[email protected]>
Removed -Wno-format-y2k from WARNING_CFLAGS
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (164587 => 164588)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2014-02-24 15:52:42 UTC (rev 164587)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2014-02-24 17:05:33 UTC (rev 164588)
@@ -491,7 +491,7 @@
// The path of of the profile URL starts with a slash, remove it, so
// we can get the actual title.
- console.assert(profileTitle[0] === '/');
+ console.assert(profileTitle[0] === "/");
profileTitle = profileTitle.substring(1);
this.timelineSidebarPanel.showProfile(profileType, profileTitle);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js (164587 => 164588)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js 2014-02-24 15:52:42 UTC (rev 164587)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js 2014-02-24 17:05:33 UTC (rev 164588)
@@ -251,7 +251,7 @@
WebInspector.cookieDomainMatchesResourceDomain = function(cookieDomain, resourceDomain)
{
- if (cookieDomain.charAt(0) !== '.')
+ if (cookieDomain.charAt(0) !== ".")
return resourceDomain === cookieDomain;
return !!resourceDomain.match(new RegExp("^([^\\.]+\\.)?" + cookieDomain.substring(1).escapeForRegExp() + "$"), "i");
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (164587 => 164588)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2014-02-24 15:52:42 UTC (rev 164587)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2014-02-24 17:05:33 UTC (rev 164588)
@@ -536,10 +536,10 @@
tag.insertBefore(node, tag.lastChild);
else {
var nodeName = tag.textContent.match(/^<(.*?)>$/)[1];
- tag.textContent = '';
- tag.appendChild(document.createTextNode('<'+nodeName));
+ tag.textContent = "";
+ tag.appendChild(document.createTextNode("<"+nodeName));
tag.appendChild(node);
- tag.appendChild(document.createTextNode('>'));
+ tag.appendChild(document.createTextNode(">"));
}
this.updateSelection();
@@ -749,17 +749,17 @@
function editingComitted(element, newTagName)
{
- tagNameElement.removeEventListener('keyup', keyupListener, false);
+ tagNameElement.removeEventListener("keyup", keyupListener, false);
this._tagNameEditingCommitted.apply(this, arguments);
}
function editingCancelled()
{
- tagNameElement.removeEventListener('keyup', keyupListener, false);
+ tagNameElement.removeEventListener("keyup", keyupListener, false);
this._editingCancelled.apply(this, arguments);
}
- tagNameElement.addEventListener('keyup', keyupListener, false);
+ tagNameElement.addEventListener("keyup", keyupListener, false);
var config = new WebInspector.EditingConfig(editingComitted.bind(this), editingCancelled.bind(this), tagName);
this._editing = WebInspector.startEditing(tagNameElement, config);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js (164587 => 164588)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2014-02-24 15:52:42 UTC (rev 164587)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2014-02-24 17:05:33 UTC (rev 164588)
@@ -377,7 +377,7 @@
treeElement.listItemElement.classList.add("elements-drag-over");
this._dragOverTreeElement = treeElement;
event.preventDefault();
- event.dataTransfer.dropEffect = 'move';
+ event.dataTransfer.dropEffect = "move";
return false;
},
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (164587 => 164588)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2014-02-24 15:52:42 UTC (rev 164587)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2014-02-24 17:05:33 UTC (rev 164588)
@@ -657,7 +657,7 @@
var emptyData = {};
for (var identifier of this.columns.keys())
- emptyData[identifier] = '';
+ emptyData[identifier] = "";
this.placeholderNode = new WebInspector.PlaceholderDataGridNode(emptyData);
this.appendChild(this.placeholderNode);
},
@@ -1108,7 +1108,7 @@
else {
var element = event.target.enclosingNodeOrSelfWithNodeName("td");
var columnIdentifier = element.__columnIdentifier;
- var columnTitle = this.dataGrid.columns.get(columnIdentifier).get('title');
+ var columnTitle = this.dataGrid.columns.get(columnIdentifier).get("title");
contextMenu.appendItem(WebInspector.UIString("Edit “%s”").format(columnTitle), this._startEditing.bind(this, event.target));
}
}
