- Revision
- 164623
- Author
- [email protected]
- Date
- 2014-02-24 19:00:59 -0800 (Mon, 24 Feb 2014)
Log Message
Fix the missing navigation bar in the Debugger sidebar panel.
Sorting the CSS resources caused specificity issue.
https://bugs.webkit.org/show_bug.cgi?id=129251
Reviewed by Joseph Pecoraro.
* UserInterface/Views/DebuggerSidebarPanel.css:
(.sidebar > .panel.navigation.debugger > .content):
(.sidebar > .panel.navigation.debugger > .navigation-bar):
* UserInterface/Views/LayoutTimelineView.css:
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.layout .item .subtitle):
* UserInterface/Views/NetworkTimelineView.css:
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.network .item .subtitle):
* UserInterface/Views/ResourceSidebarPanel.css:
(.sidebar > .panel.navigation.resource > .empty-content-placeholder):
(.sidebar > .panel.navigation.resource > .search-bar):
(.sidebar > .panel.navigation.resource > .search-bar > input[type="search"]):
* UserInterface/Views/ScriptTimelineView.css:
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.script .item .subtitle):
* UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline > .status-bar):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:hover):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording:hover):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.forced):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording.forced):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-status):
(.sidebar > .panel.navigation.timeline > .title-bar):
(.sidebar > .panel.navigation.timeline > .title-bar.timelines):
(.sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
(.sidebar > .panel.navigation.timeline > .timelines-content):
(.sidebar > .panel.navigation.timeline > .timelines-content .close-button):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item .icon):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected .close-button):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item:not(.selected):nth-child(even)):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item:not(.selected):not(:first-child)):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item):
(.sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item):
(.sidebar > .panel.navigation.timeline > .timelines-content .close-button:active):
(.sidebar > .panel.navigation.timeline > .empty-content-placeholder):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content):
(.sidebar > .panel.navigation.timeline > .content > .stripe-background):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content > .stripe-background):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (164622 => 164623)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-02-25 02:59:18 UTC (rev 164622)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-02-25 03:00:59 UTC (rev 164623)
@@ -1,5 +1,54 @@
2014-02-24 Timothy Hatcher <[email protected]>
+ Fix the missing navigation bar in the Debugger sidebar panel.
+
+ Sorting the CSS resources caused specificity issue.
+
+ https://bugs.webkit.org/show_bug.cgi?id=129251
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/DebuggerSidebarPanel.css:
+ (.sidebar > .panel.navigation.debugger > .content):
+ (.sidebar > .panel.navigation.debugger > .navigation-bar):
+ * UserInterface/Views/LayoutTimelineView.css:
+ (.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.layout .item .subtitle):
+ * UserInterface/Views/NetworkTimelineView.css:
+ (.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.network .item .subtitle):
+ * UserInterface/Views/ResourceSidebarPanel.css:
+ (.sidebar > .panel.navigation.resource > .empty-content-placeholder):
+ (.sidebar > .panel.navigation.resource > .search-bar):
+ (.sidebar > .panel.navigation.resource > .search-bar > input[type="search"]):
+ * UserInterface/Views/ScriptTimelineView.css:
+ (.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.script .item .subtitle):
+ * UserInterface/Views/TimelineSidebarPanel.css:
+ (.sidebar > .panel.navigation.timeline > .status-bar):
+ (.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
+ (.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording):
+ (.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:hover):
+ (.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording:hover):
+ (.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.forced):
+ (.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording.forced):
+ (.sidebar > .panel.navigation.timeline > .status-bar > .record-status):
+ (.sidebar > .panel.navigation.timeline > .title-bar):
+ (.sidebar > .panel.navigation.timeline > .title-bar.timelines):
+ (.sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
+ (.sidebar > .panel.navigation.timeline > .timelines-content):
+ (.sidebar > .panel.navigation.timeline > .timelines-content .close-button):
+ (.sidebar > .panel.navigation.timeline > .timelines-content li.item .icon):
+ (.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected .close-button):
+ (.sidebar > .panel.navigation.timeline > .timelines-content li.item:not(.selected):nth-child(even)):
+ (.sidebar > .panel.navigation.timeline > .timelines-content li.item:not(.selected):not(:first-child)):
+ (.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item):
+ (.sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item):
+ (.sidebar > .panel.navigation.timeline > .timelines-content .close-button:active):
+ (.sidebar > .panel.navigation.timeline > .empty-content-placeholder):
+ (.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content):
+ (.sidebar > .panel.navigation.timeline > .content > .stripe-background):
+ (.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content > .stripe-background):
+
+2014-02-24 Timothy Hatcher <[email protected]>
+
Give non-Mac platforms a default toolbar background so it isn't just white.
https://bugs.webkit.org/show_bug.cgi?id=129260
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css (164622 => 164623)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css 2014-02-25 02:59:18 UTC (rev 164622)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css 2014-02-25 03:00:59 UTC (rev 164623)
@@ -23,11 +23,11 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-.sidebar > .panel.debugger > .content {
+.sidebar > .panel.navigation.debugger > .content {
top: 22px;
}
-.sidebar > .panel.debugger > .navigation-bar {
+.sidebar > .panel.navigation.debugger > .navigation-bar {
position: absolute;
top: 0;
left: 0;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.css (164622 => 164623)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.css 2014-02-25 02:59:18 UTC (rev 164622)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.css 2014-02-25 03:00:59 UTC (rev 164623)
@@ -35,6 +35,6 @@
border-right: none;
}
-.sidebar > .panel.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.layout .item .subtitle {
+.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.layout .item .subtitle {
display: none;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.css (164622 => 164623)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.css 2014-02-25 02:59:18 UTC (rev 164622)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.css 2014-02-25 03:00:59 UTC (rev 164623)
@@ -32,6 +32,6 @@
border: none;
}
-.sidebar > .panel.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.network .item .subtitle {
+.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.network .item .subtitle {
display: none;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.css (164622 => 164623)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.css 2014-02-25 02:59:18 UTC (rev 164622)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.css 2014-02-25 03:00:59 UTC (rev 164623)
@@ -23,12 +23,12 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-.sidebar > .panel.resource > .content,
-.sidebar > .panel.resource > .empty-content-placeholder {
+.sidebar > .panel.navigation.resource > .content,
+.sidebar > .panel.navigation.resource > .empty-content-placeholder {
top: 21px;
}
-.sidebar > .panel.resource > .search-bar {
+.sidebar > .panel.navigation.resource > .search-bar {
position: absolute;
top: 0;
left: 0;
@@ -44,7 +44,7 @@
overflow: hidden;
}
-.sidebar > .panel.resource > .search-bar > input[type="search"] {
+.sidebar > .panel.navigation.resource > .search-bar > input[type="search"] {
display: -webkit-flex;
-webkit-flex: 1;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTimelineView.css (164622 => 164623)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTimelineView.css 2014-02-25 02:59:18 UTC (rev 164622)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTimelineView.css 2014-02-25 03:00:59 UTC (rev 164623)
@@ -35,6 +35,6 @@
border-right: none;
}
-.sidebar > .panel.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.script .item .subtitle {
+.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.script .item .subtitle {
display: none;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css (164622 => 164623)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css 2014-02-25 02:59:18 UTC (rev 164622)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css 2014-02-25 03:00:59 UTC (rev 164623)
@@ -23,19 +23,19 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-.sidebar > .panel.timeline > .status-bar {
+.sidebar > .panel.navigation.timeline > .status-bar {
position: absolute;
top: 0;
- left: 5px;
+ left: 0;
right: 0;
height: 22px;
border-bottom: 1px solid rgb(179, 179, 179);
}
-.sidebar > .panel.timeline > .status-bar > .record-glyph {
+.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph {
position: absolute;
top: 0;
- left: 0;
+ left: 5px;
width: 21px;
height: 21px;
padding: 0;
@@ -52,27 +52,27 @@
background-size: 21px 21px;
}
-.sidebar > .panel.timeline > .status-bar > .record-glyph.recording {
+.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording {
background-image: -webkit-image-set(url(../Images/Recording.png) 1x, url(../Images/[email protected]) 2x);
}
-.sidebar > .panel.timeline > .status-bar > .record-glyph:hover {
+.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:hover {
background-image: -webkit-image-set(url(../Images/RecordingHovered.png) 1x, url(../Images/[email protected]) 2x);
}
-.sidebar > .panel.timeline > .status-bar > .record-glyph.recording:hover {
+.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording:hover {
background-image: -webkit-image-set(url(../Images/RecordingStopped.png) 1x, url(../Images/[email protected]) 2x);
}
-.sidebar > .panel.timeline > .status-bar > .record-glyph.forced {
+.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.forced {
background-image: -webkit-image-set(url(../Images/RecordingStopped.png) 1x, url(../Images/[email protected]) 2x) !important;
}
-.sidebar > .panel.timeline > .status-bar > .record-glyph.recording.forced {
+.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording.forced {
background-image: -webkit-image-set(url(../Images/Recording.png) 1x, url(../Images/[email protected]) 2x) !important;
}
-.sidebar > .panel.timeline > .status-bar > .record-status {
+.sidebar > .panel.navigation.timeline > .status-bar > .record-status {
position: absolute;
top: 0;
right: 21px;
@@ -89,7 +89,7 @@
text-shadow: rgba(255, 255, 255, 0.5) 0 1px 0;
}
-.sidebar > .panel.timeline > .title-bar {
+.sidebar > .panel.navigation.timeline > .title-bar {
position: absolute;
left: 0;
right: 0;
@@ -116,17 +116,17 @@
overflow: hidden;
}
-.sidebar > .panel.timeline > .title-bar.timelines {
+.sidebar > .panel.navigation.timeline > .title-bar.timelines {
top: 22px;
}
-.sidebar > .panel.timeline > .title-bar.timeline-events {
+.sidebar > .panel.navigation.timeline > .title-bar.timeline-events {
height: 23px;
border-top: 1px solid rgb(179, 179, 179);
top: 152px;
}
-.sidebar > .panel.timeline > .timelines-content {
+.sidebar > .panel.navigation.timeline > .timelines-content {
position: absolute;
top: 44px;
height: 108px;
@@ -136,7 +136,7 @@
overflow: hidden;
}
-.sidebar > .panel.timeline > .timelines-content .close-button {
+.sidebar > .panel.navigation.timeline > .timelines-content .close-button {
margin-top: 2px;
width: 12px;
height: 12px;
@@ -146,49 +146,49 @@
visibility: hidden;
}
-.sidebar > .panel.timeline > .timelines-content li.item .icon {
+.sidebar > .panel.navigation.timeline > .timelines-content li.item .icon {
width: 24px;
height: 24px;
margin-top: 5px;
}
-.sidebar > .panel.timeline > .timelines-content li.item.selected .close-button {
+.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected .close-button {
visibility: visible;
}
-.sidebar > .panel.timeline > .timelines-content li.item:not(.selected):nth-child(even) {
+.sidebar > .panel.navigation.timeline > .timelines-content li.item:not(.selected):nth-child(even) {
background-color: rgba(0, 0, 0, 0.03);
background-clip: padding-box;
}
-.sidebar > .panel.timeline > .timelines-content li.item:not(.selected):not(:first-child) {
+.sidebar > .panel.navigation.timeline > .timelines-content li.item:not(.selected):not(:first-child) {
border-top: 1px solid rgba(0, 0, 0, 0.09);
}
-.sidebar > .panel.timeline > .timelines-content li.item.selected + li.item {
+.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item {
border-top-color: rgb(120, 139, 168);
}
-.sidebar > .panel.timeline > .timelines-content :focus li.item.selected + li.item {
+.sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item {
border-top-color: rgb(107, 130, 164);
}
-.sidebar > .panel.timeline > .timelines-content .close-button:active {
+.sidebar > .panel.navigation.timeline > .timelines-content .close-button:active {
opacity: 0.8;
}
-.sidebar > .panel.timeline > .content,
-.sidebar > .panel.timeline > .empty-content-placeholder {
+.sidebar > .panel.navigation.timeline > .content,
+.sidebar > .panel.navigation.timeline > .empty-content-placeholder {
top: 175px;
}
-.sidebar > .panel.timeline.timeline-content-view-showing > .content {
+.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content {
/* This hides the scrollbar. The view shows a scrollbar, we don't need two. */
padding-right: 16px;
right: -16px;
}
-.sidebar > .panel.timeline > .content > .stripe-background {
+.sidebar > .panel.navigation.timeline > .content > .stripe-background {
position: absolute;
top: 0;
left: 0;
@@ -202,6 +202,6 @@
display: none;
}
-.sidebar > .panel.timeline.timeline-content-view-showing > .content > .stripe-background {
+.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content > .stripe-background {
display: block;
}
