Title: [164643] trunk/LayoutTests
Revision
164643
Author
[email protected]
Date
2014-02-25 05:31:45 -0800 (Tue, 25 Feb 2014)

Log Message

Refactoring inline_spelling_markers.html to use asynchronous spellchecking
https://bugs.webkit.org/show_bug.cgi?id=127284

Reviewed by Ryosuke Niwa.

Use asynchronous text checking in inline-spelling-markers.html and
inline-spelling-markers-hidpi.html

Rename the test to inline-spelling-markers.html to match the naming convention.

* editing/spelling/inline-spelling-markers-expected.txt: Added.
Make cross platform text expectation by dumping spelling/grammar markers
instead of whole tree which in terms of spellchecking says nothing.

* editing/spelling/inline-spelling-markers.html: Added.
Remove unnecessary new lines from div elements so position of markers can be given from 0.
Activate text checking by adding a word separator so WebKit starts performing spell and grammar
checking. Selection change does not invoke grammar checking unless we start editing the input
element's content.

* platform/efl/editing/spelling/inline_spelling_markers-expected.png: Removed.
* platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Removed.
* platform/gtk/editing/spelling/inline_spelling_markers-expected.png: Removed.
* platform/gtk/editing/spelling/inline_spelling_markers-expected.txt: Removed.
* platform/mac/editing/spelling/inline_spelling_markers-expected.png: Removed.
* platform/mac/editing/spelling/inline_spelling_markers-expected.txt: Removed.
Those are not needed as pixel tests don't introduce anything special here.
Let's keep them in hidpi test only.

* editing/spelling/inline-spelling-markers-hidpi-expected.txt:
* editing/spelling/inline-spelling-markers-hidpi.html:
Apply changes from inline-spelling-markers.html

* platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png: Added.

* platform/efl/editing/spelling/inline-spelling-markers-hidpi-expected.png: Removed.
* platform/gtk/editing/spelling/inline-spelling-markers-hidpi-expected.png: Removed.
Remove wrong baselines due to missing grammar markers.

* platform/efl-wk2/TestExpectations:
* platform/gtk/TestExpectations:
Mark inline-spelling-markers.html and its hidpi version as failures
since EFL and GTK do not implement grammar checking.

* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:
Mark inline-spelling-markers.html and its hidpi version as failures
due to missing TextChecker::requestCheckingOfString() implementation.

Modified Paths

Added Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (164642 => 164643)


--- trunk/LayoutTests/ChangeLog	2014-02-25 12:44:42 UTC (rev 164642)
+++ trunk/LayoutTests/ChangeLog	2014-02-25 13:31:45 UTC (rev 164643)
@@ -1,3 +1,54 @@
+2014-02-25  Grzegorz Czajkowski  <[email protected]>
+
+        Refactoring inline_spelling_markers.html to use asynchronous spellchecking
+        https://bugs.webkit.org/show_bug.cgi?id=127284
+
+        Reviewed by Ryosuke Niwa.
+
+        Use asynchronous text checking in inline-spelling-markers.html and
+        inline-spelling-markers-hidpi.html
+
+        Rename the test to inline-spelling-markers.html to match the naming convention.
+
+        * editing/spelling/inline-spelling-markers-expected.txt: Added.
+        Make cross platform text expectation by dumping spelling/grammar markers
+        instead of whole tree which in terms of spellchecking says nothing.
+
+        * editing/spelling/inline-spelling-markers.html: Added.
+        Remove unnecessary new lines from div elements so position of markers can be given from 0.
+        Activate text checking by adding a word separator so WebKit starts performing spell and grammar
+        checking. Selection change does not invoke grammar checking unless we start editing the input
+        element's content.
+
+        * platform/efl/editing/spelling/inline_spelling_markers-expected.png: Removed.
+        * platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Removed.
+        * platform/gtk/editing/spelling/inline_spelling_markers-expected.png: Removed.
+        * platform/gtk/editing/spelling/inline_spelling_markers-expected.txt: Removed.
+        * platform/mac/editing/spelling/inline_spelling_markers-expected.png: Removed.
+        * platform/mac/editing/spelling/inline_spelling_markers-expected.txt: Removed.
+        Those are not needed as pixel tests don't introduce anything special here.
+        Let's keep them in hidpi test only.
+
+        * editing/spelling/inline-spelling-markers-hidpi-expected.txt:
+        * editing/spelling/inline-spelling-markers-hidpi.html:
+        Apply changes from inline-spelling-markers.html
+
+        * platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png: Added.
+
+        * platform/efl/editing/spelling/inline-spelling-markers-hidpi-expected.png: Removed.
+        * platform/gtk/editing/spelling/inline-spelling-markers-hidpi-expected.png: Removed.
+        Remove wrong baselines due to missing grammar markers.
+
+        * platform/efl-wk2/TestExpectations:
+        * platform/gtk/TestExpectations:
+        Mark inline-spelling-markers.html and its hidpi version as failures
+        since EFL and GTK do not implement grammar checking.
+
+        * platform/mac-wk2/TestExpectations:
+        * platform/win/TestExpectations:
+        Mark inline-spelling-markers.html and its hidpi version as failures
+        due to missing TextChecker::requestCheckingOfString() implementation.
+
 2014-02-25  Radu Stavila  <[email protected]>
 
         [CSS Regions] scrollIntoView for elements flowed into regions

Added: trunk/LayoutTests/editing/spelling/inline-spelling-markers-expected.txt (0 => 164643)


--- trunk/LayoutTests/editing/spelling/inline-spelling-markers-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/editing/spelling/inline-spelling-markers-expected.txt	2014-02-25 13:31:45 UTC (rev 164643)
@@ -0,0 +1,64 @@
+This tests the correct placement of inline spelling and grammar markers in the following text: 'the the adlj adaasj sdklj. there there'. Spelling markers should line up exactly under misspelled words in all cases.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+testLTR
+Verifies 'adlj'.
+PASS internals.hasSpellingMarker(8, 4) became true
+Verifies 'adaasj'.
+PASS internals.hasSpellingMarker(13, 6) became true
+Verifies 'sdklj'.
+PASS internals.hasSpellingMarker(20, 5) became true
+Verifies duplicated 'the'.
+PASS internals.hasGrammarMarker(4, 3) became true
+Verifies duplicated 'there'.
+PASS internals.hasGrammarMarker(33, 5) became true
+
+testRTL
+Verifies 'adlj'.
+PASS internals.hasSpellingMarker(8, 4) became true
+Verifies 'adaasj'.
+PASS internals.hasSpellingMarker(13, 6) became true
+Verifies 'sdklj'.
+PASS internals.hasSpellingMarker(20, 5) became true
+Verifies duplicated 'the'.
+PASS internals.hasGrammarMarker(4, 3) became true
+Verifies duplicated 'there'.
+PASS internals.hasGrammarMarker(33, 5) became true
+
+testLTREllipses
+Verifies 'adlj'.
+PASS internals.hasSpellingMarker(8, 4) became true
+Verifies 'adaasj'.
+PASS internals.hasSpellingMarker(13, 6) became true
+Verifies 'sdklj'.
+PASS internals.hasSpellingMarker(20, 5) became true
+Verifies duplicated 'the'.
+PASS internals.hasGrammarMarker(4, 3) became true
+Verifies duplicated 'there'.
+PASS internals.hasGrammarMarker(33, 5) became true
+
+testRTLEllipses
+Verifies 'adlj'.
+PASS internals.hasSpellingMarker(8, 4) became true
+Verifies 'adaasj'.
+PASS internals.hasSpellingMarker(13, 6) became true
+Verifies 'sdklj'.
+PASS internals.hasSpellingMarker(20, 5) became true
+Verifies duplicated 'the'.
+PASS internals.hasGrammarMarker(4, 3) became true
+Verifies duplicated 'there'.
+PASS internals.hasGrammarMarker(33, 5) became true
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+LTR
+the the adlj adaasj sdklj. there there 
+RTL
+the the adlj adaasj sdklj. there there 
+LTR (text-overflow:ellipses):
+the the adlj adaasj sdklj. there there 
+RTL (text-overflow:ellipses):
+the the adlj adaasj sdklj. there there 

Modified: trunk/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-expected.txt (164642 => 164643)


--- trunk/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-expected.txt	2014-02-25 12:44:42 UTC (rev 164642)
+++ trunk/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-expected.txt	2014-02-25 13:31:45 UTC (rev 164643)
@@ -1,11 +1,36 @@
-This tests the correct placement of inline spelling and grammar markers in text.
-Spelling markers should line up exactly under misspelled words in all cases.
+This tests the correct placement of inline spelling and grammar markers in the following text: 'the the adlj adaasj sdklj. there there'. Spelling markers should line up exactly under misspelled words in all cases.
 
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS internals.hasSpellingMarker(8, 4) became true
+PASS internals.hasSpellingMarker(13, 6) became true
+PASS internals.hasSpellingMarker(20, 5) became true
+PASS internals.hasGrammarMarker(4, 3) became true
+PASS internals.hasGrammarMarker(33, 5) became true
+PASS internals.hasSpellingMarker(8, 4) became true
+PASS internals.hasSpellingMarker(13, 6) became true
+PASS internals.hasSpellingMarker(20, 5) became true
+PASS internals.hasGrammarMarker(4, 3) became true
+PASS internals.hasGrammarMarker(33, 5) became true
+PASS internals.hasSpellingMarker(8, 4) became true
+PASS internals.hasSpellingMarker(13, 6) became true
+PASS internals.hasSpellingMarker(20, 5) became true
+PASS internals.hasGrammarMarker(4, 3) became true
+PASS internals.hasGrammarMarker(33, 5) became true
+PASS internals.hasSpellingMarker(8, 4) became true
+PASS internals.hasSpellingMarker(13, 6) became true
+PASS internals.hasSpellingMarker(20, 5) became true
+PASS internals.hasGrammarMarker(4, 3) became true
+PASS internals.hasGrammarMarker(33, 5) became true
+PASS successfullyParsed is true
+
+TEST COMPLETE
 LTR
-the the adlj adaasj sdklj. there there
+the the adlj adaasj sdklj. there there 
 RTL
-the the adlj adaasj sdklj. there there
+the the adlj adaasj sdklj. there there 
 LTR (text-overflow:ellipses):
-the the adlj adaasj sdklj. there there
+the the adlj adaasj sdklj. there there 
 RTL (text-overflow:ellipses):
-the the adlj adaasj sdklj. there there
+the the adlj adaasj sdklj. there there 

Modified: trunk/LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html (164642 => 164643)


--- trunk/LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html	2014-02-25 12:44:42 UTC (rev 164642)
+++ trunk/LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html	2014-02-25 13:31:45 UTC (rev 164643)
@@ -17,65 +17,96 @@
 .ellipses {
     text-overflow:ellipsis;
 }
-
 </style>
+</head>
 
+<body>
+<script src=""
+LTR
+<div id="testLTR" class="testDiv" contenteditable="true"></div>
+RTL
+<div id="testRTL" class="testDiv forcertl" contenteditable="true"></div>
+LTR (text-overflow:ellipses):
+<div id="testLTREllipses" class="testDiv ellipses" contenteditable="true"></div>
+RTL (text-overflow:ellipses):
+<div id="testRTLEllipses" class="testDiv forcertl ellipses" contenteditable="true"></div>
+
 <script>
-function moveCursorOverAllWords(divName, numWords) {
-    div = document.getElementById(divName);
+
+const incorrectPhrase = "the the adlj adaasj sdklj. there there";
+
+description("This tests the correct placement of inline spelling and grammar "
+    + "markers in the following text: "
+    + "'" + incorrectPhrase + "'. "
+    + "Spelling markers should line up exactly under misspelled words in all cases.");
+
+jsTestIsAsync = true;
+
+if (window.internals) {
+    internals.settings.setUnifiedTextCheckerEnabled(true);
+    internals.settings.setAsynchronousSpellCheckingEnabled(true);
+}
+
+function runTextCheckingTestFor(id)
+{
+    var div = document.getElementById(id);
     div.focus();
-    var selection = window.getSelection();
-    // Move to start of text
-    selection.modify("move", "backward", "line");
-    // Move cursor over all words so inline spellchecking is activated for all
-    for (var i = 0; i < 100; i++ ) {
-        selection.modify("move", "forward", "word");
-    }
-    // Remove focus from the element, since the word under the cursor won't have a misspelling marker.
-    div.blur();
+    document.execCommand("InsertText", false, incorrectPhrase);
+
+    // Add a word separator so that both spelling and grammar markers will appear.
+    document.execCommand("InsertText", false, " ");
+
+    verifyMarkers();
 }
 
-function startTest() {
-    if (!window.testRunner)
-        return;
-    testRunner.dumpAsText(true);
-    testRunner.waitUntilDone();
-    testRunner.setBackingScaleFactor(2, function () {
-        moveCursorOverAllWords('testLTR');
-        moveCursorOverAllWords('testRTL');
-        moveCursorOverAllWords('testLTREllipses');
-        moveCursorOverAllWords('testRTLEllipses');
-        testRunner.notifyDone();
+function verifyMarkers()
+{
+    if (!window.internals)
+        return done();
+
+    // Take care of spelling markers first.
+    shouldBecomeEqual('internals.hasSpellingMarker(8, 4)', 'true', function() { // Verifies 'adlj'.
+        shouldBecomeEqual('internals.hasSpellingMarker(13, 6)', 'true', function() { // Verifies 'adaasj'.
+            shouldBecomeEqual('internals.hasSpellingMarker(20, 5)', 'true', function() {  // Verifies 'sdklj'.
+                verifyGrammarMarkers();
+            });
+         });
     });
+
+    function verifyGrammarMarkers()
+    {
+        shouldBecomeEqual('internals.hasGrammarMarker(4, 3)', 'true', function() { // Verifies duplicated 'the'.
+            shouldBecomeEqual('internals.hasGrammarMarker(33, 5)', 'true', function() { // Verifies duplicated 'there'.
+                done();
+            });
+        });
+    }
 }
-</script>
-</head>
-<body _onload_="startTest()">
-<p id="explanation">
-This tests the correct placement of inline spelling and grammar markers in text.<br>
-Spelling markers should line up exactly under misspelled words in all cases.
-</p>
 
-LTR
-<div id="testLTR" class="testDiv" contenteditable="true">
-the the adlj adaasj sdklj. there there
-</div>
+var tests = [
+    function() { runTextCheckingTestFor('testLTR'); },
+    function() { runTextCheckingTestFor('testRTL'); },
+    function() { runTextCheckingTestFor('testLTREllipses'); },
+    function() { runTextCheckingTestFor('testRTLEllipses'); }
+];
 
-RTL
-<div id="testRTL" class="testDiv forcertl" contenteditable="true">
-the the adlj adaasj sdklj. there there
-</div>
+function done()
+{
+    var next = tests.shift();
+    if (next)
+        return window.setTimeout(next, 0);
 
+    finishJSTest();
+}
 
-LTR (text-overflow:ellipses):
-<div id="testLTREllipses" class="testDiv ellipses" contenteditable="true">
-the the adlj adaasj sdklj. there there
-</div>
+if (window.testRunner) {
+    testRunner.dumpAsText(true);
+    testRunner.setBackingScaleFactor(2, function () {
+        done();
+    });
+}
 
-RTL (text-overflow:ellipses):
-<div id="testRTLEllipses" class="testDiv forcertl ellipses" contenteditable="true">
-the the adlj adaasj sdklj. there there
-</div>
-
+</script>
+<script src=""
 </body>
 </html>

Added: trunk/LayoutTests/editing/spelling/inline-spelling-markers.html (0 => 164643)


--- trunk/LayoutTests/editing/spelling/inline-spelling-markers.html	                        (rev 0)
+++ trunk/LayoutTests/editing/spelling/inline-spelling-markers.html	2014-02-25 13:31:45 UTC (rev 164643)
@@ -0,0 +1,113 @@
+<html>
+<head>
+<style>
+.testDiv {
+    width: 200px;
+    height: 20px;
+    border: 1px solid black;
+    white-space: nowrap;
+    overflow: hidden;
+}
+
+.forcertl {
+    direction: rtl;
+    unicode-bidi: bidi-override;
+}
+
+.ellipses {
+    text-overflow:ellipsis;
+}
+</style>
+</head>
+
+<body>
+<script src=""
+LTR
+<div id="testLTR" class="testDiv" contenteditable="true"></div>
+RTL
+<div id="testRTL" class="testDiv forcertl" contenteditable="true"></div>
+LTR (text-overflow:ellipses):
+<div id="testLTREllipses" class="testDiv ellipses" contenteditable="true"></div>
+RTL (text-overflow:ellipses):
+<div id="testRTLEllipses" class="testDiv forcertl ellipses" contenteditable="true"></div>
+
+<script>
+
+const incorrectPhrase = "the the adlj adaasj sdklj. there there";
+
+description("This tests the correct placement of inline spelling and grammar "
+    + "markers in the following text: "
+    + "'" + incorrectPhrase + "'. "
+    + "Spelling markers should line up exactly under misspelled words in all cases.");
+
+jsTestIsAsync = true;
+
+if (window.internals) {
+    internals.settings.setUnifiedTextCheckerEnabled(true);
+    internals.settings.setAsynchronousSpellCheckingEnabled(true);
+}
+
+function runTextCheckingTestFor(id)
+{
+    var div = document.getElementById(id);
+    debug(div.id);
+
+    div.focus();
+    document.execCommand("InsertText", false, incorrectPhrase);
+
+    // Add a word separator so that both spelling and grammar markers will appear.
+    document.execCommand("InsertText", false, " ");
+
+    verifyMarkers();
+}
+
+function verifyMarkers()
+{
+    if (!window.internals)
+        return done();
+
+    // Take care of spelling markers first.
+    debug("Verifies 'adlj'.");
+    shouldBecomeEqual('internals.hasSpellingMarker(8, 4)', 'true', function() {
+        debug("Verifies 'adaasj'.");
+        shouldBecomeEqual('internals.hasSpellingMarker(13, 6)', 'true', function() {
+            debug("Verifies 'sdklj'.");
+            shouldBecomeEqual('internals.hasSpellingMarker(20, 5)', 'true', function() {
+                verifyGrammarMarkers();
+            });
+         });
+    });
+
+    function verifyGrammarMarkers()
+    {
+        debug("Verifies duplicated 'the'.");
+        shouldBecomeEqual('internals.hasGrammarMarker(4, 3)', 'true', function() {
+            debug("Verifies duplicated 'there'.");
+            shouldBecomeEqual('internals.hasGrammarMarker(33, 5)', 'true', function() {
+                debug("");
+                done();
+            });
+        });
+    }
+}
+
+var tests = [
+    function() { runTextCheckingTestFor('testLTR'); },
+    function() { runTextCheckingTestFor('testRTL'); },
+    function() { runTextCheckingTestFor('testLTREllipses'); },
+    function() { runTextCheckingTestFor('testRTLEllipses'); }
+];
+
+function done()
+{
+    var next = tests.shift();
+    if (next)
+        return window.setTimeout(next, 0);
+
+    finishJSTest();
+}
+done();
+</script>
+<script src=""
+</body>
+</html>

Deleted: trunk/LayoutTests/editing/spelling/inline_spelling_markers.html (164642 => 164643)


--- trunk/LayoutTests/editing/spelling/inline_spelling_markers.html	2014-02-25 12:44:42 UTC (rev 164642)
+++ trunk/LayoutTests/editing/spelling/inline_spelling_markers.html	2014-02-25 13:31:45 UTC (rev 164643)
@@ -1,75 +0,0 @@
-<html>
-<head>
-<style>
-.testDiv {
-    width: 200px;
-    height: 20px;
-    border: 1px solid black;
-    white-space: nowrap;
-    overflow: hidden;
-}
-
-.forcertl {
-    direction: rtl;
-    unicode-bidi: bidi-override;
-}
-
-.ellipses {
-    text-overflow:ellipsis;
-}
-
-</style>
-
-<script>
-function moveCursorOverAllWords(divName, numWords) {
-    div = document.getElementById(divName);
-    div.focus();
-    var selection = window.getSelection();
-    // Move to start of text
-    selection.modify("move", "backward", "line");
-    // Move cursor over all words so inline spellchecking is activated for all
-    for (var i = 0; i < 100; i++ ) {
-        selection.modify("move", "forward", "word");
-    }
-    // Remove focus from the element, since the word under the cursor won't have a misspelling marker.
-    div.blur();
-}
-
-function startTest() {
-    moveCursorOverAllWords('testLTR');
-    moveCursorOverAllWords('testRTL');
-    moveCursorOverAllWords('testLTREllipses');
-    moveCursorOverAllWords('testRTLEllipses');
-
-}
-</script>
-</head>
-<body _onload_="startTest()">
-<p id="explanation">
-This tests the correct placement of inline spelling and grammar markers in text.<br>
-Spelling markers should line up exactly under misspelled words in all cases.
-</p>
-
-LTR
-<div id="testLTR" class="testDiv" contenteditable="true">
-the the adlj adaasj sdklj. there there
-</div>
-
-RTL
-<div id="testRTL" class="testDiv forcertl" contenteditable="true">
-the the adlj adaasj sdklj. there there
-</div>
-
-
-LTR (text-overflow:ellipses):
-<div id="testLTREllipses" class="testDiv ellipses" contenteditable="true">
-the the adlj adaasj sdklj. there there
-</div>
-
-RTL (text-overflow:ellipses):
-<div id="testRTLEllipses" class="testDiv forcertl ellipses" contenteditable="true">
-the the adlj adaasj sdklj. there there
-</div>
-
-</body>
-</html>

Deleted: trunk/LayoutTests/platform/efl/editing/spelling/inline-spelling-markers-hidpi-expected.png


(Binary files differ)

Deleted: trunk/LayoutTests/platform/efl/editing/spelling/inline_spelling_markers-expected.png


(Binary files differ)

Deleted: trunk/LayoutTests/platform/efl/editing/spelling/inline_spelling_markers-expected.txt (164642 => 164643)


--- trunk/LayoutTests/platform/efl/editing/spelling/inline_spelling_markers-expected.txt	2014-02-25 12:44:42 UTC (rev 164642)
+++ trunk/LayoutTests/platform/efl/editing/spelling/inline_spelling_markers-expected.txt	2014-02-25 13:31:45 UTC (rev 164643)
@@ -1,39 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x584
-      RenderBlock {P} at (0,0) size 784x36
-        RenderText {#text} at (0,0) size 494x17
-          text run at (0,0) width 494: "This tests the correct placement of inline spelling and grammar markers in text."
-        RenderBR {BR} at (494,14) size 0x0
-        RenderText {#text} at (0,18) size 477x17
-          text run at (0,18) width 477: "Spelling markers should line up exactly under misspelled words in all cases."
-      RenderBlock (anonymous) at (0,52) size 784x18
-        RenderText {#text} at (0,0) size 31x17
-          text run at (0,0) width 31: "LTR"
-      RenderBlock (anonymous) at (0,92) size 784x18
-        RenderText {#text} at (0,0) size 31x17
-          text run at (0,0) width 31: "RTL"
-      RenderBlock (anonymous) at (0,132) size 784x18
-        RenderText {#text} at (0,0) size 184x17
-          text run at (0,0) width 184: "LTR (text-overflow:ellipses):"
-      RenderBlock (anonymous) at (0,172) size 784x18
-        RenderText {#text} at (0,0) size 184x17
-          text run at (0,0) width 184: "RTL (text-overflow:ellipses):"
-layer at (8,78) size 202x22 clip at (9,79) size 200x20 scrollWidth 221
-  RenderBlock {DIV} at (0,70) size 202x22 [border: (1px solid #000000)]
-    RenderText {#text} at (1,1) size 220x17
-      text run at (1,1) width 220: "the the adlj adaasj sdklj. there there"
-layer at (8,118) size 202x22 clip at (9,119) size 200x20 scrollX 20 scrollWidth 220
-  RenderBlock {DIV} at (0,110) size 202x22 [border: (1px solid #000000)]
-    RenderText {#text} at (-19,1) size 220x17
-      text run at (-19,1) width 220 RTL override: "the the adlj adaasj sdklj. there there"
-layer at (8,158) size 202x22 clip at (9,159) size 200x20 scrollWidth 221
-  RenderBlock {DIV} at (0,150) size 202x22 [border: (1px solid #000000)]
-    RenderText {#text} at (1,1) size 220x17
-      text run at (1,1) width 220: "the the adlj adaasj sdklj. there there"
-layer at (8,198) size 202x22 clip at (9,199) size 200x20 scrollX 20 scrollWidth 220
-  RenderBlock {DIV} at (0,190) size 202x22 [border: (1px solid #000000)]
-    RenderText {#text} at (-19,1) size 220x17
-      text run at (-19,1) width 220 RTL override: "the the adlj adaasj sdklj. there there"

Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (164642 => 164643)


--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2014-02-25 12:44:42 UTC (rev 164642)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2014-02-25 13:31:45 UTC (rev 164643)
@@ -313,6 +313,8 @@
 Bug(EFL) editing/spelling/grammar-markers.html [ Failure ]
 Bug(EFL) editing/spelling/grammar-markers-hidpi.html [ Failure ]
 Bug(EFL) editing/spelling/grammar-paste.html [ Failure ]
+Bug(EFL) editing/spelling/inline-spelling-markers.html [ Failure ]
+Bug(EFL) editing/spelling/inline-spelling-markers-hidpi.html [ Failure ]
 Bug(EFL) editing/spelling/markers.html [ Failure ]
 
 # EFL's text checker doesn't support the text replacement feature.

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (164642 => 164643)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2014-02-25 12:44:42 UTC (rev 164642)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2014-02-25 13:31:45 UTC (rev 164643)
@@ -1136,6 +1136,8 @@
 Bug(GTK) editing/spelling/grammar-markers.html [ Skip ]
 Bug(GTK) editing/spelling/grammar-markers-hidpi.html [ Skip ]
 Bug(GTK) editing/spelling/grammar-paste.html [ Skip ]
+Bug(GTK) editing/spelling/inline-spelling-markers.html [ Skip ]
+Bug(GTK) editing/spelling/inline-spelling-markers-hidpi.html [ Skip ]
 Bug(GTK) editing/spelling/markers.html [ Skip ]
 
 # Missing asynchronous spellchecking implementation.

Deleted: trunk/LayoutTests/platform/gtk/editing/spelling/inline-spelling-markers-hidpi-expected.png


(Binary files differ)

Deleted: trunk/LayoutTests/platform/gtk/editing/spelling/inline_spelling_markers-expected.png


(Binary files differ)

Deleted: trunk/LayoutTests/platform/gtk/editing/spelling/inline_spelling_markers-expected.txt (164642 => 164643)


--- trunk/LayoutTests/platform/gtk/editing/spelling/inline_spelling_markers-expected.txt	2014-02-25 12:44:42 UTC (rev 164642)
+++ trunk/LayoutTests/platform/gtk/editing/spelling/inline_spelling_markers-expected.txt	2014-02-25 13:31:45 UTC (rev 164643)
@@ -1,39 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x584
-      RenderBlock {P} at (0,0) size 784x34
-        RenderText {#text} at (0,0) size 494x17
-          text run at (0,0) width 494: "This tests the correct placement of inline spelling and grammar markers in text."
-        RenderBR {BR} at (494,14) size 0x0
-        RenderText {#text} at (0,17) size 477x17
-          text run at (0,17) width 477: "Spelling markers should line up exactly under misspelled words in all cases."
-      RenderBlock (anonymous) at (0,50) size 784x17
-        RenderText {#text} at (0,0) size 31x17
-          text run at (0,0) width 31: "LTR"
-      RenderBlock (anonymous) at (0,89) size 784x17
-        RenderText {#text} at (0,0) size 31x17
-          text run at (0,0) width 31: "RTL"
-      RenderBlock (anonymous) at (0,128) size 784x17
-        RenderText {#text} at (0,0) size 184x17
-          text run at (0,0) width 184: "LTR (text-overflow:ellipses):"
-      RenderBlock (anonymous) at (0,167) size 784x17
-        RenderText {#text} at (0,0) size 184x17
-          text run at (0,0) width 184: "RTL (text-overflow:ellipses):"
-layer at (8,75) size 202x22 clip at (9,76) size 200x20 scrollWidth 221
-  RenderBlock {DIV} at (0,67) size 202x22 [border: (1px solid #000000)]
-    RenderText {#text} at (1,1) size 220x17
-      text run at (1,1) width 220: "the the adlj adaasj sdklj. there there"
-layer at (8,114) size 202x22 clip at (9,115) size 200x20 scrollX 20 scrollWidth 220
-  RenderBlock {DIV} at (0,106) size 202x22 [border: (1px solid #000000)]
-    RenderText {#text} at (-19,1) size 220x17
-      text run at (-19,1) width 220 RTL override: "the the adlj adaasj sdklj. there there"
-layer at (8,153) size 202x22 clip at (9,154) size 200x20 scrollWidth 221
-  RenderBlock {DIV} at (0,145) size 202x22 [border: (1px solid #000000)]
-    RenderText {#text} at (1,1) size 220x17
-      text run at (1,1) width 220: "the the adlj adaasj sdklj. there there"
-layer at (8,192) size 202x22 clip at (9,193) size 200x20 scrollX 20 scrollWidth 220
-  RenderBlock {DIV} at (0,184) size 202x22 [border: (1px solid #000000)]
-    RenderText {#text} at (-19,1) size 220x17
-      text run at (-19,1) width 220 RTL override: "the the adlj adaasj sdklj. there there"

Added: trunk/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png


(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png ___________________________________________________________________

Added: svn:mime-type

Deleted: trunk/LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.png


(Binary files differ)

Deleted: trunk/LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.txt (164642 => 164643)


--- trunk/LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.txt	2014-02-25 12:44:42 UTC (rev 164642)
+++ trunk/LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.txt	2014-02-25 13:31:45 UTC (rev 164643)
@@ -1,39 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x584
-      RenderBlock {P} at (0,0) size 784x36
-        RenderText {#text} at (0,0) size 494x18
-          text run at (0,0) width 494: "This tests the correct placement of inline spelling and grammar markers in text."
-        RenderBR {BR} at (494,14) size 0x0
-        RenderText {#text} at (0,18) size 477x18
-          text run at (0,18) width 477: "Spelling markers should line up exactly under misspelled words in all cases."
-      RenderBlock (anonymous) at (0,52) size 784x18
-        RenderText {#text} at (0,0) size 31x18
-          text run at (0,0) width 31: "LTR"
-      RenderBlock (anonymous) at (0,92) size 784x18
-        RenderText {#text} at (0,0) size 31x18
-          text run at (0,0) width 31: "RTL"
-      RenderBlock (anonymous) at (0,132) size 784x18
-        RenderText {#text} at (0,0) size 184x18
-          text run at (0,0) width 184: "LTR (text-overflow:ellipses):"
-      RenderBlock (anonymous) at (0,172) size 784x18
-        RenderText {#text} at (0,0) size 184x18
-          text run at (0,0) width 184: "RTL (text-overflow:ellipses):"
-layer at (8,78) size 202x22 clip at (9,79) size 200x20 scrollWidth 221
-  RenderBlock {DIV} at (0,70) size 202x22 [border: (1px solid #000000)]
-    RenderText {#text} at (1,1) size 220x18
-      text run at (1,1) width 220: "the the adlj adaasj sdklj. there there"
-layer at (8,118) size 202x22 clip at (9,119) size 200x20 scrollX 20 scrollWidth 220
-  RenderBlock {DIV} at (0,110) size 202x22 [border: (1px solid #000000)]
-    RenderText {#text} at (-19,1) size 220x18
-      text run at (-19,1) width 220 RTL override: "the the adlj adaasj sdklj. there there"
-layer at (8,158) size 202x22 clip at (9,159) size 200x20 scrollWidth 221
-  RenderBlock {DIV} at (0,150) size 202x22 [border: (1px solid #000000)]
-    RenderText {#text} at (1,1) size 220x18
-      text run at (1,1) width 220: "the the adlj adaasj sdklj. there there"
-layer at (8,198) size 202x22 clip at (9,199) size 200x20 scrollX 20 scrollWidth 220
-  RenderBlock {DIV} at (0,190) size 202x22 [border: (1px solid #000000)]
-    RenderText {#text} at (-19,1) size 220x18
-      text run at (-19,1) width 220 RTL override: "the the adlj adaasj sdklj. there there"

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (164642 => 164643)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2014-02-25 12:44:42 UTC (rev 164642)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2014-02-25 13:31:45 UTC (rev 164643)
@@ -373,6 +373,8 @@
 editing/spelling/grammar-markers.html
 editing/spelling/grammar-paste.html
 editing/spelling/grammar-markers-hidpi.html
+editing/spelling/inline-spelling-markers.html
+editing/spelling/inline-spelling-markers-hidpi.html
 editing/spelling/spellcheck-async-mutation.html
 editing/spelling/spellcheck-async-remove-frame.html
 editing/spelling/spellcheck-async.html

Modified: trunk/LayoutTests/platform/win/TestExpectations (164642 => 164643)


--- trunk/LayoutTests/platform/win/TestExpectations	2014-02-25 12:44:42 UTC (rev 164642)
+++ trunk/LayoutTests/platform/win/TestExpectations	2014-02-25 13:31:45 UTC (rev 164643)
@@ -1063,6 +1063,8 @@
 editing/spelling/grammar.html
 
 # Needs grammar checking.
+editing/spelling/inline-spelling-markers.html [ Failure ]
+editing/spelling/inline-spelling-markers-hidpi.html [ Failure ]
 editing/spelling/markers.html
 
 # EditorClient::requestCheckingOfString() is not implemented
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to