Diff
Modified: trunk/Source/WebCore/ChangeLog (164669 => 164670)
--- trunk/Source/WebCore/ChangeLog 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebCore/ChangeLog 2014-02-25 21:35:27 UTC (rev 164670)
@@ -1,3 +1,18 @@
+2014-02-25 Anders Carlsson <[email protected]>
+
+ Get rid of VisitedLinkStrategy
+ https://bugs.webkit.org/show_bug.cgi?id=129324
+
+ Reviewed by Dan Bernstein.
+
+ * GNUmakefile.list.am:
+ * WebCore.vcxproj/WebCore.vcxproj:
+ * WebCore.vcxproj/WebCore.vcxproj.filters:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/PlatformStrategies.h:
+ (WebCore::PlatformStrategies::PlatformStrategies):
+ * platform/VisitedLinkStrategy.h: Removed.
+
2014-02-25 Alexey Proskuryakov <[email protected]>
Rolling out http://trac.webkit.org/changeset/164611, because it broke
Modified: trunk/Source/WebCore/GNUmakefile.list.am (164669 => 164670)
--- trunk/Source/WebCore/GNUmakefile.list.am 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebCore/GNUmakefile.list.am 2014-02-25 21:35:27 UTC (rev 164670)
@@ -6066,7 +6066,6 @@
Source/WebCore/platform/UUID.cpp \
Source/WebCore/platform/UUID.h \
Source/WebCore/platform/ValueToString.h \
- Source/WebCore/platform/VisitedLinkStrategy.h \
Source/WebCore/platform/Widget.cpp \
Source/WebCore/platform/Widget.h \
Source/WebCore/platform/WindowsKeyboardCodes.h
Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (164669 => 164670)
--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-02-25 21:35:27 UTC (rev 164670)
@@ -18996,7 +18996,6 @@
<ClInclude Include="..\platform\TreeShared.h" />
<ClInclude Include="..\platform\UserActivity.h" />
<ClInclude Include="..\platform\UUID.h" />
- <ClInclude Include="..\platform\VisitedLinkStrategy.h" />
<ClInclude Include="..\platform\Widget.h" />
<ClInclude Include="..\platform\win\BitmapInfo.h" />
<ClInclude Include="..\platform\win\BString.h" />
Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters (164669 => 164670)
--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2014-02-25 21:35:27 UTC (rev 164670)
@@ -12856,9 +12856,6 @@
<ClInclude Include="..\loader\cache\CachedRawResourceClient.h">
<Filter>loader\cache</Filter>
</ClInclude>
- <ClInclude Include="..\platform\VisitedLinkStrategy.h">
- <Filter>platform</Filter>
- </ClInclude>
<ClInclude Include="..\platform\graphics\AudioTrackPrivate.h">
<Filter>html\track</Filter>
</ClInclude>
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (164669 => 164670)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-02-25 21:35:27 UTC (rev 164670)
@@ -1821,7 +1821,6 @@
514C767D0CE923A1007EF3CD /* ResourceRequestBase.h in Headers */ = {isa = PBXBuildFile; fileRef = 514C76680CE923A1007EF3CD /* ResourceRequestBase.h */; settings = {ATTRIBUTES = (Private, ); }; };
514C767E0CE923A1007EF3CD /* ResourceResponseBase.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 514C76690CE923A1007EF3CD /* ResourceResponseBase.cpp */; };
514C767F0CE923A1007EF3CD /* ResourceResponseBase.h in Headers */ = {isa = PBXBuildFile; fileRef = 514C766A0CE923A1007EF3CD /* ResourceResponseBase.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 515788C11207852C00A37C4A /* VisitedLinkStrategy.h in Headers */ = {isa = PBXBuildFile; fileRef = 515788C01207852C00A37C4A /* VisitedLinkStrategy.h */; settings = {ATTRIBUTES = (Private, ); }; };
5160300B0CC4251200C8AC25 /* FileSystemPOSIX.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5160300A0CC4251200C8AC25 /* FileSystemPOSIX.cpp */; };
5160306C0CC4362300C8AC25 /* FileSystemCF.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5160306B0CC4362300C8AC25 /* FileSystemCF.cpp */; };
5160F4980B0AA75F00C1D2AF /* HistoryItemMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5160F4970B0AA75F00C1D2AF /* HistoryItemMac.mm */; };
@@ -8709,7 +8708,6 @@
514C76680CE923A1007EF3CD /* ResourceRequestBase.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ResourceRequestBase.h; sourceTree = "<group>"; };
514C76690CE923A1007EF3CD /* ResourceResponseBase.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ResourceResponseBase.cpp; sourceTree = "<group>"; };
514C766A0CE923A1007EF3CD /* ResourceResponseBase.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ResourceResponseBase.h; sourceTree = "<group>"; };
- 515788C01207852C00A37C4A /* VisitedLinkStrategy.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = VisitedLinkStrategy.h; sourceTree = "<group>"; };
5160300A0CC4251200C8AC25 /* FileSystemPOSIX.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = FileSystemPOSIX.cpp; sourceTree = "<group>"; };
5160306B0CC4362300C8AC25 /* FileSystemCF.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = FileSystemCF.cpp; sourceTree = "<group>"; };
5160F4970B0AA75F00C1D2AF /* HistoryItemMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = HistoryItemMac.mm; path = mac/HistoryItemMac.mm; sourceTree = "<group>"; };
@@ -20827,7 +20825,6 @@
2E3BBF051162DA1100B9409A /* UUID.cpp */,
2E3BBF061162DA1100B9409A /* UUID.h */,
9A1142031832D134000BB8AD /* ValueToString.h */,
- 515788C01207852C00A37C4A /* VisitedLinkStrategy.h */,
9380F47109A11AB4001FDB34 /* Widget.cpp */,
9380F47209A11AB4001FDB34 /* Widget.h */,
E1E1BEFF115FF6FB006F52CA /* WindowsKeyboardCodes.h */,
@@ -25763,7 +25760,6 @@
93309E1E099E64920056E581 /* VisibleUnits.h in Headers */,
1ABA80001897341200DCE9D6 /* VisitedLinkProvider.h in Headers */,
419BC2DF1685329900D64D6D /* VisitedLinkState.h in Headers */,
- 515788C11207852C00A37C4A /* VisitedLinkStrategy.h in Headers */,
E44613B60CD6344E00FADA75 /* VoidCallback.h in Headers */,
BE20507A18A4586B0080647E /* VTTCue.h in Headers */,
A14832B0187F618D00DA63A6 /* WAKAppKitStubs.h in Headers */,
Modified: trunk/Source/WebCore/platform/PlatformStrategies.h (164669 => 164670)
--- trunk/Source/WebCore/platform/PlatformStrategies.h 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebCore/platform/PlatformStrategies.h 2014-02-25 21:35:27 UTC (rev 164670)
@@ -35,7 +35,6 @@
class PluginStrategy;
class SharedWorkerStrategy;
class StorageStrategy;
-class VisitedLinkStrategy;
class PlatformStrategies {
public:
@@ -81,13 +80,6 @@
return m_sharedWorkerStrategy;
}
- VisitedLinkStrategy* visitedLinkStrategy()
- {
- if (!m_visitedLinkStrategy)
- m_visitedLinkStrategy = createVisitedLinkStrategy();
- return m_visitedLinkStrategy;
- }
-
StorageStrategy* storageStrategy()
{
if (!m_storageStrategy)
@@ -104,7 +96,6 @@
, m_pluginStrategy(0)
, m_sharedWorkerStrategy(0)
, m_storageStrategy(0)
- , m_visitedLinkStrategy(0)
{
}
@@ -120,7 +111,6 @@
virtual PluginStrategy* createPluginStrategy() = 0;
virtual SharedWorkerStrategy* createSharedWorkerStrategy() = 0;
virtual StorageStrategy* createStorageStrategy() = 0;
- virtual VisitedLinkStrategy* createVisitedLinkStrategy() = 0;
CookiesStrategy* m_cookiesStrategy;
DatabaseStrategy* m_databaseStrategy;
@@ -129,7 +119,6 @@
PluginStrategy* m_pluginStrategy;
SharedWorkerStrategy* m_sharedWorkerStrategy;
StorageStrategy* m_storageStrategy;
- VisitedLinkStrategy* m_visitedLinkStrategy;
};
PlatformStrategies* platformStrategies();
Deleted: trunk/Source/WebCore/platform/VisitedLinkStrategy.h (164669 => 164670)
--- trunk/Source/WebCore/platform/VisitedLinkStrategy.h 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebCore/platform/VisitedLinkStrategy.h 2014-02-25 21:35:27 UTC (rev 164670)
@@ -1,48 +0,0 @@
-/*
- * Copyright (C) 2010 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef VisitedLinkStrategy_h
-#define VisitedLinkStrategy_h
-
-namespace WebCore {
-
-typedef uint64_t LinkHash;
-class Page;
-class URL;
-
-class VisitedLinkStrategy {
-public:
- virtual bool isLinkVisited(Page*, LinkHash, const URL& baseURL, const AtomicString& attributeURL) = 0;
- virtual void addVisitedLink(Page*, LinkHash) = 0;
-
-protected:
- virtual ~VisitedLinkStrategy()
- {
- }
-};
-
-} // namespace WebCore
-
-#endif // VisitedLinkStrategy_h
Modified: trunk/Source/WebKit/efl/ChangeLog (164669 => 164670)
--- trunk/Source/WebKit/efl/ChangeLog 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebKit/efl/ChangeLog 2014-02-25 21:35:27 UTC (rev 164670)
@@ -1,3 +1,14 @@
+2014-02-25 Anders Carlsson <[email protected]>
+
+ Get rid of VisitedLinkStrategy
+ https://bugs.webkit.org/show_bug.cgi?id=129324
+
+ Reviewed by Dan Bernstein.
+
+ * WebCoreSupport/PlatformStrategiesEfl.cpp:
+ (PlatformStrategiesEfl::getPluginInfo):
+ * WebCoreSupport/PlatformStrategiesEfl.h:
+
2014-02-24 Renata Hodovan <[email protected]>
Get rid of the unused 'immediate' parameters from repaint related functions
Modified: trunk/Source/WebKit/efl/WebCoreSupport/PlatformStrategiesEfl.cpp (164669 => 164670)
--- trunk/Source/WebKit/efl/WebCoreSupport/PlatformStrategiesEfl.cpp 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebKit/efl/WebCoreSupport/PlatformStrategiesEfl.cpp 2014-02-25 21:35:27 UTC (rev 164670)
@@ -76,11 +76,6 @@
return this;
}
-VisitedLinkStrategy* PlatformStrategiesEfl::createVisitedLinkStrategy()
-{
- return this;
-}
-
StorageStrategy* PlatformStrategiesEfl::createStorageStrategy()
{
return this;
@@ -156,14 +151,3 @@
UNUSED_PARAM(outPlugins);
#endif
}
-
-// VisitedLinkStrategy
-bool PlatformStrategiesEfl::isLinkVisited(Page* page, LinkHash hash, const URL&, const AtomicString&)
-{
- return page->group().isLinkVisited(hash);
-}
-
-void PlatformStrategiesEfl::addVisitedLink(Page* page, LinkHash hash)
-{
- page->group().addVisitedLinkHash(hash);
-}
Modified: trunk/Source/WebKit/efl/WebCoreSupport/PlatformStrategiesEfl.h (164669 => 164670)
--- trunk/Source/WebKit/efl/WebCoreSupport/PlatformStrategiesEfl.h 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebKit/efl/WebCoreSupport/PlatformStrategiesEfl.h 2014-02-25 21:35:27 UTC (rev 164670)
@@ -28,9 +28,8 @@
#include "PluginStrategy.h"
#include "SharedWorkerStrategy.h"
#include "StorageStrategy.h"
-#include "VisitedLinkStrategy.h"
-class PlatformStrategiesEfl : public WebCore::PlatformStrategies, private WebCore::CookiesStrategy, private WebCore::DatabaseStrategy, private WebCore::LoaderStrategy, private WebCore::PluginStrategy, private WebCore::SharedWorkerStrategy, private WebCore::StorageStrategy, private WebCore::VisitedLinkStrategy {
+class PlatformStrategiesEfl : public WebCore::PlatformStrategies, private WebCore::CookiesStrategy, private WebCore::DatabaseStrategy, private WebCore::LoaderStrategy, private WebCore::PluginStrategy, private WebCore::SharedWorkerStrategy, private WebCore::StorageStrategy {
public:
static void initialize();
@@ -45,7 +44,6 @@
virtual WebCore::PluginStrategy* createPluginStrategy();
virtual WebCore::SharedWorkerStrategy* createSharedWorkerStrategy();
virtual WebCore::StorageStrategy* createStorageStrategy();
- virtual WebCore::VisitedLinkStrategy* createVisitedLinkStrategy();
// WebCore::CookiesStrategy
virtual String cookiesForDOM(const WebCore::NetworkStorageSession&, const WebCore::URL& firstParty, const WebCore::URL&);
@@ -61,10 +59,6 @@
// WebCore::PluginStrategy
virtual void refreshPlugins();
virtual void getPluginInfo(const WebCore::Page*, Vector<WebCore::PluginInfo>&);
-
- // WebCore::VisitedLinkStrategy
- virtual bool isLinkVisited(WebCore::Page*, WebCore::LinkHash, const WebCore::URL& baseURL, const WTF::AtomicString& attributeURL);
- virtual void addVisitedLink(WebCore::Page*, WebCore::LinkHash);
};
#endif // PlatformStrategiesEfl_h
Modified: trunk/Source/WebKit/gtk/ChangeLog (164669 => 164670)
--- trunk/Source/WebKit/gtk/ChangeLog 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebKit/gtk/ChangeLog 2014-02-25 21:35:27 UTC (rev 164670)
@@ -1,3 +1,14 @@
+2014-02-25 Anders Carlsson <[email protected]>
+
+ Get rid of VisitedLinkStrategy
+ https://bugs.webkit.org/show_bug.cgi?id=129324
+
+ Reviewed by Dan Bernstein.
+
+ * WebCoreSupport/PlatformStrategiesGtk.cpp:
+ (PlatformStrategiesGtk::getPluginInfo):
+ * WebCoreSupport/PlatformStrategiesGtk.h:
+
2014-02-24 Carlos Garcia Campos <[email protected]>
[GTK] Mark view source mode methods as deprecated
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp (164669 => 164670)
--- trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp 2014-02-25 21:35:27 UTC (rev 164670)
@@ -75,11 +75,6 @@
return this;
}
-VisitedLinkStrategy* PlatformStrategiesGtk::createVisitedLinkStrategy()
-{
- return this;
-}
-
// CookiesStrategy
String PlatformStrategiesGtk::cookiesForDOM(const NetworkStorageSession& session, const URL& firstParty, const URL& url)
{
@@ -143,14 +138,3 @@
outPlugins.append(pluginInfo);
}
}
-
-// VisitedLinkStrategy
-bool PlatformStrategiesGtk::isLinkVisited(Page* page, LinkHash hash, const URL&, const AtomicString&)
-{
- return page->group().isLinkVisited(hash);
-}
-
-void PlatformStrategiesGtk::addVisitedLink(Page* page, LinkHash hash)
-{
- page->group().addVisitedLinkHash(hash);
-}
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.h (164669 => 164670)
--- trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.h 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.h 2014-02-25 21:35:27 UTC (rev 164670)
@@ -27,10 +27,9 @@
#include "PluginStrategy.h"
#include "SharedWorkerStrategy.h"
#include "StorageStrategy.h"
-#include "VisitedLinkStrategy.h"
#include <wtf/NeverDestroyed.h>
-class PlatformStrategiesGtk : public WebCore::PlatformStrategies, private WebCore::CookiesStrategy, private WebCore::DatabaseStrategy, private WebCore::LoaderStrategy, private WebCore::PluginStrategy, private WebCore::SharedWorkerStrategy, private WebCore::StorageStrategy, private WebCore::VisitedLinkStrategy {
+class PlatformStrategiesGtk : public WebCore::PlatformStrategies, private WebCore::CookiesStrategy, private WebCore::DatabaseStrategy, private WebCore::LoaderStrategy, private WebCore::PluginStrategy, private WebCore::SharedWorkerStrategy, private WebCore::StorageStrategy {
public:
static void initialize();
@@ -45,7 +44,6 @@
virtual WebCore::PluginStrategy* createPluginStrategy();
virtual WebCore::SharedWorkerStrategy* createSharedWorkerStrategy();
virtual WebCore::StorageStrategy* createStorageStrategy();
- virtual WebCore::VisitedLinkStrategy* createVisitedLinkStrategy();
// WebCore::CookiesStrategy
virtual String cookiesForDOM(const WebCore::NetworkStorageSession&, const WebCore::URL& firstParty, const WebCore::URL&);
@@ -62,10 +60,6 @@
virtual void refreshPlugins();
virtual void getPluginInfo(const WebCore::Page*, Vector<WebCore::PluginInfo>&);
- // WebCore::VisitedLinkStrategy
- virtual bool isLinkVisited(WebCore::Page*, WebCore::LinkHash, const WebCore::URL& baseURL, const WTF::AtomicString& attributeURL);
- virtual void addVisitedLink(WebCore::Page*, WebCore::LinkHash);
-
friend class NeverDestroyed<PlatformStrategiesGtk>;
};
Modified: trunk/Source/WebKit/mac/ChangeLog (164669 => 164670)
--- trunk/Source/WebKit/mac/ChangeLog 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-02-25 21:35:27 UTC (rev 164670)
@@ -1,3 +1,13 @@
+2014-02-25 Anders Carlsson <[email protected]>
+
+ Get rid of VisitedLinkStrategy
+ https://bugs.webkit.org/show_bug.cgi?id=129324
+
+ Reviewed by Dan Bernstein.
+
+ * WebCoreSupport/WebPlatformStrategies.h:
+ * WebCoreSupport/WebPlatformStrategies.mm:
+
2014-02-25 Sergio Villar Senin <[email protected]>
[CSS Grid Layout] Add ENABLE flag
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.h (164669 => 164670)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.h 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.h 2014-02-25 21:35:27 UTC (rev 164670)
@@ -34,12 +34,11 @@
#include <WebCore/PluginStrategy.h>
#include <WebCore/SharedWorkerStrategy.h>
#include <WebCore/StorageStrategy.h>
-#include <WebCore/VisitedLinkStrategy.h>
struct PasteboardImage;
struct PasteboardWebContent;
-class WebPlatformStrategies : public WebCore::PlatformStrategies, private WebCore::CookiesStrategy, private WebCore::DatabaseStrategy, private WebCore::LoaderStrategy, private WebCore::PasteboardStrategy, private WebCore::PluginStrategy, private WebCore::SharedWorkerStrategy, private WebCore::StorageStrategy, private WebCore::VisitedLinkStrategy {
+class WebPlatformStrategies : public WebCore::PlatformStrategies, private WebCore::CookiesStrategy, private WebCore::DatabaseStrategy, private WebCore::LoaderStrategy, private WebCore::PasteboardStrategy, private WebCore::PluginStrategy, private WebCore::SharedWorkerStrategy, private WebCore::StorageStrategy {
public:
static void initializeIfNecessary();
@@ -54,7 +53,6 @@
virtual WebCore::PluginStrategy* createPluginStrategy() override;
virtual WebCore::SharedWorkerStrategy* createSharedWorkerStrategy() override;
virtual WebCore::StorageStrategy* createStorageStrategy() override;
- virtual WebCore::VisitedLinkStrategy* createVisitedLinkStrategy() override;
// WebCore::CookiesStrategy
virtual String cookiesForDOM(const WebCore::NetworkStorageSession&, const WebCore::URL& firstParty, const WebCore::URL&) override;
@@ -77,10 +75,6 @@
// WebCore::LoaderStrategy
// - Using default implementation.
- // WebCore::VisitedLinkStrategy
- virtual bool isLinkVisited(WebCore::Page*, WebCore::LinkHash, const WebCore::URL& baseURL, const WTF::AtomicString& attributeURL) override;
- virtual void addVisitedLink(WebCore::Page*, WebCore::LinkHash) override;
-
// WebCore::PasteboardStrategy
#if PLATFORM(IOS)
virtual void writeToPasteboard(const WebCore::PasteboardWebContent&) override;
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm (164669 => 164670)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm 2014-02-25 21:35:27 UTC (rev 164670)
@@ -89,11 +89,6 @@
return this;
}
-VisitedLinkStrategy* WebPlatformStrategies::createVisitedLinkStrategy()
-{
- return this;
-}
-
String WebPlatformStrategies::cookiesForDOM(const NetworkStorageSession& session, const URL& firstParty, const URL& url)
{
return WebCore::cookiesForDOM(session, firstParty, url);
@@ -147,16 +142,6 @@
END_BLOCK_OBJC_EXCEPTIONS;
}
-bool WebPlatformStrategies::isLinkVisited(Page* page, LinkHash hash, const URL&, const AtomicString&)
-{
- return page->group().isLinkVisited(hash);
-}
-
-void WebPlatformStrategies::addVisitedLink(Page* page, LinkHash hash)
-{
- return page->group().addVisitedLinkHash(hash);
-}
-
void WebPlatformStrategies::getTypes(Vector<String>& types, const String& pasteboardName)
{
PlatformPasteboard(pasteboardName).getTypes(types);
Modified: trunk/Source/WebKit/win/ChangeLog (164669 => 164670)
--- trunk/Source/WebKit/win/ChangeLog 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebKit/win/ChangeLog 2014-02-25 21:35:27 UTC (rev 164670)
@@ -1,3 +1,14 @@
+2014-02-25 Anders Carlsson <[email protected]>
+
+ Get rid of VisitedLinkStrategy
+ https://bugs.webkit.org/show_bug.cgi?id=129324
+
+ Reviewed by Dan Bernstein.
+
+ * WebCoreSupport/WebPlatformStrategies.cpp:
+ (WebPlatformStrategies::getPluginInfo):
+ * WebCoreSupport/WebPlatformStrategies.h:
+
2014-02-24 Renata Hodovan <[email protected]>
Get rid of the unused 'immediate' parameters from repaint related functions
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebPlatformStrategies.cpp (164669 => 164670)
--- trunk/Source/WebKit/win/WebCoreSupport/WebPlatformStrategies.cpp 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebPlatformStrategies.cpp 2014-02-25 21:35:27 UTC (rev 164670)
@@ -83,11 +83,6 @@
return this;
}
-VisitedLinkStrategy* WebPlatformStrategies::createVisitedLinkStrategy()
-{
- return this;
-}
-
String WebPlatformStrategies::cookiesForDOM(const NetworkStorageSession& session, const URL& firstParty, const URL& url)
{
return WebCore::cookiesForDOM(session, firstParty, url);
@@ -155,13 +150,3 @@
outPlugins[i] = info;
}
}
-
-bool WebPlatformStrategies::isLinkVisited(Page* page, LinkHash hash, const URL&, const AtomicString&)
-{
- return page->group().isLinkVisited(hash);
-}
-
-void WebPlatformStrategies::addVisitedLink(Page* page, LinkHash hash)
-{
- page->group().addVisitedLinkHash(hash);
-}
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebPlatformStrategies.h (164669 => 164670)
--- trunk/Source/WebKit/win/WebCoreSupport/WebPlatformStrategies.h 2014-02-25 21:29:14 UTC (rev 164669)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebPlatformStrategies.h 2014-02-25 21:35:27 UTC (rev 164670)
@@ -33,9 +33,8 @@
#include <WebCore/PluginStrategy.h>
#include <WebCore/SharedWorkerStrategy.h>
#include <WebCore/StorageStrategy.h>
-#include <WebCore/VisitedLinkStrategy.h>
-class WebPlatformStrategies : public WebCore::PlatformStrategies, private WebCore::CookiesStrategy, private WebCore::DatabaseStrategy, private WebCore::LoaderStrategy, private WebCore::PluginStrategy, private WebCore::SharedWorkerStrategy, private WebCore::StorageStrategy, private WebCore::VisitedLinkStrategy {
+class WebPlatformStrategies : public WebCore::PlatformStrategies, private WebCore::CookiesStrategy, private WebCore::DatabaseStrategy, private WebCore::LoaderStrategy, private WebCore::PluginStrategy, private WebCore::SharedWorkerStrategy, private WebCore::StorageStrategy {
public:
static void initialize();
@@ -50,7 +49,6 @@
virtual WebCore::PluginStrategy* createPluginStrategy();
virtual WebCore::SharedWorkerStrategy* createSharedWorkerStrategy();
virtual WebCore::StorageStrategy* createStorageStrategy();
- virtual WebCore::VisitedLinkStrategy* createVisitedLinkStrategy();
// WebCore::CookiesStrategy
virtual String cookiesForDOM(const WebCore::NetworkStorageSession&, const WebCore::URL& firstParty, const WebCore::URL&);
@@ -66,10 +64,6 @@
// WebCore::PluginStrategy
virtual void refreshPlugins();
virtual void getPluginInfo(const WebCore::Page*, Vector<WebCore::PluginInfo>&);
-
- // WebCore::VisitedLinkStrategy
- virtual bool isLinkVisited(WebCore::Page*, WebCore::LinkHash, const WebCore::URL& baseURL, const WTF::AtomicString& attributeURL);
- virtual void addVisitedLink(WebCore::Page*, WebCore::LinkHash);
};
#endif // WebPlatformStrategies_h
